# HG changeset patch # User Jan Vrany # Date 1440433866 -3600 # Node ID cc0ce8edda6322d26aa80b9104c15552e8da72b8 # Parent 751532c8f3db6fc441c342886d2edd2ae2e37e79 Fixed PEGFsaState>>isFailure: it is not obsolete, actually. diff -r 751532c8f3db -r cc0ce8edda63 compiler/PEGFsaState.st --- a/compiler/PEGFsaState.st Mon Aug 24 15:56:20 2015 +0100 +++ b/compiler/PEGFsaState.st Mon Aug 24 17:31:06 2015 +0100 @@ -549,10 +549,12 @@ ! isFailure - self error: 'Obsolete?'. - " - ^ self isFinal and: [ retval class == PEGFsaFailure ] - " + self flag: 'JK, please check it and fix it'. + "`retval` is undefined, nowehere initialized so the + comparison is alway false. Therefore, returning + false unconditionally from here should suffice." + ^ self isFinal and: [ "retval class == PEGFsaFailure"false ]. + "Modified: / 17-08-2015 / 12:01:54 / Jan Vrany " !