Portability: Use `self skipIf:description:` on Smalltalk/X instead of `self skip:`
authorJan Vrany <jan.vrany@fit.cvut.cz>
Fri, 01 May 2015 14:34:58 +0200
changeset 444 a3657ab0ca6b
parent 443 2c87ed364404
child 445 eb33780df2f9
Portability: Use `self skipIf:description:` on Smalltalk/X instead of `self skip:`
compiler/tests/PPCInliningVisitorTest.st
compiler/tests/PPCOptimizingTest.st
--- a/compiler/tests/PPCInliningVisitorTest.st	Sat May 02 06:29:04 2015 +0200
+++ b/compiler/tests/PPCInliningVisitorTest.st	Fri May 01 14:34:58 2015 +0200
@@ -9,6 +9,7 @@
 	category:'PetitCompiler-Tests-Visitors'
 !
 
+
 !PPCInliningVisitorTest methodsFor:'as yet unclassified'!
 
 assert: object type: class
@@ -99,24 +100,23 @@
 !
 
 testPluggable
-	| pluggableNode |
-	pluggableNode := PPCPluggableNode new
-		block: [:ctx | nil] asParser.
-	node := PPCSequenceNode new
-		children: { pluggableNode  };
-		yourself.
+    | pluggableNode |
+    pluggableNode := PPCPluggableNode new
+            block: [:ctx | nil] asParser.
+    node := PPCSequenceNode new
+            children: { pluggableNode  };
+            yourself.
 
-	result := visitor visit: node.
-	    
-	((Smalltalk respondsTo:#isSmalltalkX) and:[ Smalltalk isSmalltalkX ]) ifTrue:
-	[  
-		self skip: 'skipped test, inlining of pluggable nodes not supported!!'.
-	].
+    result := visitor visit: node.
+        
+    ((Smalltalk respondsTo:#isSmalltalkX) and:[ Smalltalk isSmalltalkX ]) ifTrue:[  
+        self skipIf: true description: 'skipped test, inlining of pluggable nodes not supported!!'.
+    ].
 
-	self assert: result children first type: PPCPluggableNode.
-	self assert: result children first isMarkedForInline.
+    self assert: result children first type: PPCPluggableNode.
+    self assert: result children first isMarkedForInline.
 
-    "Modified: / 23-04-2015 / 12:18:34 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 01-05-2015 / 14:22:05 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 testSequenceInline
@@ -172,3 +172,10 @@
 	self assert: result child child type: PPCNilNode.
 ! !
 
+!PPCInliningVisitorTest class methodsFor:'documentation'!
+
+version_HG
+
+    ^ '$Changeset: <not expanded> $'
+! !
+
--- a/compiler/tests/PPCOptimizingTest.st	Sat May 02 06:29:04 2015 +0200
+++ b/compiler/tests/PPCOptimizingTest.st	Fri May 01 14:34:58 2015 +0200
@@ -138,7 +138,7 @@
 	tree := self optimize: [:ctx | nil] asParser star.
 
 	((Smalltalk respondsTo:#isSmalltalkX) and:[ Smalltalk isSmalltalkX ]) 
-		ifTrue:[ self skip: 'not supported in St/X' ].
+		ifTrue:[ self skipIf: true description: 'not supported in St/X' ].
 
 	self assert: tree type: PPCStarNode.
 	self assert: tree child type: PPCPluggableNode.