# HG changeset patch # User Claus Gittinger # Date 845482272 -7200 # Node ID 5c07f58a54c9b26d8e948cada3a8078cc54ee6a3 # Parent 64e428dbb53d3d39584d05d80760152425e116ab checkin from browser diff -r 64e428dbb53d -r 5c07f58a54c9 Class.st --- a/Class.st Wed Oct 16 18:06:17 1996 +0200 +++ b/Class.st Wed Oct 16 18:11:12 1996 +0200 @@ -4021,7 +4021,7 @@ This is done by checking the version methods return value against the version string as contained in the version method" - |cls meta cannotCheck versionMethod info + |cls meta cannotCheckReason versionMethod info versionFromCode versionFromSource oldPos pos src rev| self isMeta ifTrue:[ @@ -4030,7 +4030,7 @@ cls := self. meta := self class ]. - cannotCheck := false. + cannotCheckReason := nil. versionMethod := meta compiledMethodAt:#version. (versionMethod isNil @@ -4038,8 +4038,7 @@ versionMethod := cls compiledMethodAt:#version. (versionMethod isNil or:[versionMethod isExecutable not]) ifTrue:[ -"/ 'no version method' printCR. - cannotCheck := true. + cannotCheckReason := 'no version method'. ] ]. @@ -4049,8 +4048,7 @@ "/ versionFromCode := cls version. versionFromCode isString ifFalse:[ -"/ 'version method does not return a string' printCR. - cannotCheck := true + cannotCheckReason := 'version method does not return a string' ]. "/ @@ -4062,11 +4060,15 @@ "/ pos := versionMethod sourcePosition. pos isInteger ifFalse:[ -"/ 'no source position for version-method' printCR. - cannotCheck := true + "/ mhmh - either no version method, + "/ or updated due to a checkin. + "/ in any case, this should be a good source. + ^ true. + "/ cannotCheckReason := 'no source position for version-method' ]. - cannotCheck ifTrue:[ + cannotCheckReason notNil ifTrue:[ + ('CLASS: ' , cannotCheckReason) infoPrintCR. 'CLASS: cannot validate source; trusting source' infoPrintCR. ^ true ]. @@ -4093,12 +4095,12 @@ ]. ^ false - "Modified: 16.10.1996 / 17:04:22 / cg" + "Modified: 16.10.1996 / 17:10:24 / cg" ! ! !Class class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libbasic/Class.st,v 1.190 1996-10-16 16:06:17 cg Exp $' + ^ '$Header: /cvs/stx/stx/libbasic/Class.st,v 1.191 1996-10-16 16:11:12 cg Exp $' ! ! Class initialize!