# HG changeset patch
# User Claus Gittinger <cg@exept.de>
# Date 1330595810 -3600
# Node ID 3e8397061396c40f638aab1f3d5f50f5387b6ffc
# Parent  1724964c25a4774c44cae46a37fd0f7f10fcad34
fix: visibility switch and rationale did not work

diff -r 1724964c25a4 -r 3e8397061396 Tools__LintRuleDetail.st
--- a/Tools__LintRuleDetail.st	Thu Mar 01 10:55:40 2012 +0100
+++ b/Tools__LintRuleDetail.st	Thu Mar 01 10:56:50 2012 +0100
@@ -126,12 +126,13 @@
               verticalLayout: topSpaceFit
               horizontalSpace: 0
               verticalSpace: 0
-              ignoreInvisibleComponents: false
+              ignoreInvisibleComponents: true
               component: 
              (SpecCollection
                 collection: (
                  (ViewSpec
                     name: 'Label'
+                    visibilityChannel: false
                     component: 
                    (SpecCollection
                       collection: (
@@ -162,7 +163,7 @@
                     visibilityChannel: rationaleVisibleHolder
                     hasHorizontalScrollBar: true
                     hasVerticalScrollBar: true
-                    backgroundColor: (Color 86.9993133440146 86.9993133440146 86.9993133440146)
+                    backgroundColor: (Color 86.9993133440147 86.9993133440147 86.9993133440147)
                     htmlText: ruleRationaleAspect
                     extent: (Point 560 270)
                     postBuildCallback: setupHTMLView:
@@ -219,12 +220,13 @@
     "return/create the 'rationaleVisibleHolder' value holder (automatically generated)"
 
     rationaleVisibleHolder isNil ifTrue:[
-        rationaleVisibleHolder := ValueHolder with: false.
+        rationaleVisibleHolder := ValueHolder with: true "false".
         rationaleVisibleHolder addDependent:self.
     ].
     ^ rationaleVisibleHolder
 
     "Modified: / 04-08-2011 / 21:39:51 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 01-03-2012 / 08:50:20 / cg"
 !
 
 rationaleVisibleHolder:something
@@ -250,9 +252,11 @@
     "return/create the 'ruleHolder' value holder (automatically generated)"
 
     ruleHolder isNil ifTrue:[
-	ruleHolder := ValueHolder new.
+        ruleHolder := ValueHolder new.
     ].
     ^ ruleHolder
+
+    "Modified: / 01-03-2012 / 08:51:03 / cg"
 !
 
 ruleHolder:something
@@ -283,7 +287,7 @@
         holder := BlockValue
                     with:[:h | 
                         "/ h displayString , ' ' , (('[browse]' actionForAll:[ self browseLintRule]) colorizeAllWith:Color blue) 
-                        h displayString actionForAll:[ self browseLintRule] 
+                        (h ? '') displayString actionForAll:[ self browseLintRule ] 
                     ]
                     argument: self ruleHolder.
         builder aspectAt:#ruleNameAspect put:holder.
@@ -291,7 +295,7 @@
     ^ holder.
 
     "Modified: / 05-02-2010 / 12:51:30 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 07-09-2011 / 04:54:24 / cg"
+    "Modified: / 01-03-2012 / 08:44:23 / cg"
 !
 
 ruleRationaleAspect
@@ -383,6 +387,11 @@
 visibility: visibility height: height
     | container list detail h |
 
+"/ cg: the whole conatiner-container access chains below is ugly - use a name to access components.
+"/ and also: there is no layout in list, so the code does crash.
+"/ I disabled the whole visibility stuff.
+^ self.
+
     (container := self window container) isNil ifTrue:[^self].
     h := visibility ifFalse:[0] ifTrue:[height].
 
@@ -401,17 +410,17 @@
     ].
 
     "Created: / 11-03-2010 / 09:51:26 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 04-09-2011 / 20:15:40 / cg"
+    "Modified: / 01-03-2012 / 10:35:51 / cg"
 ! !
 
 !LintRuleDetail class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleDetail.st,v 1.10 2011-09-07 02:54:47 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleDetail.st,v 1.11 2012-03-01 09:56:50 cg Exp $'
 !
 
 version_CVS
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleDetail.st,v 1.10 2011-09-07 02:54:47 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleDetail.st,v 1.11 2012-03-01 09:56:50 cg Exp $'
 !
 
 version_SVN