# HG changeset patch # User Claus Gittinger # Date 1113470011 -7200 # Node ID 5b0673ccff1c067649da6df643596a376d7d4983 # Parent 9f51f2ae935aac87d8c0ca09d91911c8171d59d6 refactored intention revealing code: ... not ifTrue: -> ... ifFalse: diff -r 9f51f2ae935a -r 5b0673ccff1c AbstractDirectoryBrowser.st --- a/AbstractDirectoryBrowser.st Tue Apr 12 19:20:26 2005 +0200 +++ b/AbstractDirectoryBrowser.st Thu Apr 14 11:13:31 2005 +0200 @@ -105,8 +105,8 @@ aObject isFileObject ifFalse:[^ self]. checkObject := aObject theObject. - checkObject isFilename not ifTrue:[^ self]. - ((aContext dropSource argument == #archivApplication) not) ifTrue:[ + checkObject isFilename ifFalse:[^ self]. + (aContext dropSource argument == #archivApplication) ifFalse:[ checkObject isSpecialFile ifTrue:[^ self]. checkObject isReadable ifFalse:[^ self]. ]. @@ -208,5 +208,5 @@ !AbstractDirectoryBrowser class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/AbstractDirectoryBrowser.st,v 1.14 2004-08-04 18:00:18 cg Exp $' + ^ '$Header: /cvs/stx/stx/libtool/AbstractDirectoryBrowser.st,v 1.15 2005-04-14 09:13:31 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c AbstractFileBrowser.st --- a/AbstractFileBrowser.st Tue Apr 12 19:20:26 2005 +0200 +++ b/AbstractFileBrowser.st Thu Apr 14 11:13:31 2005 +0200 @@ -2750,7 +2750,7 @@ "returns the default aspect from the Userpreferences " - (self class userPreferencesAspectList includes:something) not ifTrue:[ ^ nil]. + (self class userPreferencesAspectList includes:something) ifFalse:[ ^ nil]. ^ UserPreferences current perform:something. ! ! @@ -3243,7 +3243,7 @@ dropedObjects isEmpty ifTrue:[^ false]. filenameDir := self getDirWithoutFileName:filename. - filenameDir isWritable not ifTrue:[^ false]. + filenameDir isWritable ifFalse:[^ false]. filenameDirString := filenameDir asString. dropedObjects do:[:aDropObject | @@ -4108,7 +4108,7 @@ ]. Dialog warn:msg withCRs ] do:[ - (fileName isSymbolicLink not) ifTrue:[ + (fileName isSymbolicLink) ifFalse:[ fileName remove. cmd := ('cvs remove -f ' , fileName baseName). (self getExecutionBlockForCommand:cmd) value:stream. @@ -6608,5 +6608,5 @@ !AbstractFileBrowser class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/AbstractFileBrowser.st,v 1.285 2005-03-31 18:50:08 cg Exp $' + ^ '$Header: /cvs/stx/stx/libtool/AbstractFileBrowser.st,v 1.286 2005-04-14 09:13:25 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c AbstractSettingsApplication.st --- a/AbstractSettingsApplication.st Tue Apr 12 19:20:26 2005 +0200 +++ b/AbstractSettingsApplication.st Thu Apr 14 11:13:31 2005 +0200 @@ -5153,7 +5153,7 @@ SmalltalkShareServer killAll ]. ] ifFalse:[ - SmalltalkShareServer serverRunning not ifTrue:[ + SmalltalkShareServer serverRunning ifFalse:[ SmalltalkShareServer start. "/ must wait a bit; give it a chance to "/ really start (before checking) @@ -5175,7 +5175,7 @@ WindowMigrationServer stop ]. ] ifFalse:[ - WindowMigrationServer serverRunning not ifTrue:[ + WindowMigrationServer serverRunning ifFalse:[ WindowMigrationServer start. "/ must wait a bit; give it a chance to "/ really start (before checking) @@ -11256,5 +11256,5 @@ !AbstractSettingsApplication class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/AbstractSettingsApplication.st,v 1.192 2005-02-23 15:32:14 cg Exp $' -! ! + ^ '$Header: /cvs/stx/stx/libtool/AbstractSettingsApplication.st,v 1.193 2005-04-14 09:13:18 cg Exp $' +! ! diff -r 9f51f2ae935a -r 5b0673ccff1c DirectoryContentsBrowser.st --- a/DirectoryContentsBrowser.st Tue Apr 12 19:20:26 2005 +0200 +++ b/DirectoryContentsBrowser.st Thu Apr 14 11:13:31 2005 +0200 @@ -1071,7 +1071,7 @@ addItemCol notEmpty ifTrue:[ browserList := self browserItemList copy. addItemCol do:[: aNewItem | - (browserList includes:aNewItem) not ifTrue:[ + (browserList includes:aNewItem) ifFalse:[ browserList add:aNewItem. browserList := self sortBlockHolder value sortItemList:browserList. self browserItemList add:aNewItem beforeIndex:(browserList indexOf:aNewItem). @@ -1380,7 +1380,7 @@ "/ selection is gone keep the current directory list ^ self ]. - (self currentFilesAreInSameDirectory not) ifTrue:[ + (self currentFilesAreInSameDirectory) ifFalse:[ self directory:nil. ^ self ]. @@ -2346,7 +2346,7 @@ theAllItems removeAll:remItems ]. addItems do:[: aNewItem | - (theAllItems includes:aNewItem) not ifTrue:[ + (theAllItems includes:aNewItem) ifFalse:[ theAllItems add:aNewItem. ] ]. @@ -2372,9 +2372,9 @@ anItemsList size ~~ 0 ifTrue:[ anItemsList do:[:eachItem | |isDir| isDir := eachItem isDirectory. - isDir not ifTrue:[noOfFiles := noOfFiles + 1]. + isDir ifFalse:[noOfFiles := noOfFiles + 1]. ((isDir and:[showDir]) or:[isDir not and:[ showFiles and:[filterBlock value:eachItem baseName]]]) ifTrue:[ - isDir not ifTrue:[noOfAddedFiles := noOfAddedFiles + 1]. + isDir ifFalse:[noOfAddedFiles := noOfAddedFiles + 1]. newItemList add:eachItem ]. ]. @@ -3193,5 +3193,5 @@ !DirectoryContentsBrowser class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/DirectoryContentsBrowser.st,v 1.177 2005-03-17 10:13:41 penk Exp $' + ^ '$Header: /cvs/stx/stx/libtool/DirectoryContentsBrowser.st,v 1.178 2005-04-14 09:13:08 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c DirectoryTreeBrowser.st --- a/DirectoryTreeBrowser.st Tue Apr 12 19:20:26 2005 +0200 +++ b/DirectoryTreeBrowser.st Thu Apr 14 11:13:31 2005 +0200 @@ -888,7 +888,7 @@ (newDest isNil or:[newDest == self fileList draggedItem]) ifTrue:[ ^ self ]. - newDest isDirectory not ifTrue:[ + newDest isDirectory ifFalse:[ newDest := nil. canDropItem := false. ]. @@ -1318,5 +1318,5 @@ !DirectoryTreeBrowser class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/DirectoryTreeBrowser.st,v 1.93 2004-12-30 12:58:25 penk Exp $' + ^ '$Header: /cvs/stx/stx/libtool/DirectoryTreeBrowser.st,v 1.94 2005-04-14 09:13:02 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c FileApplicationNoteBook.st --- a/FileApplicationNoteBook.st Tue Apr 12 19:20:26 2005 +0200 +++ b/FileApplicationNoteBook.st Thu Apr 14 11:13:31 2005 +0200 @@ -358,7 +358,7 @@ anItem notNil ifTrue:[ isDirectory := anItem isDirectory or:[anItem linkTargetIsDirectory ]. - (isDirectory not) ifTrue:[ + isDirectory ifFalse:[ (aAppl changeItem:anItem) ifFalse:[ ^ self]. self fileHistory add:anItem. self enableFileHistory value:true. @@ -583,7 +583,7 @@ |sameFiles index item| - self class openAnotherApplicationOnSameItem not ifTrue:[ + self class openAnotherApplicationOnSameItem ifFalse:[ anAppl sameFileIndex:nil. ^ self. ]. @@ -2352,7 +2352,7 @@ dropedObjects do:[:aObject| |checkObject checkObjectString| aObject isFileObject ifFalse:[^ self]. checkObject := aObject theObject. - checkObject isFilename not ifTrue:[^ self]. + checkObject isFilename ifFalse:[^ self]. checkObject isSpecialFile ifTrue:[^ self]. ]. inDropMode := true. @@ -4491,7 +4491,7 @@ ]. fnDir := fn directory. - fnDir exists not ifTrue:[ + fnDir exists ifFalse:[ fnDir recursiveMakeDirectory. ]. (editView saveAs:fn) ifFalse:[^ self]. @@ -5530,5 +5530,5 @@ !FileApplicationNoteBook class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/FileApplicationNoteBook.st,v 1.183 2005-03-04 14:17:40 cg Exp $' + ^ '$Header: /cvs/stx/stx/libtool/FileApplicationNoteBook.st,v 1.184 2005-04-14 09:12:54 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c FileBrowser.st --- a/FileBrowser.st Tue Apr 12 19:20:26 2005 +0200 +++ b/FileBrowser.st Thu Apr 14 11:13:31 2005 +0200 @@ -4605,7 +4605,7 @@ ] do:[ |answer contents| - (f isSymbolicLink not) ifTrue:[ + f isSymbolicLink ifFalse:[ self doExecuteCommand:('cvs remove -f ' , f baseName) replace:false. @@ -7433,5 +7433,5 @@ !FileBrowser class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/FileBrowser.st,v 1.599 2005-03-11 12:57:23 cg Exp $' + ^ '$Header: /cvs/stx/stx/libtool/FileBrowser.st,v 1.600 2005-04-14 09:12:45 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c FileDialog.st --- a/FileDialog.st Tue Apr 12 19:20:26 2005 +0200 +++ b/FileDialog.st Thu Apr 14 11:13:31 2005 +0200 @@ -1371,7 +1371,7 @@ and:[newFile asFilename isDirectory]]) ifTrue:[ entryFieldFilename := self filenameHolder value asFilename. self startFilename asFilename baseName = entryFieldFilename baseName ifTrue:[ - entryFieldFilename isDirectory not ifTrue:[ + entryFieldFilename isDirectory ifFalse:[ newFile := newFile asFilename construct:entryFieldFilename baseName. ]. ]. @@ -1625,5 +1625,5 @@ !FileDialog class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/FileDialog.st,v 1.81 2004-11-04 15:19:16 cg Exp $' + ^ '$Header: /cvs/stx/stx/libtool/FileDialog.st,v 1.82 2005-04-14 09:12:38 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c FileOperation.st --- a/FileOperation.st Tue Apr 12 19:20:26 2005 +0200 +++ b/FileOperation.st Thu Apr 14 11:13:31 2005 +0200 @@ -319,7 +319,7 @@ newFile := aDestFile. ]. "/ do not copy if destination directory doest exist. - (targetDirectory exists not) ifTrue:[ + targetDirectory exists ifFalse:[ Dialog warn:'cant copy to not existing directory ', targetDirectory asString. result := false. ^ self @@ -643,7 +643,7 @@ box addAbortAndOkButtons. - aFile isDirectory not ifTrue:[ + aFile isDirectory ifFalse:[ box focusOnField:if1. ]. box showAtPointer. @@ -1006,7 +1006,7 @@ newFile := aDestFile. ]. "/ do not copy if destination directory doest exist. - (targetDirectory exists not) ifTrue:[ + targetDirectory exists ifFalse:[ Dialog warn:'Cannot move to non-existing directory ', targetDirectory asString. result := false. ^ self @@ -1285,5 +1285,5 @@ !FileOperation class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/FileOperation.st,v 1.65 2005-02-14 16:13:59 cg Exp $' + ^ '$Header: /cvs/stx/stx/libtool/FileOperation.st,v 1.66 2005-04-14 09:12:32 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c FilenameEditFieldV2.st --- a/FilenameEditFieldV2.st Tue Apr 12 19:20:26 2005 +0200 +++ b/FilenameEditFieldV2.st Thu Apr 14 11:13:31 2005 +0200 @@ -190,7 +190,7 @@ isMultiMatch := true. ]. ]. - isMultiMatch not ifTrue:[ + isMultiMatch ifFalse:[ newString asFilename pathName = canonContents ifTrue:[ [self flash] fork. ]. @@ -276,5 +276,5 @@ !FilenameEditFieldV2 class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/FilenameEditFieldV2.st,v 1.10 2004-11-11 09:13:06 cg Exp $' + ^ '$Header: /cvs/stx/stx/libtool/FilenameEditFieldV2.st,v 1.11 2005-04-14 09:12:24 cg Exp $' ! ! diff -r 9f51f2ae935a -r 5b0673ccff1c FindFileApplication.st --- a/FindFileApplication.st Tue Apr 12 19:20:26 2005 +0200 +++ b/FindFileApplication.st Thu Apr 14 11:13:31 2005 +0200 @@ -628,7 +628,7 @@ Dialog warn:'Missing directory name'. ^ self. ]. - dir asFilename exists not ifTrue:[ + dir asFilename exists ifFalse:[ Dialog warn:('No such directory: ''%1''' bindWith:dir asString allBold). ^ self. ]. @@ -1482,7 +1482,7 @@ info at:1 put:filesSize. ]. (idxInList := fileSizesToSearchFor indexOf:filesSize) ~~ 0 ifTrue:[ - (setOfFilesToSearchFor includes:fn) not ifTrue:[ + (setOfFilesToSearchFor includes:fn) ifFalse:[ fn asFilename exists ifFalse:[ info at:1 put:nil. info at:2 put:nil. @@ -1628,5 +1628,5 @@ !FindFileApplication class methodsFor:'documentation'! version - ^ '$Header: /cvs/stx/stx/libtool/FindFileApplication.st,v 1.69 2005-02-11 15:09:37 mb Exp $' + ^ '$Header: /cvs/stx/stx/libtool/FindFileApplication.st,v 1.70 2005-04-14 09:12:17 cg Exp $' ! !