valueOf* methods renamed
authorClaus Gittinger <cg@exept.de>
Wed, 15 Feb 2006 18:24:29 +0100
changeset 1987 3889bd6912fb
parent 1986 5cb77205ce00
child 1988 1f898443e253
valueOf* methods renamed
ImageEditor.st
--- a/ImageEditor.st	Wed Feb 15 18:24:02 2006 +0100
+++ b/ImageEditor.st	Wed Feb 15 18:24:29 2006 +0100
@@ -1536,7 +1536,7 @@
                                 layout: (LayoutFrame -57 1 -22 1 -26 1 0 1)
                                 activeHelpKey: magnificationNumber
                                 enableChannel: imageIsLoaded
-                                model: valueOfMagnification
+                                model: magnificationHolder
                                 type: numberInRange
                                 acceptOnReturn: true
                                 acceptOnTab: true
@@ -1849,7 +1849,7 @@
               (
                (MenuItem
                   activeHelpKey: editUndo
-                  enabled: valueOfCanUndo
+                  enabled: canUndoHolder
                   label: 'Undo'
                   itemValue: doUndo
                   translateLabel: true
@@ -2411,7 +2411,7 @@
           )
          (MenuItem
             activeHelpKey: editUndo
-            enabled: valueOfCanUndo
+            enabled: canUndoHolder
             label: 'Undo'
             itemValue: doUndo
             translateLabel: true
@@ -2828,7 +2828,7 @@
 !ImageEditor methodsFor:'aspects'!
 
 activityInfoHolder
-    ^ self valueOfInfoLabel
+    ^ self infoLabelHolder
 
     "Modified: / 29.7.1998 / 18:49:03 / cg"
 !
@@ -2920,6 +2920,17 @@
     ^ list
 !
 
+magnificationHolder
+    "returns current magnification of the image as an AspectAdaptor"
+
+    |holder|
+    (holder := builder bindingAt:#valueOfMagnification) isNil ifTrue:[
+        builder aspectAt:#valueOfMagnification put:(
+        holder := AspectAdaptor new subject:self; forAspect:#magnification)
+    ].
+    ^ holder
+!
+
 previewBackgroundColor
     |holder|
     (holder := builder bindingAt:#previewBackgroundColor) isNil ifTrue:[
@@ -2954,12 +2965,8 @@
 valueOfMagnification
     "returns current magnification of the image as an AspectAdaptor"
 
-    |holder|
-    (holder := builder bindingAt:#valueOfMagnification) isNil ifTrue:[
-        builder aspectAt:#valueOfMagnification put:(
-        holder := AspectAdaptor new subject:self; forAspect:#magnification)
-    ].
-    ^ holder
+    self obsoleteMethodWarning:'stupid method name - use #magnificationHolder'.
+    ^ self magnificationHolder
 ! !
 
 !ImageEditor methodsFor:'change & update'!
@@ -3064,7 +3071,7 @@
     ].
 
     changedObject == imageEditView undoImages ifTrue:[
-        self valueOfCanUndo value:(changedObject notEmpty).
+        self canUndoHolder value:(changedObject notEmpty).
         ^ self.
     ].
 
@@ -4778,11 +4785,11 @@
 !
 
 doMagnifyDown
-    "magnifies current image one step down"
+    "magnifies the current image one step down"
 
     |magHolder mag|
 
-    magHolder := self valueOfMagnification.
+    magHolder := self magnificationHolder.
     (mag := magHolder value) > 1 ifTrue: [
         magHolder value: mag - 1
     ]
@@ -4846,11 +4853,11 @@
 !
 
 doMagnifyUp
-    "magnifies current image one step up"
+    "magnifies the current image one step up"
 
     |magHolder mag|
 
-    magHolder := self valueOfMagnification.
+    magHolder := self magnificationHolder.
     (mag := magHolder value) < 99 ifTrue: [
         magHolder value: mag + 1
     ]