code cleanup
authorClaus Gittinger <cg@exept.de>
Fri, 19 Mar 1999 22:07:28 +0100
changeset 1069 7196ca547f5d
parent 1068 dcb2cba5787f
child 1070 1735e40c6825
code cleanup
DataSetBuilder.st
MenuEditor.st
UILayoutTool.st
UIPainterView.st
UISpecificationTool.st
--- a/DataSetBuilder.st	Fri Mar 19 22:02:01 1999 +0100
+++ b/DataSetBuilder.st	Fri Mar 19 22:07:28 1999 +0100
@@ -2566,7 +2566,6 @@
         ]
     ].
     self specChannel value:specSelector.
-"/    (self window notNil and: [self window shown]) ifTrue: [self updateFonts]
 
 ! !
 
--- a/MenuEditor.st	Fri Mar 19 22:02:01 1999 +0100
+++ b/MenuEditor.st	Fri Mar 19 22:07:28 1999 +0100
@@ -2290,7 +2290,6 @@
         aspects do: [:holder| holder removeDependent:self].
         specCanvas client:self spec:(self class perform:(slices at:tabSelection) last) builder:builder.
         aspects do: [:holder| holder addDependent:self].
-"/        self updateFonts.
         specCanvas raise.
     ]
 
--- a/UILayoutTool.st	Fri Mar 19 22:02:01 1999 +0100
+++ b/UILayoutTool.st	Fri Mar 19 22:07:28 1999 +0100
@@ -766,7 +766,6 @@
 
         appl notNil ifTrue:[
             noteBook scrolledView allViewBackground:(noteBook viewBackground).
-"/            masterApplication updateFonts
         ]
     ].
     self update
--- a/UIPainterView.st	Fri Mar 19 22:02:01 1999 +0100
+++ b/UIPainterView.st	Fri Mar 19 22:07:28 1999 +0100
@@ -699,7 +699,7 @@
      - but do not overwrite existing ones.
      Return a string ready to compile into the application class."
 
-    |cls code skip menuSelector protoSpec thisCode
+    |cls code skip protoSpec thisCode
      definedMethodSelectors iVars t|
 
     definedMethodSelectors := IdentitySet new.
@@ -717,7 +717,7 @@
     ].
 
     treeView propertiesDo:[:aProp|
-        |modelSelector menuSelector|
+        |modelSelector|
 
         protoSpec := aProp spec.
 
@@ -856,7 +856,7 @@
      - but do not overwrite existing ones.
      Return a string ready to compile into the application class."
 
-    |cls code skip menuSelector protoSpec thisCode|
+    |cls code|
 
     code := ''.
 
@@ -1035,19 +1035,19 @@
      - but do not overwrite existing ones.
      Return a string ready to compile into the application class."
 
-    |cls code skip menuSelector protoSpec thisCode
-     definedMethodSelectors iVars t 
+    |cls code menuSelector thisCode
+     definedMethodSelectors
      specArray fullSpec winSpec menuSpec
      |
 
     className isNil ifTrue:[
-        self warn:'Set first the class!!'.
-        ^ code
+        self warn:'Define the class first !!'.
+        ^ nil
     ].
 
     (cls := self resolveName:className) isNil ifTrue:[
         self warn:'Class ', className asString, ' does not exist!!'.
-        ^ code
+        ^ nil
     ].
 
     specArray := treeView generateFullSpecForComponents:#() named:nil.
@@ -1055,13 +1055,10 @@
     winSpec := fullSpec window.
     menuSelector := winSpec menu.
 
-    menuSelector isNil ifTrue:[
+    (menuSelector notNil 
+    and:[ (cls respondsTo:menuSelector) ]) ifFalse:[
         self warn:'No menu defined (yet)'.
-        ^ code
-    ].
-    (cls respondsTo:menuSelector) ifFalse:[
-        self warn:'No menu defined (yet)'.
-        ^ code.
+        ^ nil.
     ].
     menuSpec := cls perform:menuSelector.
     menuSpec := menuSpec decodeAsLiteralArray.
--- a/UISpecificationTool.st	Fri Mar 19 22:02:01 1999 +0100
+++ b/UISpecificationTool.st	Fri Mar 19 22:07:28 1999 +0100
@@ -731,7 +731,7 @@
 selection:something
     "selection changed
     "
-    |slices idx spec frame y window|
+    |slices idx spec window|
 
     specification notNil ifTrue:[
         slices := specification class slices.
@@ -753,7 +753,6 @@
 
             window allViewBackground:(self windowFrame viewBackground).
             window extent:1.0@(window preferredExtent y).
-"/            masterApplication updateFonts.
             window realizeAllSubViews.
             self scrolledView sizeChanged:nil.
         ]