Issue #247: add a big FAT warning comment to prevent this regression creeping back
During packaginh of a toy archive, assignment to `stx_version` variable in
`smalltalk.bat` is patched to contain actual version. Any change in that line,
no matter how subtle, may cause the pattern matching in `dist-jv.rake` to fail,
leading to a wrong package path.
To avoid this regression, add a BIG FAT WARNING for anyone who might be
tempted to change this line again.
https://swing.fit.cvut.cz/projects/stx-jv/ticket/247
--- a/smalltalk.bat Mon Sep 24 20:52:34 2018 +0100
+++ b/smalltalk.bat Fri Oct 26 09:56:43 2018 +0100
@@ -56,9 +56,14 @@
SET "batch_script_version=1.6.8"
:: Smalltalk/X
SET "stx_version_default=8.0.0"
-:: Do not change following line, $STX_VERSION_DEFAULT serves
+:: Do not change following line, $stx_version_default serves
:: as placeholder and it's being replaced during installation
:: process (`rake install`)
+::
+:: !!! BIG FAT WARNING !!!
+:: Never ever change anything in the line below. If you absolutely must
+:: change it, then you ABSOLUTELY MUST update Smalltalk/X rakefiles,
+:: see call to the `sed` in `rakefiles/dist-jv.rake`, rule :scripts.
SET "stx_version=%stx_version_default%"
:: ====================