Context Navigation

Back to Ticket #126

Ticket #126: issue_126_patch_1_of_1_r93c03926d389.patch

File issue_126_patch_1_of_1_r93c03926d389.patch, 6.5 KB (added by Patrik Svestka, 6 years ago)
Drawing TextOutA and TextOutW chunk-by-chunk

WinWorkstation.st

# HG changeset patch
# User Patrik Svestka <patrik.svestka@gmail.com>
# Date 1491301233 -7200
#      Tue Apr 04 12:20:33 2017 +0200
# Branch jv
# Node ID 93c03926d389d69f8e76ee3198b2a3a00ce0ac3e
# Parent  76834c6940c7f04c6aa22cdd3669b263e64b0fb6
Issue #126: String text becomes invisible when string length exceeds buffer

Patch fixes an issue, for both TextOutA and TextOutW, where strings longer than 3275 characters fail to draw.

The maximum display buffer is currently at 3275 characters (found by Jan's experiments).  If the string is shorter
than this buffer than a simple if with SetTextAlign, MoveToEx, and TextOut(A)||(W) is used (no loop).  If the string
is longer than that there is a while that itterates throught the whole string.  At the end of the string, when it
is shorter than buffer, (no loop) code is re-used again.



https://swing.fit.cvut.cz/projects/stx-jv/ticket/126

user: Patrik Svestka <patrik.svestka@gmail.com>
branch 'jv'
changed WinWorkstation.st

diff -r 76834c6940c7 -r 93c03926d389 WinWorkstation.st

-                      a
 %{  /* NOCONTEXT */
     unsigned char *cp;
     OBJ cls;
+    int i1, i2, l, n;
+    int nInstBytes;
+    long i1, i2, n, l, toDisplay;
+    long nInstBytes;
     if (__isExternalAddress(aGCId)
      && __isNonNilObject(aString)
 …
      && __bothSmallInteger(x, y))
+    {
         struct gcData *gcData;
         int pX, pY;
+        long pX, pY;
         HDC hDC;
         HFONT hOldFont;
+  /* Windows (as in 7 or newer) limits the string size for TextOut* to 3275 */
+  const int maxDisplayBuffer = 3275;
         i1 = __intVal(index1) - 1;
         i2 = __intVal(index2) - 1;
         if ((i1 < 0) || (i2 < i1)) {
 …
 #endif
         cls = __qClass(aString);
         cp = __stringVal(aString);
         l = i2 - i1 + 1;
+        if (l > 32758) {
+            /* Windows (as in XP) limits the string size for TextOut* to 32758 */
+            l = 32758;
+        }
+        if (__isStringLike(aString)) {
+            n = __stringSize(aString);
+commonOutChars:
+            if (i2 < n) {
+                cp += i1;
+                CPRINTF(("string1: %s pos=%d/%d l=%d hDC=%x\n", cp, pX, pY,l,hDC));
+                if (! TextOutA(hDC, pX, pY, (char *)cp, l)) {
+                    PRINTF(("WinWorkstation [warning]: TextOutA failed. [%d]\n", __LINE__));
+                    PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+                    goto error;
+                }
+            }
+            goto ret;
+        }
+        toDisplay = l;
+  if (__isStringLike(aString)) {
+    n = __stringSize(aString);
+    commonOutCharsA:
+    if (i2 < n){
+      cp += i1;
+      if (toDisplay <= maxDisplayBuffer){
+        /* set position only during first run */
+        if (toDisplay == l){
+            SetTextAlign(hDC, TA_UPDATECP);
+            MoveToEx(hDC, pX, pY, NULL);
+        }
+        if (! TextOutA(hDC, 0, 0, (char *)cp, toDisplay)) {
+          PRINTF(("WinWorkstation [warning]: TextOutA failed. [%d]\n", __LINE__));
+          PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+          goto error;
+        }
+      }
+      else {
+        SetTextAlign(hDC, TA_UPDATECP);
+        MoveToEx(hDC, pX, pY, NULL);
+        /* duplicated to speedup very long strings */
+        if (! TextOutA(hDC, 0, 0, (char *)cp, maxDisplayBuffer)) {
+            PRINTF(("WinWorkstation [warning]: TextOutA failed. [%d]\n", __LINE__));
+            PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+            goto error;
+          }
+        pX = maxDisplayBuffer;
+        cp += maxDisplayBuffer;
+        toDisplay -= maxDisplayBuffer;
+        while(toDisplay > maxDisplayBuffer){
+          if (! TextOutA(hDC, 0, 0, (char *)cp, maxDisplayBuffer)) {
+            PRINTF(("WinWorkstation [warning]: TextOutA failed. [%d]\n", __LINE__));
+            PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+            goto error;
+          }
+          pX += maxDisplayBuffer;
+          cp += maxDisplayBuffer;
+          toDisplay -= maxDisplayBuffer;
+        }
+        if (toDisplay > 0){
+          goto commonOutCharsA;
+        }
+      }
+    }
+    goto ret;
+  }
         nInstBytes = __OBJS2BYTES__(__intVal(__ClassInstPtr(cls)->c_ninstvars));
         cp += nInstBytes;
         n = __byteArraySize(aString) - nInstBytes;
         if (__isBytes(aString)) {
+            goto commonOutChars;
+        }
+        /* Unicode */
+        if (__isWords(aString)) {
+            n = n / 2;
+            if (i2 < n) {
+                WIDECHAR *w_cp = (WIDECHAR *)cp;
+                w_cp += i1;
+                if (! TextOutW(hDC, pX, pY, w_cp, l)) {
+                    PRINTF(("WinWorkstation [warning]: TextOutW failed. [%d]\n", __LINE__));
+                    PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+                }
+                goto ret;
+            }
+        }
+          goto commonOutCharsA;
+        }
+  /* Unicode */
+  if (__isWords(aString)) {
+    n = n / 2;
+    WIDECHAR *w_cp = (WIDECHAR *)cp;
+    commonOutCharsW:
+    if (i2 < n){
+      w_cp += i1;
+      if (toDisplay <= maxDisplayBuffer){
+        /* set position only during first run */
+        if (toDisplay == l){
+            SetTextAlign(hDC, TA_UPDATECP);
+            MoveToEx(hDC, pX, pY, NULL);
+        }
+        if (! TextOutW(hDC, 0, 0, w_cp, l)) {
+          PRINTF(("WinWorkstation [warning]: TextOutW failed. [%d]\n", __LINE__));
+          PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+        }
+      }
+      else {
+        SetTextAlign(hDC, TA_UPDATECP);
+        MoveToEx(hDC, pX, pY, NULL);
+        /* duplicated to speedup very long strings */
+        if (! TextOutW(hDC, 0, 0, w_cp, l)) {
+          PRINTF(("WinWorkstation [warning]: TextOutW failed. [%d]\n", __LINE__));
+          PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+        }
+        pX = maxDisplayBuffer;
+        w_cp += maxDisplayBuffer;
+        toDisplay -= maxDisplayBuffer;
+        while(toDisplay > maxDisplayBuffer){
+          if (! TextOutW(hDC, 0, 0, w_cp, l)) {
+            PRINTF(("WinWorkstation [warning]: TextOutW failed. [%d]\n", __LINE__));
+            PRINTF(("WinWorkstation [warning]: lastError=%d x:%d y:%d len:%d\n", GetLastError(), pX, pY, l));
+          }
+          pX += maxDisplayBuffer;
+          w_cp += maxDisplayBuffer;
+          toDisplay -= maxDisplayBuffer;
+        }
+        if (toDisplay > 0){
+          goto commonOutCharsW;
+        }
+      }
+    }
+    goto ret;
+  }
 ret:;
 #if 0
         GcDataReleasePen(hDC, gcData);

Download in other formats:

Original Format