Ticket #176: smallsense_fix_1_of_1_rev_b6dbdc4fd7f5_Issue__176__fix__disappearing__completon_view_when_pointer_moves_out_of_it.patch

SmallSense__CompletionController.st

@@ -498 +498 @@
             movePos y: (movePos y - windowExtent y - editView font maxHeight - 5).
         ].
         topView origin:movePos.
+        topView 
+            bePopUpView;
+            beSlave.
 "/        topView resizeToFit.
         self updateSelection ifFalse:[
-            topView open.
+            topView openModal.
         ].
     ] ifFalse:[
         completionView list:list.
@@ -514 +517 @@
 
     "Created: / 27-09-2013 / 14:01:27 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified: / 15-05-2014 / 11:30:06 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified (format): / 15-03-2018 / 10:47:27 / jv"
 !
 
 updateCompletions: completionResult sequence: sequence

SmallSense__CompletionView.st

@@ -20 +20 @@
 
 "{ NameSpace: SmallSense }"
 
-SimpleView subclass:#CompletionView
+TopView subclass:#CompletionView
         instanceVariableNames:'completionController completionContext list listHolder listView
                 selectionHolder helpHolder helpView'
         classVariableNames:''
@@ -125 +125 @@
 !CompletionView methodsFor:'event handling'!
 
 keyPress:key x:x y:y
-    x isNil ifTrue:[ 
-        "/ Already re-delegated    
-        ^ self
-    ].
     key == #Escape ifTrue:[ 
         completionController closeCompletionView.
         ^ self
-    ].
+    ].  
     (key == #CursorDown
         or:[ key == #CursorUp
-        or:[ key == #CursorLeft
-        or:[ key == #CursorRight
-        or:[ ((key == #Return) and:[ self hasSelection ])]]]]) ifTrue:[ 
+        or:[ ((key == #Return) and:[ self hasSelection ])]]) ifTrue:[ 
             listView keyPress:key x:x y:y.
             ^ self
         ].
@@ -145 +139 @@
     ^ completionController editView keyPress:key x:x y:y
 
     "Created: / 27-09-2013 / 14:05:54 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 31-03-2014 / 22:53:43 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified: / 18-01-2018 / 23:10:58 / jv"
+    "Modified (comment): / 17-04-2018 / 15:14:00 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+!
+
+keyPress:key x:x y:y view: view
+    view == listView ifTrue:[ 
+        (key == #CursorDown
+        or:[ key == #CursorUp
+        or:[ key == #Return]]) ifTrue:[ 
+            ^ false
+        ] ifFalse:[ 
+            completionController editView keyPress:key x:x y:y.
+            ^ true
+        ].
+    ].
+    ^ false
+
+    "Created: / 17-04-2018 / 09:54:56 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified (comment): / 17-04-2018 / 15:13:49 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 ! !
 
 !CompletionView methodsFor:'initialization & release'!
@@ -168 +179 @@
     listView := listViewScroller scrolledView.
     listView listHolder: listHolder.
     listView model: selectionHolder.
+    listView delegate: self.
     listView highlightMode: #line.
     listView doubleClickAction:[:index | self complete: index ].
 
@@ -182 +194 @@
     self extent: 400 @ 250
 
     "Created: / 27-09-2013 / 13:56:33 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 04-04-2014 / 15:03:47 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 17-04-2018 / 09:53:49 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 ! !
 
 !CompletionView methodsFor:'queries'!
 
+handlesKeyPress: key inView: view
+    ^ view == listView and:[ key isCharacter ]
+
+    "Created: / 17-04-2018 / 09:55:31 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+!
+
 hasSelection
     ^listView hasSelection