Ticket #252: libbasic_fix_1_of_1_rev_6dfa3e4e2c32_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch

Win32OperatingSystem.st

@@ -15911 +15911 @@
     "return the keys full key path name"
 
     ^ path.
+!
+
+valueTypeAndSize:nameString
+    "Returns a Windows registry dictinary (#type -> size) based on value name 
+    REG_NONE        -> nil
+    REG_BINARY      -> ByteArray
+    REG_SZ          -> String
+    REG_EXPAND_SZ   -> String (unexpadned windows variables)
+    REG_DWORD       -> Integer (can be LITTLE_ENDIAN or BIG_ENDIAN)
+    REG_DWORD       -> 64bit Integer
+    REG_MULTI_SZ    -> Array of strings (note: dataSize returns number of bytes)
+    "
+
+    |windowsRegistryTable nameUtf16Z errorNumber|
+
+    windowsRegistryTable := Dictionary new.
+
+    "/ adding terminating null into empty string
+    nameString notNil ifTrue:[
+        nameUtf16Z := nameString isEmpty ifTrue:[(nameString, (Character codePoint: 0)) asUnicode16String] "/ needed for defaultValue
+                                        ifFalse:[nameString asUnicode16StringZ]
+    ].
+
+%{
+    HKEY myKey;
+    DWORD valueType;
+
+    DWORD dataSize, sizeInChars, sizeInBytes = 0;
+
+    if (__isExternalAddressLike(__INST(handle))
+     && __isUnicode16String(nameUtf16Z)) {
+    int ret;
+
+    myKey = (HKEY)__externalAddressVal(__INST(handle));
+
+    // Getting valuetype and dataSize (actual data is not important)
+    ret = RegQueryValueExW(myKey, __unicode16StringVal(nameUtf16Z),
+             NULL,
+             &valueType,
+             NULL,
+             &dataSize);
+
+    if (ret == ERROR_SUCCESS) {
+        switch (valueType) {
+        case REG_NONE: // returns alwyas REG_NONE -> 0
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_NONE), __MKUINT(0));
+            break;
+
+        case REG_BINARY:
+            sizeInBytes = dataSize;      
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_BINARY), __MKUINT(sizeInBytes));
+            break;
+
+        case REG_SZ:
+            sizeInChars = (dataSize / sizeof(wchar_t)) - 1; // (datasize / character width) - terminating NULL
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_SZ), __MKUINT(sizeInChars));
+            break;
+
+        case REG_EXPAND_SZ:
+            sizeInChars = (dataSize / sizeof(wchar_t)) - 1; // (datasize / character width) - terminating NULL
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_EXPAND_SZ), __MKUINT(sizeInChars));
+            break;
+
+        case REG_DWORD_LITTLE_ENDIAN:
+            sizeInBytes = dataSize; // bytes of the registry type
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_DWORD_LITTLE_ENDIAN), __MKUINT(sizeInBytes));
+            break;
+
+        case REG_DWORD_BIG_ENDIAN:
+            sizeInBytes = dataSize; // bytes of the registry type
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_DWORD_BIG_ENDIAN), __MKUINT(sizeInBytes));
+            break;
+        
+        case REG_QWORD:
+            sizeInBytes = dataSize; // bytes of the registry type
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_QWORD), __MKUINT(sizeInBytes));
+            break;
+           
+        case REG_MULTI_SZ:
+            {
+            /* dataSize note: 
+             * Since we are not reading the actual data there is unknown number of terminaing NULL (every array item has one) and
+             * the end of the array has addtional one.  User has to count manually the number of terminaing NULL(s).
+             * 
+             * A general formula for calculating size for REG_MULTI_SZ:
+             * ((array node size(1) + terminating NULL) + (array node size(2) + terminating NULL) + ... + (array node size(n) + terminating NULL)) * character width (sizeof(wchar_t)) - last terminating NULL (-1)
+             * A Smalltalk/C way:
+             * (((Array at: 1) size + 1) + ((Array at: 2) size + 1) + ... + ((Array at: n) size + 1))) * sizeof(wchar_t) - 1
+             */
+            sizeInBytes = dataSize;
+            __AT_PUT_(windowsRegistryTable , @symbol(REG_MULTI_SZ), __MKUINT(sizeInBytes));          
+            break;             
+            }       
+        default:
+            console_printf("[warning]: Unknown RegistryEntry valueType: %d\n", valueType);
+            break;
+        }
+    } else {
+        errorNumber = __MKSMALLINT(ret);
+    } 
+    }
+
+%}.
+    errorNumber notNil ifTrue:[
+    (OperatingSystem errorHolderForNumber:errorNumber) reportError.
+    ].
+    ^ windowsRegistryTable
+
+    "
+     |key|
+
+     key := Dictionary new.
+     key := self key:'HKEY_LOCAL_MACHINE\SOFTWARE\eXept\Smalltalk/X'.
+     key valueTypeAndSize:'CurrentVersion'
+    "
 ! !
 
 !Win32OperatingSystem::RegistryEntry methodsFor:'accessing subkeys'!