Ticket #252: libbasic_fix_1_of_1_rev_fb93b820a013_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch

Win32OperatingSystem.st

@@ -16055 +16055 @@
 
     errorNumber notNil ifTrue:[
         errorNumber == 87 ifTrue:[ "/ 87 (0x57) ... ERROR_INVALID_PARAMETER 
-            self primitiveFailed: '32/64bit registry view requested but no RegDeleteKeyExW(). Windows too old?'
+            self primitiveFailed: '32/64bit registry view requested but no RegDeleteKeyExW(). Windows too old? (hint: set flags to nil)'
         ].
             (OperatingSystem errorHolderForNumber:errorNumber) reportError.
         
@@ -16458 +16458 @@
     "
 !
 
-deleteValueNamed:name
+deleteValueNamed:nameString
     "delete a value.
      Return true on success."
 
     |nameUtf16Z errorNumber|
 
-    "/ name must be a string
     "/ adding terminating null into empty string
-    name notNil ifTrue:[
-        nameUtf16Z := name isEmpty ifTrue:[(name, (Character codePoint: 0)) asUnicode16String] "/ needed for defaultValue
-                                  ifFalse:[name asUnicode16StringZ]
+    nameString notNil ifTrue:[
+        nameUtf16Z := nameString isEmpty ifTrue:[(nameString, (Character codePoint: 0)) asUnicode16String] "/ needed for defaultValue
+                                  ifFalse:[nameString asUnicode16StringZ]
     ].
 
 %{
@@ -16822 +16821 @@
     "
 !
 
-valueNamed:name put:data
+valueNamed:nameString put:data
     "store a value; the value type depends upon the stored value:
     ByteArray       -> REG_BINARY
     String          -> REG_SZ
@@ -16830 +16829 @@
     Integer         -> REG_DWORD
     nil             -> REG_NONE
     "
-    "Transcript showCR: 'name:', name.
-    Transcript showCR: 'data:', data."
     
-    ^ self valueNamed:name put:data unexpandedReferences:false
-!
-
-valueNamed:name put:data unexpandedReferences:containsUnexpandedReferences
+    ^ self valueNamed:nameString put:data unexpandedReferences:false
+!
+
+valueNamed:nameString put:data unexpandedReferences:containsUnexpandedReferences
     "store a value; the value type depends upon the stored value:
         ByteArray       -> REG_BINARY
         String          -> REG_SZ OR REG_EXPAND_SZ based on containsUnexpandedReferences
@@ -16855 +16852 @@
 
     |nameUtf16Z dataUtf16Z stringArray errorNumber|
 
-    "/ name must be a string
-    "/ name asUnicodeString and null terminated
-    name notNil ifTrue:[
-        nameUtf16Z := name isEmpty ifTrue:[(name, (Character codePoint: 0)) asUnicode16String] "/ needed for defaultValue:
-                                  ifFalse:[name asUnicode16StringZ]
+    "/ nameString asUnicodeString and null terminated
+    nameString notNil ifTrue:[
+        nameUtf16Z := nameString isEmpty ifTrue:[(nameString, (Character codePoint: 0)) asUnicode16String] "/ needed for defaultValue:
+                                  ifFalse:[nameString asUnicode16StringZ]
     ].
    "/ data asUnicode16String and null terminated
     data notNil ifTrue:[