Opened 7 years ago

Last modified 5 years ago

#154 reopened defect

The embedded debugger on windows should behave the same way as on Linux

Reported by: patrik.svestka@… Owned by:
Priority: major Milestone: 8.0.0
Component: default Keywords:
Cc: Also affects CVS HEAD (eXept version): no

Description

The embedded debugger should:

  • stay on top
  • should not have, if possible, any decorations except close
  • the cursor should change when you hoover over the picture button of the embedded debugger.

Change History (12)

by jan vrany, 7 years ago

Attachment: libview_fix_1_of_2_rev_00b6d158ab89_Issue__154__Set___NET_WM_WINDOW_TYPE__property_according_to_desired__windowStyle_.patch​ added

by jan vrany, 7 years ago

Attachment: libview_fix_2_of_2_rev_53f81628e70c_Issue__154__Make__Cursor_hand__a_cursor_with_hand_shape.patch​ added

by jan vrany, 7 years ago

Attachment: libtool_fix_1_of_1_rev_edb119820fcb_Issue__154__Set_window_style_using___beToolWindow_.patch​ added

comment:1 by jan vrany, 7 years ago

Status: new → testing

Attached patches should:

  • make it a tool window (thinner frame, only close button).
  • restores the hand-cursor on buttons on Windows.

They does not make the mini-testrunner to stay on top. After reading MSDN, it looks that we can make it a top-most window - so it will be above all non-topmost windows, no matter to which application they belong (not great). Or leave it as it is.

Under GNOME shell, the tool window is above all non-tool windows *of the same program* - which is IMO the best - but this seems to be impossible on Windows.

Shall we make it a top-most Window?

comment:2 by patrik.svestka@…, 7 years ago

I'll be testing the patches soon. Just wanted to answer your question. Yes you are right, the only option is, not that great, have it top-most window from all windows.

I think that is still reasonable because when you are working with the embedded debug window you usually work with StX so that is fine, if you do not want that window you can still work just with StX integrated debugger only.

Version 0, edited 7 years ago by patrik.svestka@… (next)

comment:3 by patrik.svestka@…, 7 years ago

I do confirm that these patches work as desired.

Both functionality is done and works correctly:

  • make it a tool window (thinner frame, only close button).
  • restores the hand-cursor on buttons on Windows.

When a top-most window patch will be available I'll test it too and close the ticket afterwards.

comment:4 by jan vrany, 7 years ago

OK, I just pushed for integration:

The fix to making it topmost is still pending....

by jan vrany, 6 years ago

Attachment: libview_fix_1_of_1_rev_b99e94212cb5_Issue__154__set_window_as_top_most_if_windows____windowStyle__is___toolWindow1_.patch​ added

comment:5 by jan vrany, 6 years ago

Milestone: → 8.0.0

Uff, after so long I finally wrote the last missing but, see the last patch​. Please have a look.

Note that all previous patches from this ticket are already integrated, no need to apply them if you hav up-to-date libview/libtool.

comment:6 by patrik.svestka@…, 6 years ago

This works perfectly now. I'm closing this issue as it is now complete.

comment:7 by patrik.svestka@…, 6 years ago

Resolution: → fixed
Status: testing → closed

comment:8 by patrik.svestka@…, 5 years ago

Resolution: fixed
Status: closed → reopened

A regression happened with the top most functionality. The Mini test Runner does not stay above all windows atat Windows 10 1703 (OS build 15063.1387).

Note: See TracTickets for help on using tickets.