Opened 5 years ago
Last modified 5 years ago
#252 testing defect
Smalltak/X is writing Windows Registry only in ASCII but registry is UTF16
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | default | Keywords: | |
| Cc: | Also affects CVS HEAD (eXept version): | no |
Description
I have found out that the method:
Win32OperatingSystem::RegistryEntry >> valueNamed:aValueName put:datum
Writes only in ASCII there isn't a code that would indicate such an attempt was made.
Attachments (9)
Change History (16)
comment:1 by , 5 years ago
by , 5 years ago
| Attachment: | libbasic_fix_1_of_1_rev_fb93b820a013_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch added |
|---|
Patches for UTF16 write, delete, create
by , 5 years ago
| Attachment: | regression_fix_1_of_1_rev_ed5a1c3dae40_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch added |
|---|
Tests for writing, deleting, creating
comment:2 by , 5 years ago
| Status: | new → testing |
|---|
comment:3 by , 5 years ago
I have thought of a new method valueTypeAndSize: which would further improve the registry testing. I have also created some tests that are using the new functionality.
Find below patches for the new method and the tests (the above patches must be applied).
by , 5 years ago
| Attachment: | libbasic_fix_1_of_1_rev_6dfa3e4e2c32_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch added |
|---|
the new method valueTypeAndSize: for better testing
by , 5 years ago
| Attachment: | regression_fix_1_of_1_rev_7af27ec86ca8_Addded_test_using_new_method_valueTypeAndSize_.patch added |
|---|
new tests using the new method valueTypeAndSize: for testing
comment:4 by , 5 years ago
Jan, could you please integrate these patches - registry_patches_01.7z? They start right after 21636:1c6f89bd0de6
comment:5 by , 5 years ago
Last fix patch for the registry. Please import it after the #250's https://swing.fit.cvut.cz/projects/stx-jv/attachment/ticket/250/libbasic_fix_1_of_1_rev_ecd8104acb9a_Issue__250_User_input_checks___raise_an_error_when_the_method_parameter_does_not_fit_the_requirements.patch.
by , 5 years ago
comment:6 by , 5 years ago
by , 5 years ago
| Attachment: | regression_registry_tests.7z added |
|---|
Testing windows registry - Reading, Writing, Creating, Opeing, Deleting, Enumeration, etc.
comment:7 by , 5 years ago
I' ve fixed issues with REG_QwORD registry type on x86. I have also taken in account a REG_MULTI_SZ size limitations.
Please try out these patches - for libbasic and for regiresion (tests).
by , 5 years ago
| Attachment: | libbasic.7z added |
|---|
by , 5 years ago
| Attachment: | goodies_regression.7z added |
|---|
Here are the patches for the unicode write, delete, create.