Faculty of Information Technology
Software Engineering Group

Opened 13 months ago

Last modified 9 months ago

#252 testing defect

Smalltak/X is writing Windows Registry only in ASCII but registry is UTF16

Reported by: Patrik Svestka Owned by:
Priority: major Milestone:
Component: default Keywords:
Cc: Also affects CVS HEAD (eXept version): no

Description

I have found out that the method:

Win32OperatingSystem::RegistryEntry >> valueNamed:aValueName put:datum

Writes only in ASCII there isn't a code that would indicate such an attempt was made.

Attachments (9)

libbasic_fix_1_of_1_rev_fb93b820a013_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch (3.4 KB) - added by Patrik Svestka 12 months ago.
Patches for UTF16 write, delete, create
regression_fix_1_of_1_rev_ed5a1c3dae40_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch (59.2 KB) - added by Patrik Svestka 12 months ago.
Tests for writing, deleting, creating
libbasic_fix_1_of_1_rev_6dfa3e4e2c32_Issue__252__Smalltak_X_is_writing_Windows_Registry_only_in_ASCII_but_registry_is_UTF16.patch (5.2 KB) - added by Patrik Svestka 11 months ago.
the new method valueTypeAndSize: for better testing
regression_fix_1_of_1_rev_7af27ec86ca8_Addded_test_using_new_method_valueTypeAndSize_.patch (20.6 KB) - added by Patrik Svestka 11 months ago.
new tests using the new method valueTypeAndSize: for testing
registry_patches_01.7z (8.0 KB) - added by Patrik Svestka 10 months ago.
Fixing unicode writing into registry
libbasic_fix_1_of_1_rev_14192e6eeae8_Issue__252__User_input_checks___raise_an_error_when_the_method_parameter_does_not_fit_the_requirements.patch (3.3 KB) - added by Patrik Svestka 10 months ago.
regression_registry_tests.7z (13.7 KB) - added by Patrik Svestka 10 months ago.
Testing windows registry - Reading, Writing, Creating, Opeing, Deleting, Enumeration, etc.
libbasic.7z (9.3 KB) - added by Patrik Svestka 9 months ago.
goodies_regression.7z (17.3 KB) - added by Patrik Svestka 9 months ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 12 months ago by Patrik Svestka

Here are the patches for the unicode write, delete, create.

comment:2 Changed 12 months ago by Patrik Svestka

Status: newtesting

comment:3 Changed 11 months ago by Patrik Svestka

I have thought of a new method valueTypeAndSize: which would further improve the registry testing. I have also created some tests that are using the new functionality.

Find below patches for the new method and the tests (the above patches must be applied).

Changed 11 months ago by Patrik Svestka

the new method valueTypeAndSize: for better testing

Changed 11 months ago by Patrik Svestka

new tests using the new method valueTypeAndSize: for testing

comment:4 Changed 10 months ago by Patrik Svestka

Jan, could you please integrate these patches - registry_patches_01.7z? They start right after 21636:1c6f89bd0de6

Changed 10 months ago by Patrik Svestka

Attachment: registry_patches_01.7z added

Fixing unicode writing into registry

comment:5 Changed 10 months ago by Patrik Svestka

Last fix patch for the registry. Please import it after the #250's https://swing.fit.cvut.cz/projects/stx-jv/attachment/ticket/250/libbasic_fix_1_of_1_rev_ecd8104acb9a_Issue__250_User_input_checks___raise_an_error_when_the_method_parameter_does_not_fit_the_requirements.patch.

comment:6 Changed 10 months ago by Patrik Svestka

Last but not the least, I'm including tests two patches for tests. These now include 126 tests. These should start right after the 1778:015864816df4 commit. The last patch contains tests for both #250 and #252 as was eaiser for me to export and will be also eaiser for you to import.

Changed 10 months ago by Patrik Svestka

Testing windows registry - Reading, Writing, Creating, Opeing, Deleting, Enumeration, etc.

comment:7 Changed 9 months ago by Patrik Svestka

I' ve fixed issues with REG_QwORD registry type on x86. I have also taken in account a REG_MULTI_SZ size limitations.

Please try out these patches - for libbasic and for regiresion (tests).

Changed 9 months ago by Patrik Svestka

Attachment: libbasic.7z added

Changed 9 months ago by Patrik Svestka

Attachment: goodies_regression.7z added
Note: See TracTickets for help on using tickets.