Faculty of Information Technology
Software Engineering Group

Opened 12 months ago

Closed 9 months ago

#256 closed defect (fixed)

Mercurial commit to named branch (name with spaces) generates debugger window

Reported by: Patrik Svestka Owned by:
Priority: major Milestone:
Component: default Keywords:
Cc: Also affects CVS HEAD (eXept version): no

Description

I have a named branch called MenuItem BufferedValueHolder. There appears to be an issue with the space as the debugger window message is: [HGNoSuchBranchError]: No such branch: MenuItem.

The commit continues after pressing abort button and is successful.

Here is a screenshot of the situation:

the debugger window with the error message

Attachments (4)

no_such_brach_error_debugger_window.png (260.9 KB) - added by Patrik Svestka 12 months ago.
the debugger window with the error message
libscm_fix_1_of_1_rev_6839f138ff17_Issue_256__fix_parsing_branch_name_from_changelog.patch (2.9 KB) - added by Jan Vrany 11 months ago.
HGTests-test_branches_issue256b.st (1.2 KB) - added by Patrik Svestka 10 months ago.
Fileout for the test
libscm_fix_1_of_1_rev_9bb1db01b5e9_Issue_256__fix_parsing_branch_list_when_branch_name_s__contains_spaces.patch (8.7 KB) - added by Jan Vrany 9 months ago.

Download all attachments as: .zip

Change History (11)

Changed 12 months ago by Patrik Svestka

the debugger window with the error message

comment:1 Changed 11 months ago by Jan Vrany

Status: newtesting

Attached commit 6839f138ff17 should fix it.

comment:2 Changed 11 months ago by Jan Vrany

Resolution: fixed
Status: testingclosed

comment:3 Changed 10 months ago by Patrik Svestka

Resolution: fixed
Status: closedreopened

comment:4 Changed 10 months ago by Patrik Svestka

There appears to be still an issue when changing back to 'default' branch and having branch name with spaces.

Changed 10 months ago by Patrik Svestka

Fileout for the test

comment:5 Changed 9 months ago by Jan Vrany

COmmit 9bb1db01b5e9 should fix it, but it needs more testing on older Mercurial releases.

comment:6 Changed 9 months ago by Patrik Svestka

The patch works on mercurial 4.7.2 a latest Smalltalk/X. Thank you Jan!

comment:7 Changed 9 months ago by Jan Vrany

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.