Opened 5 years ago

Closed 5 years ago

#256 closed defect (fixed)

Mercurial commit to named branch (name with spaces) generates debugger window

Reported by: patrik.svestka@… Owned by:
Priority: major Milestone:
Component: default Keywords:
Cc: Also affects CVS HEAD (eXept version): no

Description

I have a named branch called MenuItem BufferedValueHolder. There appears to be an issue with the space as the debugger window message is: [HGNoSuchBranchError]: No such branch: MenuItem.

The commit continues after pressing abort button and is successful.

Here is a screenshot of the situation:

the debugger window with the error message

Attachments (4)

no_such_brach_error_debugger_window.png​ (260.9 KB ) - added by patrik.svestka@… 5 years ago.
the debugger window with the error message
libscm_fix_1_of_1_rev_6839f138ff17_Issue_256__fix_parsing_branch_name_from_changelog.patch​ (2.9 KB ) - added by jan vrany 5 years ago.
HGTests-test_branches_issue256b.st​ (1.2 KB ) - added by patrik.svestka@… 5 years ago.
Fileout for the test
libscm_fix_1_of_1_rev_9bb1db01b5e9_Issue_256__fix_parsing_branch_list_when_branch_name_s__contains_spaces.patch​ (8.7 KB ) - added by jan vrany 5 years ago.

Download all attachments as: .zip

Change History (11)

by patrik.svestka@…, 5 years ago

Attachment: no_such_brach_error_debugger_window.png​ added

the debugger window with the error message

by jan vrany, 5 years ago

Attachment: libscm_fix_1_of_1_rev_6839f138ff17_Issue_256__fix_parsing_branch_name_from_changelog.patch​ added

comment:1 by jan vrany, 5 years ago

Status: new → testing

Attached commit 6839f138ff17​ should fix it.

comment:2 by jan vrany, 5 years ago

Resolution: → fixed
Status: testing → closed

Fixed in 8a885a75daa9/stx.libscm.

comment:3 by patrik.svestka@…, 5 years ago

Resolution: fixed
Status: closed → reopened

comment:4 by patrik.svestka@…, 5 years ago

There appears to be still an issue when changing back to 'default' branch and having branch name with spaces.

by patrik.svestka@…, 5 years ago

Attachment: HGTests-test_branches_issue256b.st​ added

Fileout for the test

by jan vrany, 5 years ago

Attachment: libscm_fix_1_of_1_rev_9bb1db01b5e9_Issue_256__fix_parsing_branch_list_when_branch_name_s__contains_spaces.patch​ added

comment:5 by jan vrany, 5 years ago

COmmit 9bb1db01b5e9​ should fix it, but it needs more testing on older Mercurial releases.

comment:6 by patrik.svestka@…, 5 years ago

The patch works on mercurial 4.7.2 a latest Smalltalk/X. Thank you Jan!

comment:7 by jan vrany, 5 years ago

Resolution: → fixed
Status: reopened → closed

Fixed in 7527dc6bc38e2/stx.libscm

Note: See TracTickets for help on using tickets.