Opened 7 years ago
Closed 5 years ago
#80 closed defect (fixed)
Language setting is not preserved
Reported by: | Jan Vrany | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | default | Keywords: | |
Cc: | Also affects CVS HEAD (eXept version): | yes |
Description
...even when set in user preferences. Steps to reproduce:
- Start fresh St/X (
-I
option) - Pick menu to System"" -> Settings..., then go to Language settings and change it
- Save settings
- Start fresh St/X again
It should come up and use the language set in step 2.
Change History (5)
comment:1 follow-up: 2 Changed 6 years ago by
comment:2 Changed 5 years ago by
Replying to Patrik Svestka:
This looks like it works now, if you uncheck the checkbox
Use OS Language on Startup
and save the settings. Could you confirm it too?
Yes, that worked too. The problem was that this was not so obvious :-)
comment:3 Changed 5 years ago by
Status: | new → testing |
---|
While it actually worked, the UI was hard to understand (hence this report and other reports off this tracker). To address this, the settings UI has been cleaned up to make it simpler.
Moreover, the default settings have been changed to ignore system locale an use Ennlish (US). In
my observation, most programmers prefer English and besides, translations to other languages are
so incomplete so that the UX is far from good.
As a side effect, language/locale initialization has been cleaned up so that there's no longer a global variable holding the language / region - code should always consult preferences.
In particular, this issue has been addressed by:
- 817fd8c6e4c5/stx.libbasic - Issue #80: added
AbstractOperatingSystem class >> #getLanguage
and#getLanguageTerritory
- 5d343af8922a/stx.libbasic - Issue #80: keep language settings in
UserPreferences
- 9c9fa5a584bb/stx.libbasic - Issue #80: remove initialization of
Language
andLanguageTerritory
globals. - 6d994e1ee4fc/stx.libview - Issue #80: fixed resource file parsing to not access
Language
norLanguageTerritory
directly - f778bfccd561/stx.goodies.refactoryBrowser - Issue #80: catch up with changes in
stx:libbasic
- 4d8f7dd66c19/stx.libtool - Issue #80: language settins cleaned up and simplified
Note that the above fixes are in 8.0.0 branch only and won't be back-ported to 6.x.x (8.0.0 will be released soon(tm), I hope)
comment:4 Changed 5 years ago by
I have tested these languages: CZ, EN(US), DE, RU, SK. The resources are incomplete for the other languages than English, but that calls for volunteers. There are more urgent matters to attend.
Good job!
comment:5 Changed 5 years ago by
Resolution: | → fixed |
---|---|
Status: | testing → closed |
This looks like it works now, if you uncheck the checkbox
Use OS Language on Startup
and save the settings. Could you confirm it too?