Mercurial Mercurial > hg > jv-calipel / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Better error messages for bad/missing parameters
authorJan Vrany <jan.vrany@fit.cvut.cz>
Wed, 24 Sep 2014 20:17:55 +0100
changeset 216 be26cc6e8795
parent 215 e77c83f18c83
child 217 5116ead182a8
Better error messages for bad/missing parameters
s/BenchmarkExecutor.st file | annotate | diff | comparison | revisions 
--- a/s/BenchmarkExecutor.st	Wed Sep 24 20:13:18 2014 +0100
+++ b/s/BenchmarkExecutor.st	Wed Sep 24 20:17:55 2014 +0100
@@ -93,11 +93,11 @@
                     s := each readStream.
                     v := parameter type readFrom: s onError:[
                         "JV: Note for Smalltalk/X: #signal: is actually an ANSI 1.9 protocol!!"
-                        BenchmarkParameterError new signal: 'Cannot read parameter value for ' , parameter name , ' (parse error)'
+                        BenchmarkParameterError new signal: 'Cannot read parameter value for ''' , parameter name , ''' (parse error)'
                     ].
                     s atEnd ifFalse:[
                         "JV: Note for Smalltalk/X: #signal: is actually an ANSI 1.9 protocol!!"
-                        BenchmarkParameterError new signal: 'Cannot read parameter value for ' , parameter name , ' (parse error)'
+                        BenchmarkParameterError new signal: 'Cannot read parameter value for ''' , parameter name , ''' (parse error)'
                     ].
                     v.                
                 ].
@@ -107,7 +107,7 @@
             parameter default == BenchmarkParameter undefinedValue ifTrue:[
                 values := parameter values.
                 values isNil ifTrue:[ 
-                    BenchmarkParameterError new signal: 'Parameter value not defined and default value(s) not specified for' , parameter name.
+                    BenchmarkParameterError new signal: 'Parameter value not defined and default value(s) not specified for ''' , parameter name , ''''
                 ].
             ] ifFalse:[ 
                 values := Array with: parameter default.    
@@ -134,7 +134,7 @@
     combinator value: #().
 
     "Created: / 12-08-2013 / 00:11:17 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 10-03-2014 / 10:23:14 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 24-09-2014 / 20:17:02 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 spy: aBenchmarkInstance result: aBenchmarkResult defines: aDictionary
@@ -171,11 +171,11 @@
                     s := each readStream.
                     v := parameter type readFrom: s onError:[
                         "JV: Note for Smalltalk/X: #signal: is actually an ANSI 1.9 protocol!!"
-                        BenchmarkParameterError new signal: 'Cannot read parameter value for ' , parameter name , ' (parse error)'
+                        BenchmarkParameterError new signal: 'Cannot read parameter value for ''' , parameter name , ''' (parse error)'
                     ].
                     s atEnd ifFalse:[
                         "JV: Note for Smalltalk/X: #signal: is actually an ANSI 1.9 protocol!!"
-                        BenchmarkParameterError new signal: 'Cannot read parameter value for ' , parameter name , ' (parse error)'
+                        BenchmarkParameterError new signal: 'Cannot read parameter value for ''' , parameter name , ''' (parse error)'
                     ].
                     v.                
                 ].
@@ -183,12 +183,12 @@
 
         ] ifFalse:[
             parameter default == BenchmarkParameter undefinedValue ifTrue:[
-                BenchmarkParameterError new signal: 'Parameter value for ' , parameter name , ' not specified and parameter has no default value'.
+                BenchmarkParameterError new signal: 'Parameter value for ''' , parameter name , ''' not specified and parameter has no default value'.
             ].
             values := Array with: parameter default.    
         ].
         values size > 1 ifTrue:[ 
-            BenchmarkParameterError new signal: 'Multiple parameter values for param ', parameter name , '. No parameter combinating allowed when running under profiler!!'.
+            BenchmarkParameterError new signal: 'Multiple parameter values for param ''', parameter name , '''. No parameter combinating allowed when running under profiler!!'.
         ].
         parameter -> values
     ].
@@ -211,6 +211,7 @@
     combinator value: #().
 
     "Created: / 21-05-2014 / 10:44:42 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 24-09-2014 / 20:17:22 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 ! !
 
 !BenchmarkExecutor methodsFor:'executing-private'!
hg/jv-calipel