gui/PPRemoveProdcutionRefactoring.st
author Jan Vrany <jan.vrany@fit.cvut.cz>
Tue, 16 Jun 2015 06:45:26 +0100
changeset 489 0ca7a70db0f5
parent 363 ee34d5fd575a
permissions -rw-r--r--
Fix in codegen for inlined sequence nodes. For inlined sequence nodes, generate nested ifs rather than sequential code which does not work when inlined. The reason is that #codeReturn: in inline generates instvar assignment, not method return, so in sequential code the next child of a sequence will be probed even if previous failed. If that happends, the whole sequence fail and therefore we must generate nested ifs to correctly handle this w.r.t. inlining.

"{ Package: 'stx:goodies/petitparser/gui' }"

Refactoring subclass:#PPRemoveProdcutionRefactoring
	instanceVariableNames:'production class'
	classVariableNames:''
	poolDictionaries:''
	category:'PetitGui-Refactoring'
!


!PPRemoveProdcutionRefactoring class methodsFor:'instance creation'!

onClass: aClass production: aSelector
	^ self new
		setClass: aClass;
		setProduction: aSelector;
		yourself
! !

!PPRemoveProdcutionRefactoring methodsFor:'initialization'!

setClass: aClass
	class := self classObjectFor: aClass
!

setProduction: aSymbol
	production := aSymbol
! !

!PPRemoveProdcutionRefactoring methodsFor:'preconditions'!

preconditions
	^ (self checkCompositeParser: class)
		& (RBCondition definesSelector: production asSymbol in: class)
		& (RBCondition definesInstanceVariable: production asString in: class)
! !

!PPRemoveProdcutionRefactoring methodsFor:'transforming'!

transform
	class removeMethod: production asSymbol.
	class removeInstanceVariable: production asString
! !

!PPRemoveProdcutionRefactoring class methodsFor:'documentation'!

version
    ^ '$Header: /cvs/stx/stx/goodies/petitparser/gui/PPRemoveProdcutionRefactoring.st,v 1.2 2014-03-04 23:33:59 cg Exp $'
!

version_CVS
    ^ '$Header: /cvs/stx/stx/goodies/petitparser/gui/PPRemoveProdcutionRefactoring.st,v 1.2 2014-03-04 23:33:59 cg Exp $'
! !