RegressionTests__SoundexStringComparatorTest.st
changeset 1673 a04b31df1251
parent 1665 59ac4845bc07
child 2153 3bcad3f6dd0b
--- a/RegressionTests__SoundexStringComparatorTest.st	Wed Aug 02 14:12:21 2017 +0200
+++ b/RegressionTests__SoundexStringComparatorTest.st	Thu Aug 03 15:04:24 2017 +0200
@@ -53,7 +53,7 @@
 !
 
 test02_WellKnownResults
-    "tests regular soundex"
+    "tests some wellknown soundex codes"
 
     |code soundex xx|
 
@@ -102,40 +102,18 @@
     self assert:( code = 'Pfister' asSoundexCode).
     self assert:( code = 'P236' ).
 
-    self assert: ( soundex value:( 'A' )) = 'A000' .
-    self assert: ( soundex value:( 'B' )) = 'B000' .
-    self assert: ( soundex value:( 'C' )) = 'C000' .
-    self assert: ( soundex value:( 'D' )) = 'D000' .
-    self assert: ( soundex value:( 'E' )) = 'E000' .
-    self assert: ( soundex value:( 'F' )) = 'F000' .
-    self assert: ( soundex value:( 'G' )) = 'G000' .
-    self assert: ( soundex value:( 'H' )) = 'H000' .
-    self assert: ( soundex value:( 'I' )) = 'I000' .
-    self assert: ( soundex value:( 'J' )) = 'J000' .
-    self assert: ( soundex value:( 'K' )) = 'K000' .
-    self assert: ( soundex value:( 'L' )) = 'L000' .
-    self assert: ( soundex value:( 'M' )) = 'M000' .
-    self assert: ( soundex value:( 'N' )) = 'N000' .
-    self assert: ( soundex value:( 'O' )) = 'O000' .
-    self assert: ( soundex value:( 'P' )) = 'P000' .
-    self assert: ( soundex value:( 'Q' )) = 'Q000' .
-    self assert: ( soundex value:( 'R' )) = 'R000' .
-    self assert: ( soundex value:( 'S' )) = 'S000' .
-    self assert: ( soundex value:( 'T' )) = 'T000' .
-    self assert: ( soundex value:( 'U' )) = 'U000' .
-    self assert: ( soundex value:( 'V' )) = 'V000' .
-    self assert: ( soundex value:( 'W' )) = 'W000' .
-    self assert: ( soundex value:( 'X' )) = 'X000' .
-    self assert: ( soundex value:( 'Y' )) = 'Y000' .
-    self assert: ( soundex value:( 'Z' )) = 'Z000' .
+    "/ self assert: ( soundex value:( 'A' )) = 'A000' .
+    "/ ...
+    "/ self assert: ( soundex value:( 'Z' )) = 'Z000' .
+    $A to:$Z do:[:singleChar |
+        self assert: ( soundex value:( singleChar asString )) = (singleChar asString,'000') .
+    ].    
 
     self assert: ( soundex value:( 'AEHIOW' )) = 'A000' .
     self assert: ( soundex value:( 'BPFV' )) = 'B000' .
     self assert: ( soundex value:( 'CGJKQSXZ' )) = 'C000' .
     self assert: ( soundex value:( 'DT' )) = 'D000' .
-    self assert: ( soundex value:( 'L' )) = 'L000' .
     self assert: ( soundex value:( 'MN' )) = 'M000' .
-    self assert: ( soundex value:( 'R' )) = 'R000' .
 
     self assert: ( soundex value:( 'ADAD' )) = 'A330' .
     self assert: ( soundex value:( 'ADHD' )) = 'A330' .  "/ DIFFERENT from miracode (american) soundex
@@ -192,24 +170,26 @@
     self assert: ( soundex value:( 'Rupert' )) = 'R163' .
     self assert: ( soundex value:( 'Rubin' )) = 'R150' .
 
-    "/ must check - my values are different
-"/    #('Fusedale') 
-"/        do:[:each | self assert: ( soundex value:each) = 'F234'].
-"/
-"/    #('Genthner' 'Gentner' 'Gianettini' 'Gunton') 
-"/        do:[:each | self assert: ( soundex value:each) = 'G535'].
-"/
-"/    #('Garlee' 'Garley' 'Garwell' 'Garwill' 'Gerrell' 'Gerrill' 'Giral' 'Gorelli' 'Gorioli' 'Gourlay' 'Gourley' 'Gourlie' 'Graal' 'Grahl' 'Grayley' 'Grealey' 'Greally' 'Grealy' 'Grioli' 'Groll' 'Grolle' 'Guerola' 'Gurley') 
-"/        do:[:each | self assert: ( soundex value:each) = 'G640'].
-"/
-"/    #('Hadcroft' 'Hadgraft' 'Hatchard' 'Hatcher' 'Hatzar' 'Hedger' 'Hitscher' 'Hodcroft' 'Hutchcraft') 
-"/        do:[:each | xx := each. self assert: ( soundex value:each) = 'H326'].
-"/
-"/    #('Parade' 'Pardew' 'Pardey' 'Pardi' 'Pardie' 'Pardoe' 'Pardue' 'Pardy' 'Parradye' 'Parratt' 'Parrett' 'Parrot' 'Parrott' 'Pearde' 'Peart' 'Peaurt' 'Peert' 'Perdue' 'Peret' 'Perett' 'Perot' 'Perott' 'Perotti' 'Perrat' 'Perrett' 'Perritt' 'Perrot' 'Perrott' 'Pert' 'Perutto' 'Pirdue' 'Pirdy' 'Pirot' 'Pirouet' 'Pirt' 'Porrett' 'Porritt' 'Port' 'Porte' 'Portt' 'Prate' 'Prati' 'Pratt' 'Pratte' 'Pratty' 'Preddy' 'Preedy' 'Preto' 'Pretti' 'Pretty' 'Prewett' 'Priddey' 'Priddie' 'Priddy' 'Pride' 'Pridie' 'Pritty' 'Prott' 'Proud' 'Prout' 'Pryde' 'Prydie' 'Purdey' 'Purdie' 'Purdy') 
-"/        do:[:each | xx := each. self assert: ( soundex value:each) = 'P630'].
+    #('Fusedale') 
+        do:[:each | self assert: ( soundex value:each) = 'F234'].
+
+    #('Genthner' 'Gentner' 'Gianettini' 'Gunton') 
+        do:[:each | self assert: ( code := soundex value:each) = 'G535'].
+
+    #('Garlee' 'Garley' 'Garwell' 'Garwill' 'Gerrell' 'Gerrill' 'Giral' 'Gorelli' 'Gorioli' 'Gourlay' 'Gourley' 'Gourlie' 'Graal' 'Grahl' 'Grayley' 'Grealey' 'Greally' 'Grealy' 'Grioli' 'Groll' 'Grolle' 'Guerola' 'Gurley') 
+        do:[:each | self assert: ( code := soundex value:each) = 'G640'].
+
+    #('Hadcroft' 'Hadgraft' 'Hatchard' 'Hatcher' 'Hatzar' 'Hedger' 'Hitscher' 'Hodcroft') 
+        do:[:each | xx := each. self assert: ( code := soundex value:each) = 'H326'].
+
+    #('Hutchcraft') 
+        do:[:each | xx := each. self assert: ( code := soundex value:each) = 'H322'].
+
+    #('Parade' 'Pardew' 'Pardey' 'Pardi' 'Pardie' 'Pardoe' 'Pardue' 'Pardy' 'Parradye' 'Parratt' 'Parrett' 'Parrot' 'Parrott' 'Pearde' 'Peart' 'Peaurt' 'Peert' 'Perdue' 'Peret' 'Perett' 'Perot' 'Perott' 'Perotti' 'Perrat' 'Perrett' 'Perritt' 'Perrot' 'Perrott' 'Pert' 'Perutto' 'Pirdue' 'Pirdy' 'Pirot' 'Pirouet' 'Pirt' 'Porrett' 'Porritt' 'Port' 'Porte' 'Portt' 'Prate' 'Prati' 'Pratt' 'Pratte' 'Pratty' 'Preddy' 'Preedy' 'Preto' 'Pretti' 'Pretty' 'Prewett' 'Priddey' 'Priddie' 'Priddy' 'Pride' 'Pridie' 'Pritty' 'Prott' 'Proud' 'Prout' 'Pryde' 'Prydie' 'Purdey' 'Purdie' 'Purdy') 
+        do:[:each | xx := each. self assert: ( code := soundex value:each) = 'P630'].
 
     "Created: / 27-07-2017 / 15:14:59 / cg"
-    "Modified: / 28-07-2017 / 20:45:20 / cg"
+    "Modified: / 03-08-2017 / 15:04:05 / cg"
 ! !
 
 !SoundexStringComparatorTest class methodsFor:'documentation'!