SmallSense__SmalltalkLintService.st
author Jan Vrany <jan.vrany@fit.cvut.cz>
Wed, 25 Oct 2017 23:42:41 +0100
changeset 1058 6d4bf422a7dd
parent 975 589eb0269c9f
child 1072 a44c741ee5ef
permissions -rw-r--r--
Fix subscript out of bounds error in Smalltalk inderences ...caused by missing size-check when analysing typed prefix.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     1
"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     2
 COPYRIGHT (c) 2006 by eXept Software AG
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     3
	      All Rights Reserved
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     4
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     5
 This software is furnished under a license and may be used
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     6
 only in accordance with the terms of that license and with the
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     7
 inclusion of the above copyright notice.   This software may not
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     8
 be provided or otherwise made available to, or used by, any
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
     9
 other person.  No title to or ownership of the software is
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    10
 hereby transferred.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    11
"
249
8bc64027b189 Package renamed to stx:goodies/smallsense
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 174
diff changeset
    12
"{ Package: 'stx:goodies/smallsense' }"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    13
64
2257d7223898 All classes moved to namespace SmallSense.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 60
diff changeset
    14
"{ NameSpace: SmallSense }"
2257d7223898 All classes moved to namespace SmallSense.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 60
diff changeset
    15
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
    16
Tools::BackgroundSourceProcessingService subclass:#SmalltalkLintService
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
    17
	instanceVariableNames:'rulesHolder rules highlighter support annotations
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
    18
		annotationsSequenceNumber annotationsPerLine'
16
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    19
	classVariableNames:'Debugging'
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    20
	poolDictionaries:''
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
    21
	category:'SmallSense-Smalltalk-Lint'
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    22
!
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    23
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
    24
!SmalltalkLintService class methodsFor:'documentation'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    25
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    26
copyright
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    27
"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    28
 COPYRIGHT (c) 2006 by eXept Software AG
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    29
	      All Rights Reserved
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    30
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    31
 This software is furnished under a license and may be used
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    32
 only in accordance with the terms of that license and with the
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    33
 inclusion of the above copyright notice.   This software may not
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    34
 be provided or otherwise made available to, or used by, any
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    35
 other person.  No title to or ownership of the software is
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    36
 hereby transferred.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    37
"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    38
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    39
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
    40
!SmalltalkLintService class methodsFor:'accessing'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    41
17
8443d79a77ac Improvements in background lint checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 16
diff changeset
    42
debugging
8443d79a77ac Improvements in background lint checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 16
diff changeset
    43
    ^Debugging == true
8443d79a77ac Improvements in background lint checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 16
diff changeset
    44
8443d79a77ac Improvements in background lint checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 16
diff changeset
    45
    "Created: / 17-02-2012 / 00:48:28 / Jan Vrany <jan.vrany@fit.cvut.cz>"
8443d79a77ac Improvements in background lint checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 16
diff changeset
    46
!
8443d79a77ac Improvements in background lint checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 16
diff changeset
    47
16
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    48
debugging: aBoolean
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    49
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    50
    Debugging := aBoolean
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    51
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    52
    "Created: / 16-02-2012 / 16:22:29 / Jan Vrany <jan.vrany@fit.cvut.cz>"
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    53
!
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
    54
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    55
label
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    56
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    57
    "Answers short label - for UI"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    58
42
48307f46ff8e Edit support cut off to a new service. Added SmallSense syntax highlighting service.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 41
diff changeset
    59
    ^'SmallSense - Static Checking'
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    60
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    61
    "Created: / 07-03-2010 / 14:00:01 / Jan Vrany <jan.vrany@fit.cvut.cz>"
42
48307f46ff8e Edit support cut off to a new service. Added SmallSense syntax highlighting service.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 41
diff changeset
    62
    "Modified: / 27-07-2013 / 22:36:48 / Jan Vrany <jan.vrany@fit.cvut.cz>"
7
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    63
!
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    64
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    65
priority
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    66
    "Answers a priority of the service. Services with higher priority
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    67
     will get the event notification before ones with lower priority.
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    68
     Therefore, a lower-priority service might not get the event if high
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    69
     priority service processes it"
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    70
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    71
    ^ 10
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    72
cad6eb825df1 Added lost changes...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 5
diff changeset
    73
    "Created: / 01-02-2012 / 10:29:06 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    74
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    75
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
    76
!SmalltalkLintService class methodsFor:'queries'!
35
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    77
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    78
isUsefulFor:aCodeView
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    79
    "this filters useful services.
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    80
     must be redefined to return true in subclasses (but each class must do it only
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    81
     for itself - not for subclasses"
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    82
86
3b615594edf6 Fixed Lint service to work on CVS Smalltalk/X...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 76
diff changeset
    83
    ^ self == SmalltalkLintService
35
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    84
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    85
    "Created: / 24-07-2013 / 11:35:59 / Jan Vrany <jan.vrany@fit.cvut.cz>"
86
3b615594edf6 Fixed Lint service to work on CVS Smalltalk/X...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 76
diff changeset
    86
    "Modified: / 17-09-2013 / 15:26:20 / Jan Vrany <jan.vrany@fit.cvut.cz>"
35
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    87
! !
4e7326538420 Added SmallSenseService>>isUsefulFor:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 32
diff changeset
    88
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
    89
!SmalltalkLintService class methodsFor:'testing'!
11
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    90
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    91
isAvailable
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    92
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    93
    ^UserPreferences current smallSenseEnabled
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    94
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    95
    "Created: / 04-02-2012 / 22:20:03 / Jan Vrany <jan.vrany@fit.cvut.cz>"
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    96
! !
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
    97
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
    98
!SmalltalkLintService methodsFor:'accessing'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
    99
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   100
annotationAtLine: lineNo
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   101
    | anns |
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   102
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   103
    (anns := self annotations) notNil ifTrue:[ 
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   104
        ^ annotationsPerLine at: lineNo ifAbsent:[nil].
323
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   105
        ^ anns detect:[:annotation | annotation line = lineNo] ifNone:[ nil ]
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   106
    ].
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   107
    ^ nil
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   108
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   109
    "Created: / 30-01-2012 / 21:06:25 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   110
    "Modified: / 15-12-2014 / 15:40:39 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   111
!
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   112
314
6d1b45736520 Support for drawing annotation markers in codeview scrollbar.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 313
diff changeset
   113
annotations
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   114
    (highlighter notNil and:[ highlighter sequenceNumber ~~ annotationsSequenceNumber ]) ifTrue:[ 
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   115
        | rulesToIntervalsMap annotationsPerLineMap |
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   116
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   117
        rulesToIntervalsMap := highlighter rulesToIntervalsMap.
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   118
        rulesToIntervalsMap notNil ifTrue:[ 
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   119
            annotationsPerLineMap := Dictionary new.
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   120
            rulesToIntervalsMap keysAndValuesDo:[ :rule :intervals |
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   121
                intervals do:[:interval | 
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   122
                    | line annotation r |
314
6d1b45736520 Support for drawing annotation markers in codeview scrollbar.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 313
diff changeset
   123
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   124
                    line := codeView lineOfCharacterPosition: interval first.
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   125
                    annotation := annotationsPerLineMap at: line ifAbsentPut:[ Tools::LintAnnotation new line: line ].
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   126
                    (r := annotation rule) notNil ifTrue:[ 
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   127
                        r isComposite 
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   128
                            ifTrue: [ r addRule:rule "rules add: rule" ]
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   129
                            ifFalse:[ annotation rule: (RBCompositeLintRule rules: (OrderedCollection with: r with: rule))]
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   130
                    ] ifFalse:[ 
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   131
                        annotation rule: rule
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   132
                    ].
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   133
                ].
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   134
            ].
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   135
            annotationsPerLine := annotationsPerLineMap.
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   136
            annotations := annotationsPerLineMap values sort:[ :a :b | a line < b line ].
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   137
            annotationsSequenceNumber := highlighter sequenceNumber.
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   138
        ]
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   139
    ].
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   140
    ^annotations
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   141
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   142
    "Created: / 15-12-2014 / 15:29:37 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   143
    "Modified: / 15-12-2014 / 19:00:05 / Jan Vrany <jan.vrany@fit.cvut.cz>"
314
6d1b45736520 Support for drawing annotation markers in codeview scrollbar.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 313
diff changeset
   144
!
6d1b45736520 Support for drawing annotation markers in codeview scrollbar.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 313
diff changeset
   145
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   146
syntaxHighlighter
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   147
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   148
    ^highlighter
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   149
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   150
    "Created: / 05-08-2011 / 10:59:02 / Jan Vrany <jan.vrany@fit.cvut.cz>"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   151
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   152
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   153
!SmalltalkLintService methodsFor:'aspects'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   154
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   155
rulesHolder
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   156
    "return/create the 'rulesHolder' value holder (automatically generated)"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   157
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   158
    rulesHolder isNil ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   159
        rulesHolder := ValueHolder new.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   160
        rulesHolder addDependent:self.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   161
    ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   162
    ^ rulesHolder
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   163
!
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   164
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   165
rulesHolder:something
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   166
    "set the 'rulesHolder' value holder (automatically generated)"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   167
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   168
    |oldValue newValue|
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   169
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   170
    rulesHolder notNil ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   171
        oldValue := rulesHolder value.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   172
        rulesHolder removeDependent:self.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   173
    ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   174
    rulesHolder := something.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   175
    rulesHolder notNil ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   176
        rulesHolder addDependent:self.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   177
    ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   178
    newValue := rulesHolder value.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   179
    oldValue ~~ newValue ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   180
        self update:#value with:newValue from:rulesHolder.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   181
    ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   182
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   183
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   184
!SmalltalkLintService methodsFor:'change & update'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   185
18
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   186
sourceChanged:force
24
a468dff1d0f7 - SmallSenseService
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 22
diff changeset
   187
    | lang |
a468dff1d0f7 - SmallSenseService
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 22
diff changeset
   188
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   189
    annotations := annotationsPerLine := nil.
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   190
18
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   191
    rules isNil ifTrue:[ ^ self ].
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   192
    rules resetResult.
24
a468dff1d0f7 - SmallSenseService
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 22
diff changeset
   193
    ((lang := codeView language) isNil or:[lang isSmalltalk not]) ifTrue:[ ^ self ].
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   194
18
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   195
    super sourceChanged:force.
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   196
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   197
    "Created: / 18-02-2012 / 22:50:05 / Jan Vrany <jan.vrany@fit.cvut.cz>"
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   198
    "Modified: / 15-12-2014 / 19:00:36 / Jan Vrany <jan.vrany@fit.cvut.cz>"
18
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   199
!
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   200
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   201
update:something with:aParameter from:changedObject
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   202
    "Invoked when an object that I depend upon sends a change notification."
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   203
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   204
    changedObject == rulesHolder ifTrue:[
5
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   205
        UserPreferences current smallSenseBackgroundLintEnabled ifTrue:[
323
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   206
            | rulesHierarchical ruleList disabledRules |
18
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   207
298
c1d8d35e71fd Make sure each service runs checks on its own *copy* of rules
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 295
diff changeset
   208
            "/xxxx
174
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   209
            rulesHierarchical := rulesHolder value.
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   210
            rulesHierarchical notNil ifTrue:[
323
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   211
                disabledRules := SmalltalkChecker forceDisabledRules.
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   212
                ruleList := rulesHierarchical flattened reject:[:each| disabledRules includes: each class name].
298
c1d8d35e71fd Make sure each service runs checks on its own *copy* of rules
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 295
diff changeset
   213
                ruleList := ruleList collect:[ :e | e class new ].
174
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   214
                rules := RBCompositeLintRule rules: ruleList.
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   215
                highlighter rules: ruleList.
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   216
                self process.
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   217
            ].
5
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   218
        ].
39
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   219
        ^ self.
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   220
    ].
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   221
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   222
    super update:something with:aParameter from:changedObject
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   223
298
c1d8d35e71fd Make sure each service runs checks on its own *copy* of rules
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 295
diff changeset
   224
    "Modified (format): / 16-10-2014 / 23:20:18 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   225
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   226
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   227
!SmalltalkLintService methodsFor:'event handling'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   228
44
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   229
buttonPress:button x:x y:y in:view 
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   230
    |lineNr|
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   231
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   232
    rules isNil ifTrue:[
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   233
        ^ false
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   234
    ].
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   235
    view == gutterView ifTrue:[
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   236
        button == 1 ifTrue:[
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   237
            lineNr := textView yVisibleToLineNr:y.
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   238
            lineNr notNil ifTrue:[ 
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   239
                ^ self showInfoWindowForLine: lineNr 
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   240
            ].
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   241
            ^ false.
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   242
        ].
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   243
    ].
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   244
    ^ false
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   245
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   246
    "Created: / 30-01-2012 / 21:04:39 / Jan Vrany <jan.vrany@fit.cvut.cz>"
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   247
!
efc9d79a287f Bugfix in SmallSenseService - added accidenticaly removed method.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 42
diff changeset
   248
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   249
viewRealized
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   250
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   251
    | browser |
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   252
11
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
   253
    UserPreferences current smallSenseBackgroundLintEnabled ifFalse:[ ^ self ].
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
   254
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   255
    (browser := codeView browser) notNil ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   256
        browser navigationState canvasType ~~ #smallLintByRuleResultBrowserSpec ifTrue:[
87
36026147c428 Another fix for CVS's version of Tools::NewSystemBrowser.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 86
diff changeset
   257
            self rulesHolder: (browser perform:#smalllintRulesOrDefaultHolder ifNotUnderstood:[browser smalllintRulesOrAllHolder])
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   258
        ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   259
    ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   260
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   261
    "Created: / 23-01-2012 / 10:43:11 / Jan Vrany <jan.vrany@fit.cvut.cz>"
30
d501a5c4ad42 Added smalllintRulesOrDefaut which accesses user-defined rule sets.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 29
diff changeset
   262
    "Modified: / 28-02-2013 / 22:43:24 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   263
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   264
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   265
!SmalltalkLintService methodsFor:'initialization'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   266
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   267
initialize
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   268
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   269
    super initialize.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   270
311
368ff7243ade Cleanup in SmalltalkLintService
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 301
diff changeset
   271
    highlighter := Tools::LintHighlighter new.
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   272
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   273
    "Created: / 05-08-2011 / 11:53:05 / Jan Vrany <jan.vrany@fit.cvut.cz>"
311
368ff7243ade Cleanup in SmalltalkLintService
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 301
diff changeset
   274
    "Modified (comment): / 03-12-2014 / 09:38:01 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   275
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   276
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   277
!SmalltalkLintService methodsFor:'private'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   278
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   279
process
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   280
    "(Re)starts the processing job. Should be called whenever a source 
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   281
     must be (re)processed."
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   282
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   283
    rules isNil ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   284
        ^self
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   285
    ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   286
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   287
    ^super process.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   288
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   289
    "Created: / 24-01-2012 / 12:43:55 / Jan Vrany <jan.vrany@fit.cvut.cz>"
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   290
!
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   291
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   292
process: delayed
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   293
    "Do the real source processing. If delayed is true, actuall data update must
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   294
     be done within the event queue using #pushUserEvent:...
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   295
    "
174
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   296
    |lang cls env oldCodeList oldCode |
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   297
11
17938f618c57 Added settings application
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 10
diff changeset
   298
    rules isNil ifTrue:[ ^ self ].
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   299
39
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   300
    codeView codeAspect ~~ #method ifTrue:[ ^ self ].
174
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   301
    (lang := codeView language) isNil ifTrue: [ ^ self ].
3e08d765d86f sync from current CVS head; fixed comment highlighting for STXEOLRule
Claus Gittinger
parents: 100
diff changeset
   302
    lang isSmalltalk ifFalse: [ ^ self ]. 
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   303
    done := false.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   304
    modified := false.
39
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   305
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   306
    cls := codeView klass.
39
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   307
        cls isNil ifTrue:[^ self ].    
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   308
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   309
748389119d0a Initial support for per-language edit support.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 35
diff changeset
   310
    Delay waitForMilliseconds: 200."Give user some time to write"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   311
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   312
    (cls notNil and:[cls isObsolete]) ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   313
        cls isMeta ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   314
            cls := (Smalltalk at:cls theNonMetaclass name) class
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   315
        ] ifFalse:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   316
            cls := Smalltalk at:cls name
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   317
        ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   318
    ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   319
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   320
    "textView" modified ifFalse:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   321
        oldCodeList := textView list copy.
18
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   322
        oldCodeList isEmptyOrNil ifTrue: [ ^ self ].
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   323
        "textView" modified ifFalse:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   324
            oldCodeList isNil ifFalse:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   325
                oldCode := oldCodeList asStringWithoutEmphasis.
18
cebd9550b288 branch jv-experiments merged back
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 17
diff changeset
   326
                oldCode isEmptyOrNil ifTrue:[ ^ self ].
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   327
                "textView" modified ifFalse:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   328
                    Screen currentScreenQuerySignal answer:codeView device
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   329
                    do:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   330
                        Error handle:[:ex |
295
ebca485b6bdf Show an error warning in browser info line when an error occur during linting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 290
diff changeset
   331
                            | errMsg |
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   332
16
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
   333
                            Debugging == true ifTrue:[
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
   334
                                Debugging := false.    
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
   335
                                ex pass.
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
   336
                            ].
900fdba78fb2 Lint checking improved
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 11
diff changeset
   337
295
ebca485b6bdf Show an error warning in browser info line when an error occur during linting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 290
diff changeset
   338
"/                            Transcript topView raiseDeiconified.
ebca485b6bdf Show an error warning in browser info line when an error occur during linting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 290
diff changeset
   339
"/                            Transcript showCR:'ParseError: ', ex description.
ebca485b6bdf Show an error warning in browser info line when an error occur during linting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 290
diff changeset
   340
                            errMsg := ex description asStringCollection first asString.
ebca485b6bdf Show an error warning in browser info line when an error occur during linting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 290
diff changeset
   341
                            self showInfo:(('Smalltalk Lint: ',errMsg) colorizeAllWith:Color red).
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   342
                        ] do:[
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   343
                            env := (SmallSense::SmalltalkUnacceptedMethodEnvironment onClass:cls methodSource: oldCode).
892
32176803f831 class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 887
diff changeset
   344
"/ Transcript showCR:rules.
32176803f831 class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 887
diff changeset
   345
"/ Transcript showCR:rules rules.
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   346
                            SmalltalkChecker runRule: rules onEnvironment: env
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   347
                        ].
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   348
                        delayed ifTrue:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   349
                            codeView sensor pushUserEvent:#rehighlight: for:self withArgument: true.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   350
                        ] ifFalse:[
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   351
                            self rehighlight: true.
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   352
                        ]
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   353
                    ]
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   354
                ]
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   355
            ]
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   356
        ]
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   357
    ]
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   358
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   359
    "Created: / 24-01-2012 / 12:44:19 / Jan Vrany <jan.vrany@fit.cvut.cz>"
295
ebca485b6bdf Show an error warning in browser info line when an error occur during linting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 290
diff changeset
   360
    "Modified: / 16-10-2014 / 01:10:39 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   361
!
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   362
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   363
rehighlight: delayed
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   364
    | service |
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   365
100
6d2fb43e661b Initial support for complete-as-you-type.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 87
diff changeset
   366
    service := self service: SmallSense::CodeHighlightingService name.
54
39ea54953e8c Improved support for incremental highlighting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 44
diff changeset
   367
    service isNil ifTrue:[
39ea54953e8c Improved support for incremental highlighting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 44
diff changeset
   368
        service := self service: Tools::CodeHighlightingService name
39ea54953e8c Improved support for incremental highlighting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 44
diff changeset
   369
    ].
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   370
    service notNil ifTrue:[
54
39ea54953e8c Improved support for incremental highlighting.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 44
diff changeset
   371
        service sourceChanged: true.
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   372
    ]
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   373
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   374
    "Created: / 27-01-2012 / 17:06:32 / Jan Vrany <jan.vrany@fit.cvut.cz>"
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   375
    "Modified (format): / 15-12-2014 / 19:00:14 / Jan Vrany <jan.vrany@fit.cvut.cz>"
5
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   376
!
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   377
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   378
showInfoWindowForLine: lineNo
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   379
    | ann |
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   380
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   381
    ann := self annotationAtLine: lineNo.
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   382
    ann isNil ifTrue:[ ^ false ].
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   383
312
ce4e697a363c Few changes in SmallLint Critics Window
Claus Gittinger
parents: 301
diff changeset
   384
    codeView topView beMaster.
ce4e697a363c Few changes in SmallLint Critics Window
Claus Gittinger
parents: 301
diff changeset
   385
64
2257d7223898 All classes moved to namespace SmallSense.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 60
diff changeset
   386
    CriticsWindow new
5
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   387
        rule: ann rule;
17
8443d79a77ac Improvements in background lint checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 16
diff changeset
   388
        codeView: codeView;
5
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   389
        allButOpen;
312
ce4e697a363c Few changes in SmallLint Critics Window
Claus Gittinger
parents: 301
diff changeset
   390
        "/ openWindowAt: (Screen current pointerPosition - (20@20)).
ce4e697a363c Few changes in SmallLint Critics Window
Claus Gittinger
parents: 301
diff changeset
   391
        openWindowAs:#popUp at: (Screen current pointerPosition - (20@20)).
5
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   392
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   393
    ^true
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   394
9b296f3ad0a4 Added code critics (lint) window
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 4
diff changeset
   395
    "Created: / 30-01-2012 / 21:04:39 / Jan Vrany <jan.vrany@fit.cvut.cz>"
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   396
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   397
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   398
!SmalltalkLintService methodsFor:'redrawing'!
4
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   399
975
589eb0269c9f Update SmalltalkLintService to catch up with changes in CodeView2
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 892
diff changeset
   400
drawLine:lineNo in:view atX:x y:yBaseline width:w height:hFont ascent:aFont 
589eb0269c9f Update SmalltalkLintService to catch up with changes in CodeView2
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 892
diff changeset
   401
    from:startCol to:endColOrNil with:fg and:bg
4
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   402
    "Called by both gutterView and textView (well, not yet) to
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   403
     allow services to draw custom things on text view.
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   404
     Ask JV what the args means if unsure (I'm lazy to document
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   405
     them, now it is just an experiment...)"
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   406
975
589eb0269c9f Update SmalltalkLintService to catch up with changes in CodeView2
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 892
diff changeset
   407
    "/ | lang |
312
ce4e697a363c Few changes in SmallLint Critics Window
Claus Gittinger
parents: 301
diff changeset
   408
    "/ ((lang := codeView language) isNil or:[lang isSmalltalk not]) ifTrue:[ ^ self ].
4
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   409
975
589eb0269c9f Update SmalltalkLintService to catch up with changes in CodeView2
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 892
diff changeset
   410
    (UserPreferences current smallSenseBackgroundLintEnabled == true) ifFalse:[ ^ self ].
315
0a4845a0c211 Update to catchup changes in libtool: refactoring to support multiple lint warnings at line
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 314
diff changeset
   411
975
589eb0269c9f Update SmalltalkLintService to catch up with changes in CodeView2
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 892
diff changeset
   412
    self drawAnnotationInLine:lineNo 
589eb0269c9f Update SmalltalkLintService to catch up with changes in CodeView2
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 892
diff changeset
   413
         in:view atX:x y:yBaseline width:w height:hFont ascent:aFont 
589eb0269c9f Update SmalltalkLintService to catch up with changes in CodeView2
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 892
diff changeset
   414
         from:startCol to:endColOrNil with:fg and:bg
4
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   415
! !
783561e02172 Lint support improved - shows an icon in gutter view
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 0
diff changeset
   416
290
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   417
!SmalltalkLintService methodsFor:'registering'!
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   418
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   419
unregister
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   420
    super unregister.
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   421
    rulesHolder removeDependent: self.
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   422
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   423
    "Created: / 14-10-2014 / 22:40:18 / Jan Vrany <jan.vrany@fit.cvut.cz>"
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   424
! !
428b0d4e2725 Fix in SmalltalkLintService: break dependency on rules when unregistering.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 249
diff changeset
   425
67
020b7461b15e Package structure reorganization.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 64
diff changeset
   426
!SmalltalkLintService class methodsFor:'documentation'!
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   427
323
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   428
version
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   429
    ^ '$Header$'
323
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   430
!
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   431
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   432
version_CVS
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   433
    ^ '$Header$'
323
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   434
!
411b58d6c744 initial checkin
Claus Gittinger <cg@exept.de>
parents: 320
diff changeset
   435
29
fe650a6e5704 Moved NavigationState>>selectedClasses to package stx:libtool.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 27
diff changeset
   436
version_HG
fe650a6e5704 Moved NavigationState>>selectedClasses to package stx:libtool.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 27
diff changeset
   437
fe650a6e5704 Moved NavigationState>>selectedClasses to package stx:libtool.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 27
diff changeset
   438
    ^ '$Changeset: <not expanded> $'
fe650a6e5704 Moved NavigationState>>selectedClasses to package stx:libtool.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 27
diff changeset
   439
!
fe650a6e5704 Moved NavigationState>>selectedClasses to package stx:libtool.
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 27
diff changeset
   440
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   441
version_SVN
887
b124a9e4025b class: SmallSense::SmalltalkLintService
Claus Gittinger <cg@exept.de>
parents: 323
diff changeset
   442
    ^ '$Id$'
0
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   443
! !
893cc7b0ed1d copied smallsense from old /branches/jv
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
diff changeset
   444