Few changes in SmallLint Critics Window
* moved HTML generation out of SmallSenseQuickFixer
* made CriticsWindow a dialog instead of popup (hack because of
some buggy window managers)
"
stx:goodies/smallsense - A productivity plugin for Smalltalk/X IDE
Copyright (C) 2013-2014 Jan Vrany
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with this library; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
"
'From Smalltalk/X, Version:6.2.5.0 on 03-12-2014 at 23:46:45' !
"{ Package: 'stx:goodies/smallsense' }"
"{ NameSpace: SmallSense }"
Object subclass:#SmalltalkQuickFixer
instanceVariableNames:'view rule fixes'
classVariableNames:''
poolDictionaries:''
category:'SmallSense-Smalltalk-Lint'
!
Object subclass:#QuickFix
instanceVariableNames:'rule label action'
classVariableNames:''
poolDictionaries:''
privateIn:SmalltalkQuickFixer
!
!SmalltalkQuickFixer class methodsFor:'documentation'!
copyright
"
stx:goodies/smallsense - A productivity plugin for Smalltalk/X IDE
Copyright (C) 2013-2014 Jan Vrany
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with this library; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
"
! !
!SmalltalkQuickFixer class methodsFor:'instance creation'!
for: rule
^self new initializeForRule: rule.
"Created: / 01-02-2012 / 12:06:29 / Jan Vrany <jan.vrany@fit.cvut.cz>"
!
for: rule view: view
^self new initializeForRule: rule view: view
"Created: / 17-02-2012 / 00:21:34 / Jan Vrany <jan.vrany@fit.cvut.cz>"
! !
!SmalltalkQuickFixer methodsFor:'accessing'!
fixes
^ fixes
! !
!SmalltalkQuickFixer methodsFor:'adding'!
fix
"Create and return new quick fix. Caller MUST set its
label and action"
| fix |
fix := QuickFix new.
fix rule: rule.
fixes add: fix.
^fix
"Created: / 01-02-2012 / 10:51:36 / Jan Vrany <jan.vrany@fit.cvut.cz>"
! !
!SmalltalkQuickFixer methodsFor:'initialization'!
initializeForRule: anRBLintRule view: aCodeView2
rule := anRBLintRule.
view := aCodeView2.
fixes := OrderedCollection new: 3.
rule fixes: self.
"Created: / 17-02-2012 / 00:20:36 / Jan Vrany <jan.vrany@fit.cvut.cz>"
! !
!SmalltalkQuickFixer methodsFor:'performing fixes'!
performFix: index
index <= fixes size ifTrue:[
(fixes at: index) performFix.
] ifFalse:[
^ Dialog warn: ('No such fix (%1)' bindWith: index).
]
"Created: / 16-02-2012 / 14:48:38 / Jan Vrany <jan.vrany@fit.cvut.cz>"
! !
!SmalltalkQuickFixer methodsFor:'utilities'!
apply: changes
changes isEmptyOrNil ifTrue: [
^ self
].
(changes size == 1 and: [ changes anElement isMethodCodeChange ]) ifTrue: [
"/ Only one change, modify the code directly in the editor
| oldSource newSource |
oldSource := view contents asString string.
newSource := changes anElement source asString.
oldSource ~= newSource ifTrue: [
| line |
line := view firstLineShown.
view contents: newSource asStringCollection clear: false.
view modified: true.
view isCodeView2 ifTrue: [
view reallyModifiedChannel value: true.
].
view scrollToLine:line.
].
] ifFalse: [
| browser |
browser := view application topApplication.
(browser respondsTo: #performRefactoring:) ifTrue: [
browser performRefactoring: changes.
] ifFalse: [
self breakPoint: #jv.
Dialog warn:'Sorry, this application does not support quick fixes'
]
]
"Created: / 16-02-2012 / 14:46:05 / Jan Vrany <jan.vrany@fit.cvut.cz>"
"Modified: / 16-10-2014 / 03:05:28 / Jan Vrany <jan.vrany@fit.cvut.cz>"
! !
!SmalltalkQuickFixer::QuickFix methodsFor:'accessing'!
action
^ action
!
action:aBlock
action := aBlock.
!
label
^ label
!
label:aString
label := aString.
!
performFix
^action value
"Created: / 16-02-2012 / 14:48:54 / Jan Vrany <jan.vrany@fit.cvut.cz>"
!
rule
^ rule
!
rule:anRBLintRule
rule := anRBLintRule.
! !
!SmalltalkQuickFixer class methodsFor:'documentation'!
version_HG
^ '$Changeset: <not expanded> $'
!
version_SVN
^ '$Id: SmallSense__SmalltalkQuickFixer.st,v 1.2 2014/02/12 14:49:29 sr Exp $'
! !