PerforceSourceCodeManager.st
branchjv
changeset 3838 474d8ec95b33
parent 3329 a4cbc797038b
parent 3658 8b2184d84275
child 3970 6137854c2085
--- a/PerforceSourceCodeManager.st	Tue Feb 04 21:01:56 2014 +0100
+++ b/PerforceSourceCodeManager.st	Wed Apr 01 10:37:40 2015 +0100
@@ -793,12 +793,9 @@
 !
 
 revisionLogOf:clsOrNil 
-fromRevision:firstRev 
-toRevision:lastRef 
-numberOfRevisions:numRevisions 
-fileName:classFileName 
-directory:packageDir 
-module:aPackage
+        fromRevision:firstRev toRevision:lastRef numberOfRevisions:numRevisions 
+        fileName:classFileName directory:packageDir module:aPackage
+
     "return info about the repository container and
      (part of) the revisionlog as a collection of revision entries.
      Return nil on failure.
@@ -1084,11 +1081,6 @@
             forRevision:'6'
             with:'$','Header','$'
 "
-!
-
-versionInfoClass
-
-    ^PerforceVersionInfo
 ! !
 
 !PerforceSourceCodeManager class methodsFor:'queries'!
@@ -1385,6 +1377,11 @@
 
     "Created: / 19-04-2011 / 12:45:13 / cg"
     "Modified: / 20-04-2011 / 12:49:41 / cg"
+!
+
+versionInfoClass
+
+    ^PerforceVersionInfo
 ! !
 
 !PerforceSourceCodeManager class methodsFor:'queries - settings'!
@@ -1794,10 +1791,10 @@
 
 documentation
 "
-    Class used to return a Dictionary when asked for versionInfo.
+    In ancient times, Class used to return a Dictionary when asked for versionInfo.
     This has been replaced by instances of VersionInfo and subclasses.
 
-    Notice, that CVSVersionInfo adds some CVS specific data.
+    PerforceVersionInfo adds some P4 specific data.
 
     [author:]
         cg (cg@AQUA-DUO)
@@ -1807,6 +1804,11 @@
 !PerforceSourceCodeManager::PerforceVersionInfo class methodsFor:'instance creation'!
 
 fromRCSString:aString
+    "cg: I guess this was copy-pasted and then not renamed, as it should.
+     Also the comments are still referring th CVS.
+     As this is a customer-provided method, and I don't know about any
+     consequences, I'll not fix and rename the method"
+
     "{ Pragma: +optSpace }"
 
     "I know how to parse RCS/CVS version id strings.
@@ -1863,7 +1865,7 @@
      Timestamp now printOn:s format:'%h-%m-%s.%i'.
      versionInfo time:s contents.
      PerforceVersionInfo fromRCSString:versionInfo getVersionString.
-     PerforceVersionInfo fromRCSString:'$Header: /cvs/stx/stx/libbasic3/PerforceSourceCodeManager.st,v 1.34 2013-06-13 15:25:01 cg Exp $'
+     PerforceVersionInfo fromRCSString:'$Header: /cvs/stx/stx/libbasic3/PerforceSourceCodeManager.st,v 1.38 2014-11-28 19:05:49 cg Exp $'
     "
 
     "Modified: / 01-06-2012 / 13:32:40 / cg"
@@ -1964,19 +1966,10 @@
 !PerforceSourceCodeManager class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libbasic3/PerforceSourceCodeManager.st,v 1.34 2013-06-13 15:25:01 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libbasic3/PerforceSourceCodeManager.st,v 1.38 2014-11-28 19:05:49 cg Exp $'
 !
 
 version_CVS
-    ^ '$Header: /cvs/stx/stx/libbasic3/PerforceSourceCodeManager.st,v 1.34 2013-06-13 15:25:01 cg Exp $'
-!
-
-version_HG
-
-    ^ '$Changeset: <not expanded> $'
-!
-
-version_SVN
-    ^ 'Id: PerforceSourceCodeManager.st 1981 2012-11-30 17:20:01Z vranyj1 '
+    ^ '$Header: /cvs/stx/stx/libbasic3/PerforceSourceCodeManager.st,v 1.38 2014-11-28 19:05:49 cg Exp $'
 ! !