ProjectChecker.st
changeset 4371 a5d2ba58a4af
parent 4360 6f051df487df
child 4372 d54a65e0fd4e
--- a/ProjectChecker.st	Fri Oct 19 10:10:07 2018 +0200
+++ b/ProjectChecker.st	Fri Oct 19 10:21:07 2018 +0200
@@ -212,8 +212,12 @@
 
     classesInDescriptionChecked := Set new.
     classesInDescription do:[:eachClass |
+        |classesSuperclass|
+
+        classesSuperclass := eachClass superclass.
+
         (classesInDescriptionChecked includes: eachClass) ifTrue:[
-            self addProblem: (ProjectProblem newClassListedMultipleTimes className: eachClass name)
+            self addProblem: (ProjectProblem newClassListedMultipleTimes:eachClass)
         ].
 
         eachClass sharedPoolNames do:[:eachPoolName |
@@ -226,10 +230,7 @@
                 ]
             ].
             pool isNil ifTrue:[
-                self addProblem: 
-                    (ProjectProblem newClassUsesPoolButItDoesNotExist
-                        className: eachClass name;
-                        poolName: eachPoolName).
+                self addProblem:(ProjectProblem newClass:eachClass usesPoolButItDoesNotExist:eachPoolName).
             ] ifFalse:[
                 pool isSharedPool ifFalse:[
                     self addProblem: 
@@ -240,15 +241,12 @@
             ].
         ].
 
-        (eachClass superclass notNil "/Care about classes with nil superclass - Object & Autoload
-          and:[eachClass superclass package == eachClass package]
+        (classesSuperclass notNil "/Care about classes with nil superclass - Object & Autoload
+          and:[classesSuperclass package == eachClass package]
         ) ifTrue:[
-            (classesInDescriptionChecked includes: eachClass superclass) ifFalse:[
+            (classesInDescriptionChecked includes: classesSuperclass) ifFalse:[
                 ((currentPackageDef autoloaded_classNames) includes:eachClass name) ifFalse:[
-                    self addProblem:
-                        (ProjectProblem newClassListedBeforeItsSuperclass
-                            className: eachClass name;
-                            superClassName: eachClass superclass name)
+                    self addProblem:(ProjectProblem newClassListedBeforeItsSuperclass:eachClass)
                 ].
             ].
         ].