#REFACTORING by stefan
authorStefan Vogel <sv@exept.de>
Tue, 03 Jan 2017 14:37:15 +0100
changeset 4182 11078fb7ec8e
parent 4181 7ada81ccac23
child 4183 4963225764b6
#REFACTORING by stefan class: CVSSourceCodeManager changed: #initializeForRepository: #possiblyAddExeptsPrivateRepositoryToModuleRoots use "self class" when refering to own class
CVSSourceCodeManager.st
--- a/CVSSourceCodeManager.st	Thu Dec 29 20:43:55 2016 +0100
+++ b/CVSSourceCodeManager.st	Tue Jan 03 14:37:15 2017 +0100
@@ -1,5 +1,3 @@
-"{ Encoding: utf8 }"
-
 "
  COPYRIGHT (c) 1995 by Claus Gittinger
               All Rights Reserved
@@ -330,7 +328,7 @@
 
     self repositoryName:aDirectoryName.
     AbstractSourceCodeManager initialize.
-    CVSSourceCodeManager initialize.
+    self initialize.
 
     "
      CVSSourceCodeManager initializeForRepository:'/files/CVS'
@@ -346,15 +344,10 @@
     "/ for exept's convenience: if this is a host in our domain,
     "/ add the exept repository.
 
-    |h addr|
-
-    (h := OperatingSystem getHostName) notEmptyOrNil ifTrue:[
-        addr := IPSocketAddress hostName:h.
-        addr notNil ifTrue:[
-            (addr hostAddress startsWith: #[172 23 1]) ifTrue:[
-                self addExeptsPrivateRepositoryToModuleRoots
-            ]
-        ].
+    ((OperatingSystem getDomainName endsWith:'exept.de') or:[
+     OperatingSystem getNetworkAddresses contains:[:eachSocketAddress| eachSocketAddress hostAddress startsWith: #[172 23 1]]]
+    ) ifTrue:[
+        self addExeptsPrivateRepositoryToModuleRoots.
     ].
 ! !
 
@@ -4490,17 +4483,17 @@
             "/ The repair code will be removed at some time in the future...
 
             "/ temporary fix Felix' bad string translation:
-            (aString startsWith:'§Header:') ifTrue:[
-                (aString endsWith:'Exp §') ifTrue:[
+            (aString startsWith:'§Header:') ifTrue:[
+                (aString endsWith:'Exp §') ifTrue:[
                     fixedString := '$' , (aString copyFrom:3 to:(aString size - 2)) , '$'.
 
                     aClass isNil ifTrue:[
                         autoFixHolder value ifFalse:[
-                            Dialog information:'Attention: the CVS version string is corrupted (§-bug). Please fix it manually'.
+                            Dialog information:'Attention: the CVS version string is corrupted (§-bug). Please fix it manually'.
                         ]
                     ] ifFalse:[
                         (autoFixHolder value 
-                            or:[ Dialog confirm:('Attention: the CVS version string is corrupted in "%1" (§-bug). Fix it?' withCRs bindWith:aClass name) ]
+                            or:[ Dialog confirm:('Attention: the CVS version string is corrupted in "%1" (§-bug). Fix it?' withCRs bindWith:aClass name) ]
                         ) ifTrue:[
                             self updateVersionMethodOf:aClass for:fixedString.
                         ].
@@ -4508,7 +4501,7 @@
                 ].
             ].
 
-            "/ temporary fix Jan's bad Umlaut-removal (which results in Felix's bad § being removed):
+            "/ temporary fix Jan's bad Umlaut-removal (which results in Felix's bad § being removed):
             (aString startsWith:'Header: ') ifTrue:[
                 (aString endsWith:'Exp ') ifTrue:[
                     fixedString := '$' , aString , '$'.
@@ -5789,7 +5782,7 @@
     "/ $-Revision: rev $
     "/ $-Id:       fileName rev date time user state $
     "/
-    (firstWord = '$Header:' or:[firstWord = '§Header:']) ifTrue:[
+    (firstWord = '$Header:' or:[firstWord = '§Header:']) ifTrue:[
         d := firstWord first.
         s skipSeparators.
         nm := s throughAll:',v '.
@@ -5819,12 +5812,12 @@
         ^ info
     ].
 
-    (firstWord = '$Revision:' or:[firstWord = '§Revision:']) ifTrue:[
+    (firstWord = '$Revision:' or:[firstWord = '§Revision:']) ifTrue:[
         info revision:(s upToEnd asCollectionOfWords first).
         ^ info
     ].
 
-    (firstWord = '$Id:' or:[firstWord = '§Id:']) ifTrue:[
+    (firstWord = '$Id:' or:[firstWord = '§Id:']) ifTrue:[
         "/commented out by Jan Vrany, 2009/10/20
         "/according to http://svnbook.red-bean.com/en/1.5/svn.advanced.props.special.keywords.html
         "/svn has no support for $ Header $ expansion. Therefore