MessageNode.st
changeset 3310 f22eebdb8868
parent 3290 ed93979b62ac
child 3313 860a2a61cbde
--- a/MessageNode.st	Sat Aug 31 13:30:27 2013 +0200
+++ b/MessageNode.st	Sat Aug 31 13:30:42 2013 +0200
@@ -409,7 +409,8 @@
 !MessageNode methodsFor:'checks'!
 
 checkCondition
-    "check ifTrue/ifFalse for plausibility"
+    "check ifTrue/ifFalse for plausibility.
+     TODO: rewite to use lint/lint rules and apply them before accepting"
 
     |args lastArg receiverSelector or1 or2|
 
@@ -460,7 +461,8 @@
 checkGlobalFromNameSpaceConflictFor:aNode
     "check if aNode is a local-nameSpace's variable,
      which hides a global from Smalltalk with the same name.
-     This is especially bad for Error handle: do:... "
+     This is especially bad for Error handle: do:... 
+     TODO: rewite to use lint/lint rules and apply them before accepting"
 
     |fullName shortName|
 
@@ -478,11 +480,11 @@
 !
 
 checkIdentityCompare
+    "check #== applied to Floats, Strings or Fractions
+     TODO: rewite to use lint/lint rules and apply them before accepting"
+
     |rec arg1 arg1Value operand|
 
-    "
-     check #== applied to Floats, Strings or Fractions
-    "
     ((selector == #==) or:[selector == #~~]) ifTrue:[
         (argArray size > 0) ifTrue:[
             arg1 := argArray at:1
@@ -528,7 +530,8 @@
 !
 
 checkInlinability
-    "early check for possible inlinability"
+    "early check for possible inlinability.
+     TODO: rewite to use lint/lint rules and apply them before accepting"
 
     |numArgs arg1 arg2 arg3|
 
@@ -626,6 +629,9 @@
 !
 
 plausibilityCheckIn:aParser
+    "some useful checks applied when accepting in a browser.
+     TODO: rewite to use lint/lint rules and apply them before accepting"
+
     |arg1 msg|
 
     (argArray size > 0) ifTrue:[
@@ -682,7 +688,7 @@
     argArray size > 0 ifTrue:[
         "/ check for a beginners error (using super as arg)
         "/ as in (something ? super) foo
-
+        "/ let him know, that this will not be a "super foo"
         argArray do:[:arg | arg isSuper ifTrue:[
                                 ^ 'super special semantic only with receiver of message sends'
                             ]
@@ -3349,11 +3355,11 @@
 !MessageNode class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libcomp/MessageNode.st,v 1.201 2013-08-26 13:44:37 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libcomp/MessageNode.st,v 1.202 2013-08-31 11:30:42 cg Exp $'
 !
 
 version_CVS
-    ^ '$Header: /cvs/stx/stx/libcomp/MessageNode.st,v 1.201 2013-08-26 13:44:37 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libcomp/MessageNode.st,v 1.202 2013-08-31 11:30:42 cg Exp $'
 !
 
 version_SVN