Allow single underscore as method / block argument and temporaries This commit is a follow up for 38b221e.

Merge

`AbstractSyntaxHighlighter`: use set color preferences (theme) when marking error

Allow single underscore to be a valid variable name ...is `allowUndestoreInIdentifier` is on. Pharo allows it and some code uses this (for example, MachineArithmetic [1]). [1]: https://github.com/shingarov/MachineArithmetic/commit/65c57667e281fba986f8d40777151370055b77a8

Improve support for implicit self-sends (in Self's sense)

Adding #lineNumber accessor for compatibility reasons.

Fixing the variable(Node) to report line number.

Adding missing endPosition for MessageNode. This bug will show itself when a cascaded message is send.

Merge

Merge

Fix bug in (some) symbol literal parsing Smalltalk/X supports Scheme-like typed array literals like #d(1 2 3) - as array of doubles. However, due to a bug in `Scanner`, symbols named by these prefixes followed by collon were not scanned correctly, i.e, `#d:` was actually scanned as two tokens, `#d` and `:`. This commit fixes the issue by explicitly checking whether collon is immediately following in case parsing fall backs from typed-array parsing to symbol parsing. This bug has been pulled in by merging with eXept's code.

Merge

Merge branch 'default'

#BUGFIX by exept class: Parser changed: #variableOrError: first look for Workspace vars, THEN for globals.

#OTHER by exept use CharacterWriteStream new

#OTHER by exept use CharacterWriteStream new

#OTHER by exept comment

#BUGFIX by exept class: ParseNode added: #isSynthetic

#DOCUMENTATION by exept class: MessageNode comment/format in: #numArgs

#UI_ENHANCEMENT by exept class: Scanner changed: #invalidCharacter:

#FEATURE by exept class: Scanner changed: #invalidCharacter:

#TUNING by exept class: Parser changed: #stringWithEmbeddedExpressions

#DOCUMENTATION by exept class: LazyMethod comment/format in: #isLazyMethod

#OTHER by exept withDoubleQuotes

#BUGFIX by exept class: Parser changed: #checkForEndOfInput #primary #stringWithEmbeddedExpressions #warnUnused:

#UI_ENHANCEMENT by exept class: Explainer class changed: #explainNode:in:forClass:short:interval:

#UI_ENHANCEMENT by exept class: Explainer class comment/format in: #documentation

#UI_ENHANCEMENT by exept class: Explainer class changed: #explainLiteralNode:in:forClass:short:interval:

#FEATURE by exept class: Explainer class changed: #explainLiteralNode:in:forClass:short:interval:

#FEATURE by exept class: ConstantNode added: #isLiteralEString #isLiteralIString #isLiteralRString #isSTXSpecialLiteralString: changed: #isLiteralCString

#FEATURE by exept class: Scanner changed: #xnextString:escapeStyle:

#FEATURE by exept class: Parser comment/format in: #degeneratedKeywordExpressionForSelector changed: #primary #stringWithEmbeddedExpressions

#DOCUMENTATION by exept class: MessageNode class comment/format in: #receiver:selector:arg1:arg2:

#FEATURE by exept class: Scanner i-strings comment/format in: #nextString:escapeStyle: changed: #nextIdentifier #xnextString:escapeStyle: class: Scanner class comment/format in: #documentation

#FEATURE by exept class: Parser i-strings changed: #primary #stringWithEmbeddedExpressions

#FEATURE by exept class: ParserFlags changed: #initialize class: ParserFlags class changed: #initialize

#FEATURE by exept class: ParserFlags added: #allowIStrings

#FEATURE by exept class: ParserFlags class definition added: #allowIStrings: class: ParserFlags class added: #allowIStrings #allowIStrings:

#DOCUMENTATION by exept class: Scanner comment/format in: #actionToDisableWarning:

#UI_ENHANCEMENT by exept class: Parser changed: #warnIfPossiblyUninitializedLocal:

#REFACTORING by exept class: ConstantNode changed: #codeForSideEffectOn:inBlock:for:

#REFACTORING by exept class: Parser comment/format in: #checkForLowercaseVariableName: #checkLocalVariableNameConventionsFor: #parseMethodBodyVarSpec changed: #blockBody #checkForProperUseOfArticleInVariableName: #checkReturnedValues #inlineObjectFrom: #primary #primary_identifier #warnIfPossiblyUninitializedLocal: #warnSTXNameSpaceUseAt:

#REFACTORING by exept class: ParserFlags class definition added: #warnSTXSpecials: class: ParserFlags class added: #warnAboutInlineObjects #warnAboutInlineObjects: changed: #initialize

#REFACTORING by exept class: Scanner added: #actionToDisableWarning: changed: #skipComment #warnDollarAt: #warnOldStyleAssignmentAt: #warnParagraphAt: #warnPeriodAt: #warnPossibleIncompatibility:position:to: #warnSTXSpecialCommentAt:to: #warnUnderscoreAt:

#UI_ENHANCEMENT by exept class: ConstantNode class definition changed: #codeForSideEffectOn:inBlock:for:

#FEATURE by exept class: ParserFlags class definition added: #warnAboutDeadCodeAndFixMe #warnAboutDeadCodeAndFixMe: changed: #initialize class: ParserFlags class added: #warnAboutDeadCodeAndFixMe #warnAboutDeadCodeAndFixMe: changed: #initialize

#UI_ENHANCEMENT by exept class: Parser changed: #parseMethodBodyVarSpec

#REFACTORING by bg class: Scanner comment/format in: #nextToken changed: #invalidCharacter:

update tags

#BUGFIX by cg class: BreakpointNode added: #isUnaryMessage DNU

#FEATURE by cg class: Parser changed: #parseAnnotationLiteral #parseOtherPrimitives #parseTraditionalPrimitive

#DEBUGCODEREMOVED by cg class: Parser changed: #typedArray:

#BUGFIX by cg class: Scanner changed: #skipComment endPosition off by one

#UI_ENHANCEMENT by cg class: Scanner::Comment added: #displayOn:

#QUALITY by stefan class: ObjectFileHandle changed: #update:with:from: use Logger

#DOCUMENTATION by cg class: ParseNode comment/format in: #objectAttributes

#DOCUMENTATION by cg class: STCCompilerInterface comment/format in: #compileToC_onError: changed: #setupCompilationCommandArguments

info

#REFACTORING by cg class: Parser class changed: #selectorInExpression:

#BUGFIX by cg class: ByteCodeCompiler changed: #compile:forClass:inCategory:notifying:install:skipIfSame:silent:foldConstants: return value was not the method (ifFail)

#DOCUMENTATION by cg class: Scanner changed: #nextSpecialWith:

#QUALITY by stefan class: Structure changed: #doesNotUnderstand: use Logger

#UI_ENHANCEMENT by cg class: Explainer class changed: #valueStringFor:

#REFACTORING by cg class: Parser changed: #selectorCheck:for:positions: foreignSelector annotation handling

#BUGFIX by cg foreignSelectors had bad syntax

#BUGFIX by cg class: Parser changed: #selectorCheck:for:positions:

#BUGFIX by cg class: AbstractSyntaxHighlighter added: #formatMethodSource:in:using: changed: #formatExpression:in: #formatMethod:source:in:using: classToCompileFor was not set; input/outputs were marked as unknown vars

#FEATURE by cg class: SyntaxHighlighter class definition added: #unknownVariableResolver

#FEATURE by cg class: Parser added: #unknownVariableResolver comment/format in: #correctVariable:atPosition:to: changed: #variableOrError:

Allow identifiers to start with $ (dollar) ...when flag `allowDollarInIdentifier` is on.

Allow setting custom variable resolver for parsing / compilation Normally there's none - this interface is provided for cases where user wants to provide her own variable bindings - useful when evaluating custom scripts.

Improve `Parser >> #checkSelector:for:inClass:` ...to work better with alien code (such as, with RING environment)

Do not optimize `^ x and: y` and `^ x or: y` The problem is that this actually prevents one from implementing boolean-like objects. For example, MachineArithmetic [1] does that. [1]: https://github.com/shingarov/MachineArithmetic

Oops, use `#realSharedPoolNames` when searching inherited shared pools The shared pool check block accepts names, not pools themselves!

`Decompiler:` print indication that indirect literal frame is used.

Fix bug in parsing literal arrays ...containing unquoted symbols starting with underscore, i.e., #(_a:bc:) which were wrongly parsed as `#(#'_a:_bc')`. Also, there was a DNU (rather than syntax error) when parsing unterminated array literal like: #(_a:bc: This commit fixes both problems.

Fix debug info w.r.t inlined blocks It turned out that even if `BlockNode >> isInlinable` returns `true`, the block can still be full block (that is, NOT inlined). This lead to wrong debug info being generated, marking some variables as inlined even though they were not. To workaround this, introduce a new `BlockNode >> #isInlined` that returns true whether or not the block was inlined during compilation. This should be called (i.e., it is valid) only after code generation. The code to create debug info is then changed to use `#isInlined` instead of `#isInlinable`.

Add compiler flag to allow usage of inherited pools This mimics the behavior of many other smalltalks, most notably the one of Squeak / Pharo and Bee. While this is not supported by `stc`, it allows to work with such code in Smalltalk/X.

Set parent in `BreakpointNode >> #expression:` ...to self. A parent chain must lead to a top-level statement / method node for `BlockNode >> method` to work properly, which is needed for correct generation of debug info when compiling method with line breakpoints.

Fix various node enumeration methods for `BreakpointNode`

Fix `Context >> #dbgVariables` to return `#()` for contexts without a method

Fixed compiler to produce correct(ish) variable table This commit fixes a number of issues w.r.t inlined blocks and variable tables: * inlined blocks were mis-detected, we have to use `#isInlinable` as the `#isInlined` actually return `false` always, * there we duplicated records in variable table because some blocks have been visitied more than once, * block-locals for inlined blocks in method have wrong offsets since method arguments were not take into the account. For example, before this commit `ExternalLibraryFunction >> ffiCall:` had completely bogus info when bytecode-compiled.

Implement `Context >> argAndVarNames` using compiler-recorded debug info This implementation overrides the one from stx:libbasic which never worked properly (and it's horribly complex).

Fix ParserFlags and STCCompilerInterface to work with out-of-tree builds ...in addition to old, in-tree builds. This requies searching in `'build' / Smalltalk configuration` as well.

Search for binary class libraries in `build/<target>` first This is to support out-of-tree builds which allow one to compile Smallalk/X for multiple targets out of one source tree (useful for testing)

#FEATURE by cg class: ParseError added: #position

#BUGFIX by stefan class: AssignmentNode added: #variableNodesDo:

#UI_ENHANCEMENT by cg class: Parser changed: #errorMessageForUndefined: #selectorCheck:for:positions: typos: genitive of class is class's - not classes.

#FEATURE by cg class: Breakpoint added: #method comment/format in: #method:

#REFACTORING by cg class: Explainer class withCRs eliminated hanged: #explain:in:forClass:short: #explainGlobalOrPoolVariable:inClass:short: #explainSelector:inClass:short: #fetchCommentOfMethod:

#BUGFIX by cg class: Explainer class changed: #explain:in:forClass:short:

#BUGFIX by cg class: Parser changed: #stringWithEmbeddedExpressions

#BUGFIX by cg class: SyntaxHighlighter comment/format in: #markParenthesisAt:

#REFACTORING by exept class: ParserFlags class changed: #initialize

#DOCUMENTATION by exept class: Parser changed: #stringWithEmbeddedExpressions

#DOCUMENTATION by exept class: ParserFlags class comment/format in: #allowCStrings #allowEStrings changed: #initialize

#BUGFIX by exept class: Explainer class changed: #thisOrNewBrowserInto:

#REFACTORING by cg class: Parser changed: #primary

#REFACTORING by cg class: Scanner changed: #nextNumber

#REFACTORING by cg class: ParserFlags changed: #allowExtendedBinarySelectors #allowFixedPointLiterals class: ParserFlags class changed: #allowExtendedBinarySelectors #allowFixedPointLiterals

unsigned INT vs. UINT (on OSX)

#BUGFIX by stefan class: ObjectFileLoader class changed: #primLoadDynamicObject:into: #primUnloadDynamicObject: #unloadDynamicObject: Disable FreeLibrary() for BorlandC, reenable it for MINGW

#BUGFIX by stefan class: ObjectFileLoader class changed: #primUnloadDynamicObject: Workaround in 1.403 was not needed - undo it

#WORKAROUND by stefan class: ObjectFileLoader class changed: #primUnloadDynamicObject: again, relly work around BCC expecco freeze

#BUGFIX by stefan class: ObjectFileLoader class changed: #primUnloadDynamicObject: fix expcco startup failure in BCC build

#BUGFIX by stefan class: ByteCodeCompiler changed: #compile:forClass:inCategory:notifying:install:skipIfSame:silent:foldConstants:ifFail: failBlock may have an optional argument

#UI_ENHANCEMENT by cg class: ParseError changed: #description

#REFACTORING by stefan class: VariableNode changed: #store: remove return after return

#REFACTORING by exept class: Explainer::ActionWithInfo category of: #info

#QUALITY by cg class: InstrumentingCompiler::MethodInvocationInfo added: #printOn:

#FEATURE by cg class: InstrumentingCompiler class added: #cleanAllInfos changed: #cleanAllInfo #compileMethod:

#BUGFIX by cg class: InstrumentingCompiler class changed: #compileMethod:

#REFACTORING by cg class: InstrumentingCompiler added: #undefError:position:to: removed: #correctVariable:atPosition:to:

#DOCUMENTATION by cg class: InstrumentedMethod comment/format in: #isInstrumented

#REFACTORING by cg class: InstrumentingCompiler added: #correctVariable:atPosition:to: class: InstrumentingCompiler class changed: #compileMethod:

#FEATURE by cg class: InstrumentingCompiler class changed: #compileMethod:

update tags

#BUGFIX by exept class: Parser changed: #returnStatement

update tags

#REFACTORING by exept class: ObjectFileLoader class changed: #createLoadableObjectFor: