git/GitCommitDialog.st
author Jan Vrany <jan.vrany@labware.com>
Fri, 19 Feb 2021 08:29:41 +0000
changeset 924 4d92f234f671
parent 481 0cfef855baa2
permissions -rw-r--r--
Rework and fix HGSourceCodeManager >> #revisionLogOf:...directory:module:` This commit changes the logic in two ways: 1. #newestRevision is now the newest revision in the branch that *contains* given file (not necesarily modidfes it). If there are multiple heads in that branch, pretty much random one is returned. This changes old behavior and therefore this commit updates tests. 2. If a specific single revision is requested, i.e., both from and to revisions are the same, revision log with that single revision is returned no matter whether it modifies the file or even contains that file at all. This is essentially a workaround to fix issue #305. Moreover, this commit simplifies the code a lot by delegating all the changeset searching and filtering to mercurial using revset expressions. See https://swing.fit.cvut.cz/projects/stx-jv/ticket/305#comment:3
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
30
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
     1
"{ Package: 'stx:libscm/git' }"
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
     2
45
dfe5c7416a4e Refactoring to reuse classes from stx:libscm/common
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents: 32
diff changeset
     3
SCMAbstractCommitDialog subclass:#GitCommitDialog
dfe5c7416a4e Refactoring to reuse classes from stx:libscm/common
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents: 32
diff changeset
     4
	instanceVariableNames:''
30
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
     5
	classVariableNames:''
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
     6
	poolDictionaries:''
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
     7
	category:'SCM-Git-StX-Interface'
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
     8
!
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
     9
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    10
45
dfe5c7416a4e Refactoring to reuse classes from stx:libscm/common
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents: 32
diff changeset
    11
!GitCommitDialog class methodsFor:'image specs'!
30
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    12
45
dfe5c7416a4e Refactoring to reuse classes from stx:libscm/common
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents: 32
diff changeset
    13
dialogIcon
dfe5c7416a4e Refactoring to reuse classes from stx:libscm/common
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents: 32
diff changeset
    14
    ^ GitIconLibrary gitLogo1
30
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    15
45
dfe5c7416a4e Refactoring to reuse classes from stx:libscm/common
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents: 32
diff changeset
    16
    "Created: / 13-04-2008 / 11:06:56 / Jan Vrany <vranyj1@fel.cvut.cz>"
dfe5c7416a4e Refactoring to reuse classes from stx:libscm/common
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents: 32
diff changeset
    17
    "Modified: / 04-10-2012 / 19:16:10 / Jan Vrany <jan.vrany@fit.cvut.cz>"
30
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    18
! !
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    19
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    20
!GitCommitDialog class methodsFor:'documentation'!
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    21
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    22
version_SVN
481
0cfef855baa2 Initial import from upstream repository
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 45
diff changeset
    23
    ^ '$Id$'
30
fe60ba16ea8b - GitFileoutLikeTask
vranyj1@bd9d3459-6c23-4dd9-91de-98eeebb81177
parents:
diff changeset
    24
! !