Tools__LintService.st
author Stefan Vogel <sv@exept.de>
Fri, 17 May 2019 17:11:44 +0200
changeset 18767 0478d93cdb75
parent 18643 4979c2559134
child 19091 344b0305c9b5
permissions -rw-r--r--
#REFACTORING by stefan Sanitize BlockValues class: Tools::Inspector2 changed: #toolbarBackgroundHolder
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
18643
4979c2559134 #DOCUMENTATION by cg
Claus Gittinger <cg@exept.de>
parents: 16605
diff changeset
     1
"{ Encoding: utf8 }"
4979c2559134 #DOCUMENTATION by cg
Claus Gittinger <cg@exept.de>
parents: 16605
diff changeset
     2
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
     3
"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
     4
 COPYRIGHT (c) 2010 by Jan Vrany, SWING Research Group. CTU in Prague
efc1f0809373 initial checkin
vrany
parents:
diff changeset
     5
              All Rights Reserved
efc1f0809373 initial checkin
vrany
parents:
diff changeset
     6
efc1f0809373 initial checkin
vrany
parents:
diff changeset
     7
Permission is hereby granted, free of charge, to any person
efc1f0809373 initial checkin
vrany
parents:
diff changeset
     8
obtaining a copy of this software and associated documentation
efc1f0809373 initial checkin
vrany
parents:
diff changeset
     9
files (the 'Software'), to deal in the Software without
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    10
restriction, including without limitation the rights to use,
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    11
copy, modify, merge, publish, distribute, sublicense, and/or sell
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    12
copies of the Software, and to permit persons to whom the
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    13
Software is furnished to do so, subject to the following
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    14
conditions:
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    15
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    16
The above copyright notice and this permission notice shall be
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    17
included in all copies or substantial portions of the Software.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    18
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    19
THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    20
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    21
OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    22
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    23
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    24
WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    25
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    26
OTHER DEALINGS IN THE SOFTWARE.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    27
"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    28
"{ Package: 'stx:libtool' }"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    29
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    30
"{ NameSpace: Tools }"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    31
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    32
CodeViewService subclass:#LintService
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
    33
	instanceVariableNames:'ruleHolderFromApp highlighter annotations
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
    34
		annotationsSequenceNumber'
11416
941e576b6f71 changed: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11390
diff changeset
    35
	classVariableNames:''
941e576b6f71 changed: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11390
diff changeset
    36
	poolDictionaries:''
941e576b6f71 changed: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11390
diff changeset
    37
	category:'Interface-Lint'
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    38
!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    39
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    40
!LintService class methodsFor:'documentation'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    41
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    42
copyright
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    43
"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    44
 COPYRIGHT (c) 2010 by Jan Vrany, SWING Research Group. CTU in Prague
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    45
              All Rights Reserved
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    46
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    47
Permission is hereby granted, free of charge, to any person
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    48
obtaining a copy of this software and associated documentation
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    49
files (the 'Software'), to deal in the Software without
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    50
restriction, including without limitation the rights to use,
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    51
copy, modify, merge, publish, distribute, sublicense, and/or sell
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    52
copies of the Software, and to permit persons to whom the
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    53
Software is furnished to do so, subject to the following
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    54
conditions:
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    55
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    56
The above copyright notice and this permission notice shall be
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    57
included in all copies or substantial portions of the Software.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    58
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    59
THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    60
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    61
OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    62
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    63
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    64
WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    65
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    66
OTHER DEALINGS IN THE SOFTWARE.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    67
"
16605
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    68
!
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    69
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    70
documentation
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    71
"
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    72
    cg:
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    73
    
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    74
    This service framework is a bit confusing; there is so much code duplication.
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    75
    The distinction between LintService and Smallsense::SmalltalkLintService is
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    76
    unclear to me.
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    77
    
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    78
    If I understand this correctly, this is used to highlight the
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    79
    output of the static analyzer (debug-button in browser), whereas Smallsense::SmalltalkLintService
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    80
    displays the output from the just-in-time analysis in the codeview
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    81
    Is this correct?
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    82
    Why not merge those two - most of the functionality is the same.     
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
    83
"    
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    84
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    85
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    86
!LintService class methodsFor:'accessing'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    87
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    88
label
13099
f4f0761ca231 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 11416
diff changeset
    89
    "Answers a short label - for UI"
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    90
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    91
    ^'SmallLint Checker'
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    92
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    93
    "Created: / 05-08-2011 / 11:01:33 / Jan Vrany <jan.vrany@fit.cvut.cz>"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    94
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
    95
13202
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
    96
!LintService class methodsFor:'testing'!
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
    97
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
    98
isUsefulFor:aCodeView
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
    99
    "this filters useful services.
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
   100
     Redefined to return true for myself - not for subclasses"
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
   101
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
   102
    ^ self == Tools::LintService
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
   103
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
   104
    "Created: / 22-07-2013 / 14:01:38 / cg"
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
   105
! !
dd6ea03d2edd class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 13099
diff changeset
   106
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   107
!LintService methodsFor:'accessing'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   108
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   109
annotationAtLine: lineNo
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   110
    | anns |
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   111
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   112
    (anns := self annotations) notNil ifTrue:[ 
15076
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   113
        ^ anns detect:[:annotation | annotation line = lineNo] ifNone:[nil]
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   114
    ].
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   115
    ^ nil
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   116
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   117
    "Created: / 30-01-2012 / 21:06:25 / Jan Vrany <jan.vrany@fit.cvut.cz>"
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   118
    "Modified: / 15-12-2014 / 15:40:39 / Jan Vrany <jan.vrany@fit.cvut.cz>"
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   119
!
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   120
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   121
annotations
18643
4979c2559134 #DOCUMENTATION by cg
Claus Gittinger <cg@exept.de>
parents: 16605
diff changeset
   122
    | rulesToIntervalsMap annotationsPerLineMap |
4979c2559134 #DOCUMENTATION by cg
Claus Gittinger <cg@exept.de>
parents: 16605
diff changeset
   123
15076
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   124
    #fixme. "/ code duplication with SmalltalkLintService >> annotations
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   125
    (highlighter notNil and:[ highlighter sequenceNumber ~~ annotationsSequenceNumber ]) ifTrue:[
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   126
        rulesToIntervalsMap := highlighter rulesToIntervalsMap.
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   127
        rulesToIntervalsMap notNil ifTrue:[ 
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   128
            annotationsPerLineMap := Dictionary new.
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   129
            rulesToIntervalsMap keysAndValuesDo:[ :rule :intervals |
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   130
                intervals do:[:interval | 
15076
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   131
                    | line annotation ruleAlready|
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   132
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   133
                    line := codeView lineOfCharacterPosition: interval first.
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   134
                    annotation := annotationsPerLineMap at: line ifAbsentPut:[ LintAnnotation new line: line ].
15076
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   135
                    ruleAlready := annotation rule.
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   136
                    ruleAlready notNil ifTrue:[ 
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   137
                        ruleAlready isComposite ifTrue: [ 
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   138
                            (ruleAlready rules includes:rule) ifFalse:[
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   139
                                ruleAlready addRule:rule "rules add: rule"
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   140
                            ].
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   141
                        ] ifFalse:[
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   142
                            ruleAlready ~= rule ifTrue:[
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   143
                                annotation rule: (RBCompositeLintRule rules: (OrderedCollection with: ruleAlready with: rule))
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   144
                            ]
c3c0c682a1e0 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 15030
diff changeset
   145
                        ]
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   146
                    ] ifFalse:[ 
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   147
                        annotation rule: rule
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   148
                    ].
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   149
                ].
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   150
            ].
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   151
            annotations := annotationsPerLineMap values sort:[ :a :b | a line < b line ].
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   152
            annotationsSequenceNumber := highlighter sequenceNumber.
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   153
        ]
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   154
    ].
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   155
    ^annotations
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   156
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   157
    "Created: / 15-12-2014 / 15:29:37 / Jan Vrany <jan.vrany@fit.cvut.cz>"
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   158
    "Modified: / 15-12-2014 / 18:41:14 / Jan Vrany <jan.vrany@fit.cvut.cz>"
18643
4979c2559134 #DOCUMENTATION by cg
Claus Gittinger <cg@exept.de>
parents: 16605
diff changeset
   159
    "Modified (format): / 02-03-2019 / 12:34:13 / Claus Gittinger"
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   160
!
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   161
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   162
syntaxHighlighter
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   163
    | app rules |
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   164
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   165
    app := codeView application.
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   166
    app notNil ifTrue:[
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   167
        rules := self ruleHolderFromApp value.
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   168
        rules notEmptyOrNil ifTrue:[
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   169
            annotations := nil.
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   170
            highlighter rules: rules.
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   171
            ^ highlighter
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   172
        ].
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   173
    ].
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   174
    ^nil
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   175
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   176
    "Created: / 05-08-2011 / 10:59:02 / Jan Vrany <jan.vrany@fit.cvut.cz>"
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   177
    "Modified: / 08-03-2012 / 01:23:48 / cg"
15030
c8d7085ee271 LintHighlighter/.LintService refactored to show multiple rules at line...
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14972
diff changeset
   178
    "Modified: / 15-12-2014 / 20:22:58 / Jan Vrany <jan.vrany@fit.cvut.cz>"
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   179
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   180
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   181
!LintService methodsFor:'aspects'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   182
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   183
ruleHolderFromApp
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   184
    "return/create the 'ruleHolderFromApp' value holder (automatically generated)"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   185
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   186
    |app|
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   187
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   188
    ruleHolderFromApp isNil ifTrue:[
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   189
        (app := self application) notNil ifTrue:[
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   190
            self fetchLintRuleHolder
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   191
            "/ ruleHolderFromApp := ValueHolder new.
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   192
            "/ ruleHolderFromApp addDependent:self.
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   193
        ].
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   194
    ].
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   195
    ^ ruleHolderFromApp
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   196
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   197
    "Modified: / 08-03-2012 / 01:17:15 / cg"
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   198
!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   199
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   200
ruleHolderFromApp:something
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   201
    "set the 'ruleHolderFromApp' value holder (automatically generated)"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   202
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   203
    |oldValue newValue|
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   204
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   205
    ruleHolderFromApp notNil ifTrue:[
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   206
        oldValue := ruleHolderFromApp value.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   207
        ruleHolderFromApp removeDependent:self.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   208
    ].
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   209
    ruleHolderFromApp := something.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   210
    ruleHolderFromApp notNil ifTrue:[
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   211
        ruleHolderFromApp addDependent:self.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   212
    ].
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   213
    newValue := ruleHolderFromApp value.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   214
    oldValue ~~ newValue ifTrue:[
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   215
        self update:#value with:newValue from:ruleHolderFromApp.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   216
    ].
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   217
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   218
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   219
!LintService methodsFor:'change & update'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   220
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   221
update: aspect with: param from: sender
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   222
    aspect == #sizeOfView ifFalse:[
16605
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   223
    aspect == #pointerInView ifFalse:[
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   224
        sender == ruleHolderFromApp ifTrue:[
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   225
            self syntaxHighlight: true.
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   226
            ^ self.
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   227
        ]
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   228
    ].
16605
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   229
    ].
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   230
    super update: aspect with: param from: sender.
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   231
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   232
    "Created: / 05-08-2011 / 11:49:21 / Jan Vrany <jan.vrany@fit.cvut.cz>"
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   233
    "Modified: / 07-03-2012 / 17:16:59 / cg"
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   234
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   235
14972
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   236
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   237
!LintService methodsFor:'initialization'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   238
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   239
initialize
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   240
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   241
    super initialize.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   242
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   243
    highlighter := LintHighlighter new
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   244
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   245
    "Modified: / 03-09-2010 / 22:29:22 / Jan Vrany <jan.vrany@fit.cvut.cz>"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   246
    "Created: / 05-08-2011 / 11:53:05 / Jan Vrany <jan.vrany@fit.cvut.cz>"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   247
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   248
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   249
!LintService methodsFor:'private'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   250
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   251
syntaxHighlight: delayed
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   252
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   253
    | service |
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   254
    service := self service: #'Tools::CodeHighlightingService'.
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   255
    service notNil ifTrue:[
14052
ebcdddd89b02 Fix in BackrgoundSourceProcessingService:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 13498
diff changeset
   256
        service processSafely: delayed
16605
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   257
    ].
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   258
    codeView updateScrollersViewBackground.
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   259
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   260
    "Created: / 05-08-2011 / 11:49:21 / Jan Vrany <jan.vrany@fit.cvut.cz>"
14052
ebcdddd89b02 Fix in BackrgoundSourceProcessingService:
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 13498
diff changeset
   261
    "Modified: / 25-02-2014 / 19:57:41 / Jan Vrany <jan.vrany@fit.cvut.cz>"
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   262
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   263
14972
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   264
!LintService methodsFor:'redrawing'!
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   265
16605
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   266
drawLine:lineNo in:view atX:x y:yBaseline width:w height:hFont ascent:aFont from:startCol to:endColOrNil with:fg and:bg 
14972
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   267
    "Called by both gutterView and textView (well, not yet) to
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   268
     allow services to draw custom things on text view.
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   269
     Ask JV what the args means if unsure (I'm lazy to document
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   270
     them, now it is just an experiment...)"
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   271
16605
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   272
    "/ cg: why only for smalltalk?
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   273
    "/ if there are annotations, why not show it?
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   274
    "/ | lang |
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   275
    "/ ((lang := codeView language) isNil or:[lang isSmalltalk not]) ifTrue:[ ^ self ].
14972
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   276
16605
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   277
    self drawAnnotationInLine:lineNo 
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   278
         in:view atX:x y:yBaseline width:w height:hFont ascent:aFont 
759e80b6e2fb #OTHER by cg
Claus Gittinger <cg@exept.de>
parents: 16555
diff changeset
   279
         from:startCol to:endColOrNil with:fg and:bg
14972
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   280
! !
0e176d3678b1 Support for line annotations
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 14052
diff changeset
   281
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   282
!LintService methodsFor:'registering'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   283
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   284
fetchLintRuleHolder
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   285
    |app|
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   286
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   287
    app := self application.
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   288
    app notNil ifTrue:[
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   289
        "/ bad design; better idea would be to pass the lintRuleHolder back from the
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   290
        "/ application to me explicitely (in a postBuild method for some ruleCanvas of the app)
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   291
        (app respondsTo: #selectedLintRules) ifTrue:[
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   292
            self ruleHolderFromApp: app selectedLintRules
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   293
        ] ifFalse:[
13498
b8d845e42988 Added `environment` instance variable to Tools__NewSystemBrowser and
Jan Vrany <jan.vrany@fit.cvut.cz>
parents: 13202
diff changeset
   294
            "/ self breakPoint:#jv.
11416
941e576b6f71 changed: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11390
diff changeset
   295
            "/ Transcript showCR:'LintService [info]: app does not provide a lintRuleHolder'
11382
c078e68a2ffe changed:
Claus Gittinger <cg@exept.de>
parents: 11227
diff changeset
   296
        ]
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   297
    ].
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   298
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   299
    "Created: / 08-03-2012 / 01:16:38 / cg"
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   300
!
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   301
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   302
registerIn: aCodeView
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   303
    super registerIn: aCodeView.
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   304
    self fetchLintRuleHolder.
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   305
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   306
    "Modified: / 17-06-2011 / 13:07:03 / Jan Vrany <jan.vrany@fit.cvut.cz>"
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   307
    "Created: / 05-08-2011 / 11:47:06 / Jan Vrany <jan.vrany@fit.cvut.cz>"
11390
b5af6f49f10f added: #fetchLintRuleHolder
Claus Gittinger <cg@exept.de>
parents: 11389
diff changeset
   308
    "Modified: / 08-03-2012 / 01:16:51 / cg"
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   309
! !
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   310
16555
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   311
!LintService methodsFor:'testing'!
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   312
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   313
isLintService
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   314
    ^ true
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   315
! !
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   316
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   317
!LintService class methodsFor:'documentation'!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   318
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   319
version
16555
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   320
    ^ '$Header$'
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   321
!
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   322
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   323
version_CVS
16555
6b84fcdf3207 #UI_ENHANCEMENT by cg
Claus Gittinger <cg@exept.de>
parents: 15293
diff changeset
   324
    ^ '$Header$'
10484
efc1f0809373 initial checkin
vrany
parents:
diff changeset
   325
! !
13099
f4f0761ca231 class: Tools::LintService
Claus Gittinger <cg@exept.de>
parents: 11416
diff changeset
   326