hg/stx-libtool: comparison Tools_

equal deleted inserted replaced

-:3eea1002b141
+:028adf14bc05
 "{ NameSpace: Tools }"
 ApplicationModel subclass:#LintRuleDetail
 	instanceVariableNames:'ruleHolder rationaleVisibleHolder rationalView
-		selectedMethodsHolder'
+		selectedMethodsHolder selectedClassesHolder'
 	classVariableNames:''
 	poolDictionaries:''
 	category:'Interface-Lint'
 !
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
 HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
 WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 OTHER DEALINGS IN THE SOFTWARE.
+"
+!
+documentation
+"
+Embeddable list to display affected methods from a selected SmallLint rules.
+(this is embedded in the browser when showing lint check outcomes)
+[author:]
+Jan Vrany <jan.vrany@fit.cvut.cz>
+[instance variables:]
+[class variables:]
+[see also:]
 "
 ! !
 !LintRuleDetail class methodsFor:'help specs'!
 ^ #(
 #ruleHolder
 #ruleRationaleAspect
 #selectedMethodsHolder
+#selectedClassesHolder
 ).
 "Modified: / 01-03-2012 / 16:31:04 / cg"
 ! !
 browseLintRule
 |rule ruleClass sel|
 rule := self ruleHolder value.
 rule isNil ifTrue:[^ self].
 ruleClass := rule class.
 (ruleClass implements:#rationale) ifTrue:[
 sel := #rationale.
 ].
 UserPreferences systemBrowserClass
 "Modified: / 04-08-2011 / 21:39:51 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 "Modified: / 01-03-2012 / 08:50:20 / cg"
 !
-rationaleVisibleHolder:something
+rationaleVisibleHolder:aValueHolder
 "set the 'rationaleVisibleHolder' value holder (automatically generated)"
 |oldValue newValue|
 rationaleVisibleHolder notNil ifTrue:[
 oldValue := rationaleVisibleHolder value.
 rationaleVisibleHolder removeDependent:self.
 ].
-rationaleVisibleHolder := something.
+rationaleVisibleHolder := aValueHolder.
 rationaleVisibleHolder notNil ifTrue:[
 rationaleVisibleHolder addDependent:self.
 ].
 newValue := rationaleVisibleHolder value.
 oldValue ~~ newValue ifTrue:[
 ^ ruleHolder
 "Modified: / 01-03-2012 / 08:51:03 / cg"
 !
-ruleHolder:something
+ruleHolder:aValueHolder
 "set the 'ruleHolder' value holder (automatically generated)"
 |oldValue newValue|
 ruleHolder notNil ifTrue:[
 oldValue := ruleHolder value.
 ruleHolder removeDependent:self.
 ].
-ruleHolder := something.
+ruleHolder := aValueHolder.
 ruleHolder notNil ifTrue:[
 ruleHolder addDependent:self.
 ].
 newValue := ruleHolder value.
 oldValue ~~ newValue ifTrue:[
 |holder|
 (holder := builder bindingAt:#ruleRationaleAspect) isNil ifTrue:[
 "cannot use a BlockValue linked on the ruleHolder for the
-ruleRationaleAspect, because the ruleHolder maight be changed dynamically
+ruleRationaleAspect, because the ruleHolder might be changed dynamically
 via the aspect-linking mechanism"
 "/        holder := (AspectAdaptor forAspect: #rationale) subjectChannel: self ruleHolder.
 holder := '' asValue.
 builder aspectAt:#ruleRationaleAspect put:holder.
 ].
 "Modified: / 05-02-2010 / 12:51:42 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 "Modified: / 01-03-2012 / 15:29:16 / cg"
 !
+selectedClassesHolder
+"return/create the 'selectedClassesHolder' value holder (automatically generated)"
+selectedClassesHolder isNil ifTrue:[
+selectedClassesHolder := #() asValue.
+selectedClassesHolder addDependent:self.
+].
+^ selectedClassesHolder
+!
+selectedClassesHolder:aValueHolder
+"set the 'selectedClassesHolder' value holder (automatically generated)"
+|oldValue newValue|
+selectedClassesHolder notNil ifTrue:[
+oldValue := selectedClassesHolder value.
+selectedClassesHolder removeDependent:self.
+].
+selectedClassesHolder := aValueHolder.
+selectedClassesHolder notNil ifTrue:[
+selectedClassesHolder addDependent:self.
+].
+newValue := selectedClassesHolder value.
+oldValue ~= newValue ifTrue:[
+self update:#value with:newValue from:selectedClassesHolder.
+].
+!
 selectedMethodsHolder
 "return/create the 'selectedMethodsHolder' value holder (automatically generated)"
 selectedMethodsHolder isNil ifTrue:[
 selectedMethodsHolder := #() asValue.
 selectedMethodsHolder addDependent:self.
 ].
 ^ selectedMethodsHolder
 !
-selectedMethodsHolder:something
+selectedMethodsHolder:aValueHolder
 "set the 'selectedMethodsHolder' value holder (automatically generated)"
 |oldValue newValue|
 selectedMethodsHolder notNil ifTrue:[
 oldValue := selectedMethodsHolder value.
 selectedMethodsHolder removeDependent:self.
 ].
-selectedMethodsHolder := something.
+selectedMethodsHolder := aValueHolder.
 selectedMethodsHolder notNil ifTrue:[
 selectedMethodsHolder addDependent:self.
 ].
 newValue := selectedMethodsHolder value.
 oldValue ~= newValue ifTrue:[
 changedObject == rationaleVisibleHolder ifTrue:[
 self updateVisibility.
 ^ self.
 ].
 changedObject == selectedMethodsHolder ifTrue:[
-"/ cg: preparations to show method-specific text in rationale/detail
+"/ cg: preparations to show method-specific text in rationale/detail view
-"/ view. Not yet done...
+"/ Not yet done...
+self updateRule.
+^ self
+].
+changedObject == selectedClassesHolder ifTrue:[
+"/ cg: preparations to show class-specific text in rationale/detail view
+"/ Not yet done...
+self updateRule.
+^ self
 ].
 super update:something with:aParameter from:changedObject
 "Modified: / 04-08-2011 / 21:31:13 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 updateRule
 "cannot use a BlockValue linked on the ruleHolder for the
 ruleRationaleAspect, because the ruleHolder maight be changed dynamically
 via the aspect-linking mechanism"
-|rule|
+|rule text|
+text := ''.
 rule := self ruleHolder value.
-self ruleRationaleAspect value: (rule isNil ifTrue:[''] ifFalse:[rule rationaleWithAnchor]).
+rule notNil ifTrue:[
+selectedMethodsHolder value size == 1 ifTrue:[
+text := rule rationaleWithAnchorForMethod:(selectedMethodsHolder value first).
+] ifFalse:[
+selectedClassesHolder value size == 1 ifTrue:[
+text := rule rationaleWithAnchorForClass:(selectedClassesHolder value first).
+] ifFalse:[
+text := rule rationaleWithAnchor.
+]
+]
+].
+self ruleRationaleAspect value:text.
 "Created: / 01-03-2012 / 15:28:18 / cg"
 !
 updateVisibility

branch	jv
changeset 17379	028adf14bc05
parent 16571	cf319f2e56d0
parent 17297	78fd75347bc3