hg/stx-libtool: comparison AbstractSettingsApplication.st

equal deleted inserted replaced

-:bec660fe7335
+:31b4abe6811b
 		allowEmptyStatements warnAboutPossibleSTCCompilationProblems
 		warnAboutReferenceToPrivateClass warnAboutShortLocalVariableNames
 		warnAboutPossiblyUnimplementedSelectors
 		allowExtendedBinarySelectors warnAboutMissingMethodComment
 		allowAssignmentToPoolVariable warnPlausibilityChecks
-		allowParagraph enableParagraph'
+		allowParagraph enableParagraph
+		warnAboutPossiblyUninitializedLocals'
 	classVariableNames:''
 	poolDictionaries:''
 	privateIn:AbstractSettingsApplication
 !
 UIHelpTool openOnClass:AbstractSettingsApplication::ByteCodeCompilerSettingsAppl
 "
 <resource: #help>
-^ super helpSpec addPairsFrom: #(
+^ super helpSpec addPairsFrom:#(
-#arraysAreImmutable
-'Array and ByteArray literals are readonly objects, which cannot be modified.
-Prevents constant arrays as returned from a method to be modified elsewhere by accident'
-#fullDebugInfo
-'Include more debug support in the generated code.
-Especially restartability and returnability of methods in the debugger are improved'
-#stringsAreImmutable
-'String literals are readonly objects, which cannot be modified.
-Prevents constant strings as returned from a method to be modified elsewhere by accident'
 #allowAssignmentToPoolVariable
 'Pool variables should only be initialized in the pool itself and not modified elsewhere later.\This flag makes pool variables writable.\May be required to fileIn code from Squeak and other Smalltalk dialects'
 #allowDollarInIdentifier
 'Check this to allow dollar characters in identifiers.\This may be required to filein old code for VAX Smalltalk,\but is not compatible to most other Smalltalk dialects.'
+#allowDolphinExtensions
+'Allow Dolphin-Smalltalk specific syntax extensions'
+#allowEmptyStatements
+'Allow empty statements'
+#allowExtendedBinarySelectors
+'Allow extended binary selectors (more than 2 characters, including "^", "|" and "#")'
+#allowFixedPointLiterals
+'Allow <v>s<n> fixed point literals (scaled or fixed-point decimal v with n digits precision)'
+#allowOldStyleAssignment
+'Allow "_" as assignment. May be required to filein Squeak code'
 #allowParagraphInIdentifier
 'Check this to allow paragraph characters in identifiers.\This is not compatible to other Smalltalk dialects.'
-#allowDolphinExtensions
-'Allow Dolphin-Smalltalk specific syntax extensions'
-#allowEmptyStatements
-'Allow empty statements'
-#allowExtendedBinarySelectors
-'Allow extended binary selectors (more than 2 characters, including "^", "|" and "#")'
-#allowFixedPointLiterals
-'Allow <v>s<n> fixed point literals (scaled or fixed-point decimal v with n digits precision)'
-#allowOldStyleAssignment
-'Allow "_" as assignment. May be required to filein Squeak code'
 #allowQualifiedNames
 'Allow Visualworks qualified names.\This enables ''dot''-notation for namespace prefixes and the {..} qualified name syntax.\May be required to filein Visualworks code'
 #allowReservedWordsAsSelectors
 'Allow "self", "super" as selectors. May be required to filein code from other Smalltalk dialects'
 #allowVisualAgeESSymbolLiterals
 'Allow VisualAge ESsymbol literals (##xxx).\Will generate regular symbols when compiled'
 #allowVisualAgePrimitives
 'Allow VisualAge primitive specification syntax'
-"/
-"/#warnAboutPossibleSTCCompilationProblems
+#arraysAreImmutable
-"/''
+'Array and ByteArray literals are readonly objects, which cannot be modified. Prevents constant arrays as returned from a method to be modified elsewhere by accident'
-"/
+#fullDebugInfo
+'Include more debug support in the generated code. Especially restartability and returnability of methods in the debugger are improved'
+#reenableSuppressedWarnings
+'Reenable warnings which were previously suppressed for individual methods'
+#stringsAreImmutable
+'String literals are readonly objects, which cannot be modified. Prevents constant strings as returned from a method to be modified elsewhere by accident'
+#warnAboutBadComments
+'Warn if a comment is empty or consists of whitespace only'
+#warnAboutMissingMethodComment
+'Warn if a method has no comment'
+#warnAboutNonLowercaseLocalVariableNames
+'By convention, local variables should start with a lowercase character'
 #warnAboutPossiblyUnimplementedSelectors
 'Warn about a possibly unimplemented selector in a message send'
+#warnAboutPossiblyUninitializedLocals
+'Warn if a local variable might be uninitialized (nil) when used.\This might generate false warnings, if inside a block which is executed later,\after the variable gets a value assigned'
 #warnAboutReferenceToPrivateClass
 'Warn when another classes private class is referenced.\This is considered "bad style" and should be replaced by a getter-call to the owning class or the privae class be made public'
+#warnAboutShortLocalVariableNames
+'Warn if a variable''s name is too short to be descriptive'
+#warnAboutWrongVariableNames
+'Checks for bad articles in variable names (eg. "anUser")'
+#warnCommonMistakes
+'Warn about code which is likely to be mistaken, based on heuristics'
 #warnDollarInIdentifier
 'Warn if an identifier contains a dollar character.\This is not allowed in most other Smalltalk dialects.'
+#warnInconsistentReturnValues
+'Warn if a method returns both boolean and non-boolean values (usually a ^self)'
+#warnOldStyleAssignment
+'Warn if an old style assignment ("_" character) is used instead of the modern ":=".'
 #warnParagraphInIdentifier
 'Warn if an identifier contains a paragraph character.\This is not allowed in other Smalltalk dialects.'
-#warnOldStyleAssignment
-'Warn if an old style assignment ("_" character) is used instead of the modern ":=".'
 #warnPlausibilityChecks
 'Perform plausibility checks and warn about any such possible problem'
 #warnPossibleIncompatibilities
 'Warn about other possible incompatibilities'
-"/
 #warnSTXSpecials
 'Warn when ST/X special syntax is encountered.\Such constructs may be unportable to other Smalltalk dialects'
-"/
 #warnUnderscoreInIdentifier
 'Warn if an identifier contains an underline character.\This is not allowed in some old Smalltalk dialects.'
-#warnCommonMistakes
-'Warn about code which is likely to be mistaken, based on heuristics'
-#warnInconsistentReturnValues
-'Warn if a method returns both boolean and non-boolean values (usually a ^self)'
-#warnAboutMissingMethodComment
-'Warn if a method has no comment'
-#warnAboutBadComments
-'Warn if a comment is empty or consists of whitespace only'
-#warnAboutShortLocalVariableNames
-'Warn if a variable''s name is too short to be descriptive'
-#warnAboutNonLowercaseLocalVariableNames
-'By convention, local variables should start with a lowercase character'
-#warnAboutWrongVariableNames
-'Checks for bad articles in variable names (eg. "anUser")'
 #warnUnusedVars
 'Warn if a local variable is never used'
 #warnings
 'Turn off all warnings'
 )
-"Modified: / 28-02-2019 / 12:52:09 / Claus Gittinger"
+"Modified: / 23-04-2019 / 23:23:03 / Claus Gittinger"
 ! !
 !AbstractSettingsApplication::ByteCodeCompilerSettingsAppl class methodsFor:'image specs'!
 defaultIcon
 <resource: #canvas>
 ^
 #(FullSpec
 name: windowSpec
-uuid: '9c92d4c6-1f3f-11b2-903e-3065ec8abe8a'
+uuid: 'e0a1dd6e-660d-11e9-bfcd-b8f6b1108e05'
 window:
 (WindowSpec
 label: 'Byte Code Compiler Settings'
 name: 'Byte Code Compiler Settings'
 flags: 1
 uuid: '9c92dc14-1f3f-11b2-903e-3065ec8abe8a'
 min: (Point 10 10)
-bounds: (Rectangle 0 0 665 706)
+bounds: (Rectangle 0 0 664 712)
 )
 component:
 (SpecCollection
 collection: (
 (VerticalPanelViewSpec
 label: 'Just in Time Compilation to Machine Code'
 name: 'JustInTimeCompilation'
 uuid: '9c92e8da-1f3f-11b2-903e-3065ec8abe8a'
 model: justInTimeCompilation
 translateLabel: true
-extent: (Point 665 25)
+extent: (Point 664 25)
 )
 (DividerSpec
 name: 'Separator3'
 uuid: '9c92ed9e-1f3f-11b2-903e-3065ec8abe8a'
-extent: (Point 665 3)
+extent: (Point 664 3)
 )
 (ViewSpec
 name: 'Box1'
 uuid: '9c92f0aa-1f3f-11b2-903e-3065ec8abe8a'
 component:
 name: 'AllowUnderscoreInIdentifiers'
 activeHelpKey: allowUnderscoreInIdentifier
 uuid: '9c92f618-1f3f-11b2-903e-3065ec8abe8a'
 model: allowUnderscoreInIdentifier
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Allow Dollar in Identifiers ($)'
 name: 'AllowDollarInIdentifiers'
 activeHelpKey: allowDollarInIdentifier
 uuid: '9c92f8e8-1f3f-11b2-903e-3065ec8abe8a'
 model: allowDollarInIdentifier
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Allow VW3 QualifiedNames'
 name: 'AllowVW3QualifiedNames'
 activeHelpKey: allowQualifiedNames
 uuid: '9c92fb40-1f3f-11b2-903e-3065ec8abe8a'
 model: allowQualifiedNames
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Allow OldStyle Assignment (_)'
 name: 'AllowOldStyleAssignment'
 activeHelpKey: allowOldStyleAssignment
 uuid: '9c92fd7a-1f3f-11b2-903e-3065ec8abe8a'
 model: allowOldStyleAssignment
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Allow Reserved Words as Selector (self)'
 name: 'AllowReservedWordsAsSelector'
 activeHelpKey: allowReservedWordsAsSelectors
 uuid: '9c92ffaa-1f3f-11b2-903e-3065ec8abe8a'
 model: allowReservedWordsAsSelectors
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Allow Extended Binary Selectors'
 name: 'CheckBox4'
 activeHelpKey: allowExtendedBinarySelectors
 uuid: '9c9301e4-1f3f-11b2-903e-3065ec8abe8a'
 model: allowExtendedBinarySelectors
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Allow Assignment to Pool Variable'
 name: 'CheckBox6'
 activeHelpKey: allowAssignmentToPoolVariable
 uuid: '9c930450-1f3f-11b2-903e-3065ec8abe8a'
 model: allowAssignmentToPoolVariable
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 )
 )
 )
 )
 )
 )
 )
-extent: (Point 665 157)
+extent: (Point 664 157)
 )
 (DividerSpec
 name: 'Separator4'
 uuid: '9c931954-1f3f-11b2-903e-3065ec8abe8a'
-extent: (Point 665 1)
+extent: (Point 664 1)
 )
 (CheckBoxSpec
 label: 'Warnings'
 name: 'Warnings'
 activeHelpKey: warnings
 uuid: '9c931b7a-1f3f-11b2-903e-3065ec8abe8a'
 model: warnings
 translateLabel: true
-extent: (Point 665 22)
+extent: (Point 664 22)
 )
 (ViewSpec
 name: 'Box2'
 uuid: '9c931e36-1f3f-11b2-903e-3065ec8abe8a'
 component:
 activeHelpKey: warnSTXSpecials
 uuid: '9c9322be-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: warnings
 model: warnSTXSpecials
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Reference to Private Class'
 name: 'CheckBox1'
 activeHelpKey: warnAboutReferenceToPrivateClass
 uuid: '9c932534-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: warnings
 model: warnAboutReferenceToPrivateClass
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Underscores in Identifiers'
 name: 'UnderscoresInIdentifiers'
 activeHelpKey: warnUnderscoreInIdentifier
 uuid: '9c932778-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: enableUnderscore
 model: warnUnderscoreInIdentifier
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Dollars in Identifiers'
 name: 'DollarsInIdentifiers'
 activeHelpKey: warnDollarInIdentifier
 uuid: '9c9329b2-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: enableDollar
 model: warnDollarInIdentifier
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'OldStyle Assignment'
 name: 'OldStyleAssignment'
 activeHelpKey: warnOldStyleAssignment
 uuid: '9c932bec-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: warnings
 model: warnOldStyleAssignment
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Possible Incompatibilities'
 name: 'PossibleIncompatibilities'
 activeHelpKey: warnPossibleIncompatibilities
 uuid: '9c932e1c-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: warnings
 model: warnPossibleIncompatibilities
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Possible STC Compilation Problems'
 name: 'PossibleSTCCompilationProblems'
 activeHelpKey: warnAboutPossibleSTCCompilationProblems
 uuid: '9c933056-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: warnings
 model: warnAboutPossibleSTCCompilationProblems
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Possibly Unimplemented Selectors'
 name: 'CheckBox3'
 activeHelpKey: warnAboutPossiblyUnimplementedSelectors
 uuid: '9c93329a-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: warnings
 model: warnAboutPossiblyUnimplementedSelectors
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
 )
 (CheckBoxSpec
 label: 'Plausibility Checks'
 name: 'CheckBox7'
 activeHelpKey: warnPlausibilityChecks
 uuid: '9c9334ca-1f3f-11b2-903e-3065ec8abe8a'
 enableChannel: warnings
 model: warnPlausibilityChecks
 translateLabel: true
-extent: (Point 313 22)
+extent: (Point 312 22)
+)
+(CheckBoxSpec
+label: 'Possibly Uninitialized Locals'
+name: 'CheckBox12'
+activeHelpKey: warnAboutPossiblyUninitializedLocals
+uuid: '9c93329a-1f3f-11b2-903e-3065ec8abe8a'
+enableChannel: warnings
+model: warnAboutPossiblyUninitializedLocals
+translateLabel: true
+extent: (Point 312 22)
 )
 )
 )
 )
 )
 )
 )
 )
-extent: (Point 665 206)
+extent: (Point 664 224)
 )
 (ViewSpec
 name: 'Box4'
 uuid: '9c934f00-1f3f-11b2-903e-3065ec8abe8a'
 component:
 (SpecCollection
 collection: (
 (ActionButtonSpec
 label: 'Reenable Suppressed Warnings Now'
 name: 'Button1'
-layout: (LayoutOrigin 0 0.5 0 0)
+layout: (LayoutFrame 0 0.5 0 0 0 1 0 1)
+activeHelpKey: reenableSuppressedWarnings
 uuid: '9c93519e-1f3f-11b2-903e-3065ec8abe8a'
 translateLabel: true
 model: reenableSuppressedWarnings
 )
 )
 )
-extent: (Point 665 33)
+extent: (Point 664 33)
 )
 (DividerSpec
 name: 'Separator5'
 uuid: '9c9356ee-1f3f-11b2-903e-3065ec8abe8a'
-extent: (Point 665 2)
+extent: (Point 664 2)
 )
 (CheckBoxSpec
 label: 'Literal Strings are Immutable'
 name: 'LiteralStringsAreImmutable'
 activeHelpKey: stringsAreImmutable
 uuid: '9c935932-1f3f-11b2-903e-3065ec8abe8a'
 model: stringsAreImmutable
 translateLabel: true
-extent: (Point 665 22)
+extent: (Point 664 22)
 )
 (CheckBoxSpec
 label: 'Literal Arrays are Immutable'
 name: 'CheckBox9'
 activeHelpKey: arraysAreImmutable
 uuid: '9c935c02-1f3f-11b2-903e-3065ec8abe8a'
 model: arraysAreImmutable
 translateLabel: true
-extent: (Point 665 22)
+extent: (Point 664 22)
 )
 (CheckBoxSpec
 label: 'Full Debug Info'
 name: 'FullDebugInfo'
 activeHelpKey: fullDebugInfo
 uuid: '9c935ec8-1f3f-11b2-903e-3065ec8abe8a'
 model: fullDebugSupport
 translateLabel: true
-extent: (Point 665 22)
+extent: (Point 664 22)
 )
 (DividerSpec
 name: 'Separator6'
 uuid: '9c936170-1f3f-11b2-903e-3065ec8abe8a'
-extent: (Point 665 2)
+extent: (Point 664 2)
 )
 (ViewSpec
 name: 'Box3'
 uuid: '9c93636e-1f3f-11b2-903e-3065ec8abe8a'
 component:
 useIndex: true
 )
 )
 )
-extent: (Point 665 22)
+extent: (Point 664 22)
 )
 )
 )
 )
 warnAboutNonLowercaseLocalVariableNames
 warnAboutShortLocalVariableNames
 warnAboutPossibleSTCCompilationProblems
 warnAboutReferenceToPrivateClass
 warnAboutPossiblyUnimplementedSelectors
+warnAboutPossiblyUninitializedLocals
 warnPlausibilityChecks
 allowDollarInIdentifier
 allowParagraphInIdentifier
 allowDolphinExtensions
 allowAssignmentToPoolVariable
 )
 "Created: / 20-11-2006 / 22:37:17 / cg"
 "Modified: / 16-11-2016 / 22:40:51 / cg"
+"Modified: / 23-04-2019 / 23:16:47 / Claus Gittinger"
 !
 stcCompilerSettings
 AbstractLauncherApplication::LauncherDialogs stcCompilerSettings
 warnAboutPossiblyUnimplementedSelectors onChangeSend:#updateModifiedChannel to:self.
 ].
 ^ warnAboutPossiblyUnimplementedSelectors.
 "Created: / 20-11-2006 / 22:41:07 / cg"
+!
+warnAboutPossiblyUninitializedLocals
+warnAboutPossiblyUninitializedLocals isNil ifTrue:[
+warnAboutPossiblyUninitializedLocals := ParserFlags warnAboutPossiblyUninitializedLocals asValue.
+warnAboutPossiblyUninitializedLocals onChangeSend:#updateModifiedChannel to:self.
+].
+^ warnAboutPossiblyUninitializedLocals.
+"Created: / 23-04-2019 / 23:16:25 / Claus Gittinger"
 !
 warnAboutReferenceToPrivateClass
 warnAboutReferenceToPrivateClass isNil ifTrue:[
 warnAboutReferenceToPrivateClass := ParserFlags warnAboutReferenceToPrivateClass asValue.

changeset 18744	31b4abe6811b
parent 18743	bec660fe7335
child 18763	6a3d3a6ac24e