Tools__CodeHighlightingService.st
changeset 10961 5942259788db
parent 10954 ba2dc0bd7290
child 10968 5e738ee1cd2a
--- a/Tools__CodeHighlightingService.st	Sun Dec 04 22:43:09 2011 +0100
+++ b/Tools__CodeHighlightingService.st	Sun Dec 04 22:46:25 2011 +0100
@@ -146,6 +146,12 @@
 update: aspect with: param from: sender
     |thisIsACodeChange|
 
+    "JV@2011-12-04: I don't really see the point why the code was changed
+    (see differences between 1.25 and 1.26). However, the change did not
+    preserve the semantics, as the #codeChanged: is sent only iff
+    languageHolder or classHolder change (in r1.26). This is not enough.
+    Consequently, Ctrl-click navigation no longer worked."
+
     thisIsACodeChange := false.
 
     textView notNil ifTrue:[
@@ -154,8 +160,9 @@
                              or:[ (sender == textView and:[aspect == #sizeOfContents]) ].
     ].
     codeView notNil ifTrue:[
-        thisIsACodeChange := (sender == codeView languageHolder)
-                             or:[ sender == codeView classHolder ]
+        "JV@2011-12-04:            v------------ therefore this change"
+        thisIsACodeChange := thisIsACodeChange or: [(sender == codeView languageHolder)
+                             or:[ sender == codeView classHolder ]]
     ].
     thisIsACodeChange ifTrue:[
         self codeChanged: true. 
@@ -164,8 +171,8 @@
     super update: aspect with: param from: sender
 
     "Created: / 06-03-2010 / 19:38:07 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-    "Modified: / 16-09-2011 / 17:30:16 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified (format): / 03-12-2011 / 10:31:37 / cg"
+    "Modified (format): / 04-12-2011 / 22:44:40 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 ! !
 
 !CodeHighlightingService methodsFor:'event handling'!
@@ -449,11 +456,11 @@
 !CodeHighlightingService class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__CodeHighlightingService.st,v 1.26 2011-12-04 14:52:31 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__CodeHighlightingService.st,v 1.27 2011-12-04 21:46:25 vrany Exp $'
 !
 
 version_CVS
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__CodeHighlightingService.st,v 1.26 2011-12-04 14:52:31 cg Exp $'
+    ^ '$Header: /cvs/stx/stx/libtool/Tools__CodeHighlightingService.st,v 1.27 2011-12-04 21:46:25 vrany Exp $'
 !
 
 version_SVN