--- a/Tools_ClassChecker.st Mon Mar 06 09:53:24 2006 +0100
+++ b/Tools_ClassChecker.st Mon Mar 06 09:53:33 2006 +0100
@@ -146,20 +146,20 @@
checkVariableNameConventions
|badInstVars badClassVars|
- badInstVars := checkedClass instanceVariableNames select:[:varName | varName first isUppercase].
+ badInstVars := checkedClass instanceVariableNames select:[:varName | varName isUppercaseFirst].
badClassVars := checkedClass classVarNames select:[:varName | varName first isLowercase].
badInstVars notEmpty ifTrue:[
- badInstVars := (badInstVars collect:[:v | '''' , v , '''']) asStringWith:$, .
- self
- rememberBadClass:checkedClass
- info:('instVars ' , badInstVars , ' should be lowercase (#checkNameConventions)').
+ badInstVars := (badInstVars collect:[:v | '''' , v , '''']) asStringWith:$, .
+ self
+ rememberBadClass:checkedClass
+ info:('instVars ' , badInstVars , ' should be lowercase (#checkNameConventions)').
].
badClassVars notEmpty ifTrue:[
- badClassVars := (badClassVars collect:[:v | '''' , v , '''']) asStringWith:$, .
- self
- rememberBadClass:checkedClass
- info:('classVars ' , badClassVars , ' should be uppercase (#checkNameConventions)').
+ badClassVars := (badClassVars collect:[:v | '''' , v , '''']) asStringWith:$, .
+ self
+ rememberBadClass:checkedClass
+ info:('classVars ' , badClassVars , ' should be uppercase (#checkNameConventions)').
].
!
@@ -474,10 +474,8 @@
!
anyImplementationOf:aSelector in:aCollectionOfClasses
- aCollectionOfClasses do:[:eachClass |
- (eachClass includesSelector:aSelector) ifTrue:[^ true].
- ].
- ^ false
+ ^ aCollectionOfClasses
+ contains:[:aClass | (aClass includesSelector:aSelector) ].
!
anyImplementationOf:aSelector inOrAbove:aClass
@@ -795,5 +793,5 @@
!ClassChecker class methodsFor:'documentation'!
version
- ^ '$Header: /cvs/stx/stx/libtool/Tools_ClassChecker.st,v 1.6 2006-02-10 16:12:22 cg Exp $'
+ ^ '$Header: /cvs/stx/stx/libtool/Tools_ClassChecker.st,v 1.7 2006-03-06 08:53:33 cg Exp $'
! !