Mercurial Mercurial > hg > stx-libtool / diff
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
AbstractSettingsApplication.st
changeset 19495 f95054ef3c84
parent 19494 a6253a3d0a45
child 19496 f62806e748d4 
--- a/AbstractSettingsApplication.st	Fri Feb 21 14:59:29 2020 +0100
+++ b/AbstractSettingsApplication.st	Fri Feb 21 15:06:40 2020 +0100
@@ -8367,17 +8367,17 @@
         readAspects:(self aspectsInObjectMemory)
         from:ObjectMemory.
 
-    self igcLimit value:ObjectMemory incrementalGCLimit.
-    self igcFreeLimit value:ObjectMemory freeSpaceGCLimit.
-    self igcFreeAmount value:ObjectMemory freeSpaceGCAmount.
-    self oldIncr value:ObjectMemory oldSpaceIncrement.
-    self compressLimit value:ObjectMemory oldSpaceCompressLimit.
-    self codeLimit value:ObjectMemory dynamicCodeLimit.
-    self codeTrigger value:ObjectMemory dynamicCodeGCTrigger.
-    self methodCodeSizeLimit value:(ObjectMemory codeSizeLimitForDynamicCompilation:-1).
-    self fastMoreLimit value:(ObjectMemory fastMoreOldSpaceLimit:-1).
-
-    self stackLimit value:Process defaultMaximumStackSize.
+    igcLimit value:ObjectMemory incrementalGCLimit.
+    igcFreeLimit value:ObjectMemory freeSpaceGCLimit.
+    igcFreeAmount value:ObjectMemory freeSpaceGCAmount.
+    oldIncr value:ObjectMemory oldSpaceIncrement.
+    compressLimit value:ObjectMemory oldSpaceCompressLimit.
+    codeLimit value:ObjectMemory dynamicCodeLimit.
+    codeTrigger value:ObjectMemory dynamicCodeGCTrigger.
+    methodCodeSizeLimit value:(ObjectMemory codeSizeLimitForDynamicCompilation:-1).
+    fastMoreLimit value:(ObjectMemory fastMoreOldSpaceLimit:-1).
+
+    stackLimit value:Process defaultMaximumStackSize.
 
     "Modified: / 12-08-2010 / 15:34:24 / cg"
 !
@@ -8387,17 +8387,17 @@
         writeAspects:(self aspectsInObjectMemory)
         to:ObjectMemory.
 
-    ObjectMemory freeSpaceGCAmount:self igcFreeAmount value.
-    ObjectMemory freeSpaceGCLimit:self igcFreeLimit value.
-    ObjectMemory incrementalGCLimit:self igcLimit value.
-    ObjectMemory oldSpaceIncrement:self oldIncr value.
-    ObjectMemory fastMoreOldSpaceLimit:self fastMoreLimit value.
-    ObjectMemory oldSpaceCompressLimit:self compressLimit value.
-    ObjectMemory dynamicCodeLimit:self codeLimit value.
-    ObjectMemory dynamicCodeGCTrigger:self codeTrigger value.
-    ObjectMemory codeSizeLimitForDynamicCompilation:(self methodCodeSizeLimit value).
-
-    Process defaultMaximumStackSize:self stackLimit value.
+    ObjectMemory freeSpaceGCAmount:igcFreeAmount value.
+    ObjectMemory freeSpaceGCLimit:igcFreeLimit value.
+    ObjectMemory incrementalGCLimit:igcLimit value.
+    ObjectMemory oldSpaceIncrement:oldIncr value.
+    ObjectMemory fastMoreOldSpaceLimit:fastMoreLimit value.
+    ObjectMemory oldSpaceCompressLimit:compressLimit value.
+    ObjectMemory dynamicCodeLimit:codeLimit value.
+    ObjectMemory dynamicCodeGCTrigger:codeTrigger value.
+    ObjectMemory codeSizeLimitForDynamicCompilation:(methodCodeSizeLimit value).
+
+    Process defaultMaximumStackSize:stackLimit value.
 
     "Modified: / 12-08-2010 / 15:34:47 / cg"
 ! !
@@ -8412,125 +8412,56 @@
 !
 
 codeLimit
-
-    codeLimit isNil ifTrue:[
-        codeLimit := ObjectMemory dynamicCodeLimit asValue.
-        codeLimit onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ codeLimit.
 !
 
 codeTrigger
-
-    codeTrigger isNil ifTrue:[
-        codeTrigger := ObjectMemory dynamicCodeGCTrigger asValue.
-        codeTrigger onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ codeTrigger.
 !
 
 compressLimit
-
-    compressLimit isNil ifTrue:[
-        compressLimit := ObjectMemory oldSpaceCompressLimit asValue.
-        compressLimit onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ compressLimit.
 !
 
 fastMoreLimit
-
-    fastMoreLimit isNil ifTrue:[
-        fastMoreLimit := (ObjectMemory fastMoreOldSpaceLimit:-1) asValue.
-        fastMoreLimit onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ fastMoreLimit.
 !
 
 igcFreeAmount
-
-    igcFreeAmount isNil ifTrue:[
-        igcFreeAmount := ObjectMemory freeSpaceGCAmount asValue.
-        igcFreeAmount onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ igcFreeAmount.
 !
 
 igcFreeLimit
-
-    igcFreeLimit isNil ifTrue:[
-        igcFreeLimit := ObjectMemory freeSpaceGCLimit asValue.
-        igcFreeLimit onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ igcFreeLimit.
 !
 
 igcLimit
-
-    igcLimit isNil ifTrue:[
-        igcLimit := ObjectMemory incrementalGCLimit asValue.
-        igcLimit onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ igcLimit.
 !
 
 maxOldSpace
-
-    maxOldSpace isNil ifTrue:[
-        maxOldSpace := ObjectMemory maxOldSpace asValue.
-        maxOldSpace onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ maxOldSpace.
 !
 
 methodCodeSizeLimit
-
-    methodCodeSizeLimit isNil ifTrue:[
-        methodCodeSizeLimit := (ObjectMemory codeSizeLimitForDynamicCompilation:-1) asValue.
-        methodCodeSizeLimit onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ methodCodeSizeLimit.
 
     "Created: / 12-08-2010 / 15:31:56 / cg"
 !
 
 newSpaceSize
-
-    newSpaceSize isNil ifTrue:[
-        newSpaceSize := ObjectMemory newSpaceSize asValue.
-        newSpaceSize onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ newSpaceSize.
 !
 
 oldIncr
-
-    oldIncr isNil ifTrue:[
-        oldIncr := ObjectMemory oldSpaceIncrement asValue.
-        oldIncr onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ oldIncr.
 !
 
 stackLimit
-
-    stackLimit isNil ifTrue:[
-        stackLimit := Process defaultMaximumStackSize asValue.
-        stackLimit onChangeSend:#updateModifiedChannel to:self
-    ].
     ^ stackLimit.
 !
 
-supportsJustInTimeCompilation
-
-    ^ ObjectMemory supportsJustInTimeCompilation.
-!
-
 warningLabelHolder
-
-    warningLabelHolder isNil ifTrue:[
-        warningLabelHolder := ValueHolder new.
-    ].
     ^ warningLabelHolder.
 ! !
 
@@ -8546,13 +8477,51 @@
     <modifier: #super> "must be called if redefined"
 
     super initialize.
-    self warningLabelHolder
-        value:(StringCollection
+
+    codeLimit := ValueHolder with:(ObjectMemory dynamicCodeLimit).
+    codeLimit onChangeSend:#updateModifiedChannel to:self.
+
+    codeTrigger := ValueHolder with:(ObjectMemory dynamicCodeGCTrigger).
+    codeTrigger onChangeSend:#updateModifiedChannel to:self.
+
+    compressLimit := ValueHolder with:(ObjectMemory oldSpaceCompressLimit).
+    compressLimit onChangeSend:#updateModifiedChannel to:self.
+
+    fastMoreLimit := ValueHolder with:(ObjectMemory fastMoreOldSpaceLimit:-1).
+    fastMoreLimit onChangeSend:#updateModifiedChannel to:self.
+
+    igcFreeAmount := ValueHolder with:(ObjectMemory freeSpaceGCAmount).
+    igcFreeAmount onChangeSend:#updateModifiedChannel to:self.
+
+    igcFreeLimit := ValueHolder with:(ObjectMemory freeSpaceGCLimit).
+    igcFreeLimit onChangeSend:#updateModifiedChannel to:self. 
+
+    igcLimit := ValueHolder with:(ObjectMemory incrementalGCLimit).
+    igcLimit onChangeSend:#updateModifiedChannel to:self.
+
+    maxOldSpace := ValueHolder with:(ObjectMemory maxOldSpace).
+    maxOldSpace onChangeSend:#updateModifiedChannel to:self.
+
+    methodCodeSizeLimit := ValueHolder with:(ObjectMemory codeSizeLimitForDynamicCompilation:-1).
+    methodCodeSizeLimit onChangeSend:#updateModifiedChannel to:self.
+
+    newSpaceSize := ValueHolder with:(ObjectMemory newSpaceSize).
+    newSpaceSize onChangeSend:#updateModifiedChannel to:self.
+
+    oldIncr := ValueHolder with:(ObjectMemory oldSpaceIncrement).
+    oldIncr onChangeSend:#updateModifiedChannel to:self.
+
+    stackLimit := ValueHolder with:(Process defaultMaximumStackSize).
+    stackLimit onChangeSend:#updateModifiedChannel to:self.
+
+    warningLabelHolder := 
+        ValueHolder with:
+            (StringCollection
                 with:(resources string:'Warning - invalid settings may result in failures or poor performance.')
                 with:(resources string:'You have been warned.') allBold
                ).
 
-    "Modified: / 08-02-2017 / 00:30:20 / cg"
+   "Modified: / 08-02-2017 / 00:30:20 / cg"
 ! !
 
 !AbstractSettingsApplication::MemorySettingsAppl methodsFor:'queries'!
@@ -8562,20 +8531,25 @@
         hasChangedAspectIn:(self aspectsInObjectMemory)
         asComparedTo:ObjectMemory) ifTrue:[^ true].
 
-    ObjectMemory freeSpaceGCAmount ~= self igcFreeAmount value ifTrue:[^ true].
-    ObjectMemory freeSpaceGCLimit ~= self igcFreeLimit value ifTrue:[^ true].
-    ObjectMemory incrementalGCLimit ~= self igcLimit value ifTrue:[^ true].
-    ObjectMemory oldSpaceIncrement ~= self oldIncr value ifTrue:[^ true].
-    (ObjectMemory fastMoreOldSpaceLimit:-1) ~= self fastMoreLimit value ifTrue:[^ true].
-    ObjectMemory oldSpaceCompressLimit ~= self compressLimit value ifTrue:[^ true].
-    ObjectMemory dynamicCodeLimit ~= self codeLimit value ifTrue:[^ true].
-    ObjectMemory dynamicCodeGCTrigger ~= self codeTrigger value ifTrue:[^ true].
-    (ObjectMemory codeSizeLimitForDynamicCompilation:-1) ~= self methodCodeSizeLimit value ifTrue:[^ true].
-
-    Process defaultMaximumStackSize ~= self stackLimit value ifTrue:[^ true].
+    ObjectMemory freeSpaceGCAmount ~= igcFreeAmount value ifTrue:[^ true].
+    ObjectMemory freeSpaceGCLimit ~= igcFreeLimit value ifTrue:[^ true].
+    ObjectMemory incrementalGCLimit ~= igcLimit value ifTrue:[^ true].
+    ObjectMemory oldSpaceIncrement ~= oldIncr value ifTrue:[^ true].
+    (ObjectMemory fastMoreOldSpaceLimit:-1) ~= fastMoreLimit value ifTrue:[^ true].
+    ObjectMemory oldSpaceCompressLimit ~= compressLimit value ifTrue:[^ true].
+    ObjectMemory dynamicCodeLimit ~= codeLimit value ifTrue:[^ true].
+    ObjectMemory dynamicCodeGCTrigger ~= codeTrigger value ifTrue:[^ true].
+    (ObjectMemory codeSizeLimitForDynamicCompilation:-1) ~= methodCodeSizeLimit value ifTrue:[^ true].
+
+    Process defaultMaximumStackSize ~= stackLimit value ifTrue:[^ true].
     ^ false
 
     "Modified: / 12-08-2010 / 15:33:12 / cg"
+!
+
+supportsJustInTimeCompilation
+
+    ^ ObjectMemory supportsJustInTimeCompilation.
 ! !
 
 !AbstractSettingsApplication::MiscBridgeCommunicationSettingsAppl class methodsFor:'help specs'!
hg/stx-libtool