Mercurial Mercurial > hg > stx-libtool / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Issue #78: Fix in MethodList>>listEntryForMethod: to show test pass/fail icon for Java testcases jv
authorJan Vrany <jan.vrany@fit.cvut.cz>
Wed, 27 Jul 2016 00:11:27 +0100
branchjv
changeset 16770 876fd5497347
parent 16769 84f3913dda79
child 16771 2ac796f68a7b
Issue #78: Fix in MethodList>>listEntryForMethod: to show test pass/fail icon for Java testcases This was due to improper test whether the class is a testcase or not. It used to test `isKindOf: TestCase` but proper test is `isTestCaseLike` which works well for alien (Java) testcases. https://swing.fit.cvut.cz/projects/stx-libjava/ticket/78
Tools__MethodList.st file | annotate | diff | comparison | revisions 
--- a/Tools__MethodList.st	Wed Jul 27 00:03:45 2016 +0100
+++ b/Tools__MethodList.st	Wed Jul 27 00:11:27 2016 +0100
@@ -1727,7 +1727,7 @@
     ].
     icn isNil ifTrue:[
         "/ (selector isSymbol and:[selector startsWith:'test']) ifTrue:[
-        (((cls isSubclassOf:TestCase) and:[cls isAbstract not])
+        (((cls isTestCaseLike) and:[cls isAbstract not])
         or:[self showSyntheticMethods value and:[aMethod isSynthetic]]) ifTrue:[
             (cls isTestCaseLike and:[cls isTestSelector:selector]) ifTrue:[
                 "JV@2011-11-17: Show thumbs even if not all test were run"
@@ -1852,7 +1852,7 @@
     "Created: / 22-10-1996 / 19:51:00 / cg"
     "Modified: / 15-08-2009 / 13:13:32 / Jan Vrany <vranyj1@fel.cvut.cz>"
     "Modified: / 07-03-2012 / 19:06:09 / cg"
-    "Modified: / 26-07-2016 / 23:33:36 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 27-07-2016 / 00:05:45 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
 resourceIconForMethod:aMethod
hg/stx-libtool