- Tools::ChangeList jv
authorJan Vrany <jan.vrany@fit.cvut.cz>
Wed, 25 Jul 2012 15:51:05 +0100
branchjv
changeset 12266 a1d70a191934
parent 12265 f1b3696cf042
child 12267 192a107e26b9
- Tools::ChangeList changed: #makeGenerator #updateList - Tools::ChangeSetBrowser2 added: #doOpenOnSelection changed: #mainMenu
Tools__ChangeList.st
Tools__ChangeSetBrowser2.st
--- a/Tools__ChangeList.st	Wed Jul 25 10:51:30 2012 +0100
+++ b/Tools__ChangeList.st	Wed Jul 25 15:51:05 2012 +0100
@@ -657,12 +657,13 @@
         [:whatToDo|
         selectionHolder value do:
             [:changeListItem| | change |
-            change := changeListItem change.
-            change isCompositeChange ifTrue:
-                [change changes do: whatToDo]]].
+            changeListItem notNil ifTrue:[
+                change := changeListItem change.
+                change isCompositeChange ifTrue:
+                    [change changes do: whatToDo]]]]
 
     "Modified: / 24-07-2009 / 23:00:41 / Jan Vrany <vranyj1@fel.cvut.cz>"
-    "Modified: / 24-10-2009 / 20:00:01 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 25-07-2012 / 15:39:52 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 ! !
 
 !ChangeList methodsFor:'hooks'!
@@ -903,7 +904,9 @@
 
     inGenerator := self inGeneratorHolder value.
     listView notNil ifTrue:[
-        firstLineShown := listView  yVisibleToLineNr:1.
+        ((listView isKindOf: ScrollableView) not or:[listView scrolledView notNil]) ifTrue:[
+            firstLineShown := listView yVisibleToLineNr:1.
+        ].
     ].
     oldSel := self selection.
 
@@ -937,7 +940,7 @@
     ]
 
     "Modified: / 28-12-2011 / 15:46:15 / cg"
-    "Modified: / 17-05-2012 / 23:27:09 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+    "Modified: / 25-07-2012 / 15:18:44 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 ! !
 
 !ChangeList methodsFor:'queries'!
@@ -1196,7 +1199,7 @@
 !ChangeList class methodsFor:'documentation'!
 
 version
-    ^ '$Id: Tools__ChangeList.st 8002 2012-05-18 18:08:31Z vranyj1 $'
+    ^ '$Id: Tools__ChangeList.st 8023 2012-07-25 14:51:05Z vranyj1 $'
 !
 
 version_CVS
@@ -1204,5 +1207,5 @@
 !
 
 version_SVN
-    ^ '$Id: Tools__ChangeList.st 8002 2012-05-18 18:08:31Z vranyj1 $'
+    ^ '$Id: Tools__ChangeList.st 8023 2012-07-25 14:51:05Z vranyj1 $'
 ! !
--- a/Tools__ChangeSetBrowser2.st	Wed Jul 25 10:51:30 2012 +0100
+++ b/Tools__ChangeSetBrowser2.st	Wed Jul 25 15:51:05 2012 +0100
@@ -1391,6 +1391,13 @@
                 )
                (MenuItem
                   enabled: isWorkingNotHolder
+                  label: 'Open on Selection'
+                  itemValue: doOpenOnSelection
+                  translateLabel: true
+                  isVisible: allowOpenHolder
+                )
+               (MenuItem
+                  enabled: isWorkingNotHolder
                   label: 'Save'
                   itemValue: doSave
                   translateLabel: true
@@ -2231,9 +2238,7 @@
 
     "Created: / 07-09-2011 / 15:54:03 / cg"
     "Created: / 11-02-2012 / 22:40:27 / Jan Vrany <jan.vrany@fit.cvut.cz>"
-!
-
- !
+! !
 
 !ChangeSetBrowser2 methodsFor:'aspects-queries'!
 
@@ -2436,6 +2441,17 @@
     "Created: / 09-02-2012 / 19:11:58 / Jan Vrany <jan.vrany@fit.cvut.cz>"
 !
 
+doOpenOnSelection
+
+    | selection |
+
+    selection := ChangeSet new.
+    self selectionDo: [:each|selection add: each].
+    self class openOn: selection label: (self titleHolder value , ' ' , (resources string:'(Selected changes)'))
+
+    "Modified: / 25-07-2012 / 15:31:50 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+!
+
 doSave
 
     changesetFile
@@ -3472,7 +3488,7 @@
 !ChangeSetBrowser2 class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libtool/Tools__ChangeSetBrowser2.st,v 1.35 2012/07/23 11:15:10 cg Exp $'
+    ^ '$Id: Tools__ChangeSetBrowser2.st 8023 2012-07-25 14:51:05Z vranyj1 $'
 !
 
 version_CVS
@@ -3480,5 +3496,5 @@
 !
 
 version_SVN
-    ^ '$Id: Tools__ChangeSetBrowser2.st 8022 2012-07-25 09:51:30Z vranyj1 $'
+    ^ '$Id: Tools__ChangeSetBrowser2.st 8023 2012-07-25 14:51:05Z vranyj1 $'
 ! !