Do now allow ruleset editing in ruleset selection dialog.
For new ruleset, one have to go an configure new ruleset in settings dalog.
--- a/Tools__LintRuleSelectionDialog.st Thu Oct 09 00:55:59 2014 +0200
+++ b/Tools__LintRuleSelectionDialog.st Thu Oct 09 00:58:27 2014 +0200
@@ -116,123 +116,129 @@
<resource: #canvas>
^
- #(FullSpec
- name: windowSpec
- window:
- (WindowSpec
- label: 'Select Lint Rules'
- name: 'Select Lint Rules'
- min: (Point 10 10)
- bounds: (Rectangle 0 0 600 400)
- )
- component:
- (SpecCollection
- collection: (
- (ComboListSpec
- name: 'ComboBox1'
- layout: (LayoutFrame 0 0 0 0 0 1 25 0)
- model: rulesetNameHolder
- acceptOnPointerLeave: false
- comboList: rulesetNameList
- )
- (VariableVerticalPanelSpec
- name: 'VariableVerticalPanel1'
- layout: (LayoutFrame 0 0 30 0 0 1 -30 1)
- component:
- (SpecCollection
- collection: (
- (SubCanvasSpec
- name: 'RuleList'
- hasHorizontalScrollBar: false
- hasVerticalScrollBar: false
- majorKey: #'Tools::HierarchicalLintRuleList'
- subAspectHolders:
- (Array
-
- (SubChannelInfoSpec
- subAspect: inGeneratorHolder
- aspect: allRulesHolder
- )
- (SubChannelInfoSpec
- subAspect: listSelection
- aspect: listSelection
- )
-
- (SubChannelInfoSpec
- subAspect: modeHolder
- aspect: modeHolder
- )
- (SubChannelInfoSpec
- subAspect: outGeneratorHolder
- aspect: selectedRulesHolder
- )
-
- (SubChannelInfoSpec
- subAspect: selectionHolder
- aspect: selectionHolder
- )
- )
- createNewApplication: true
- createNewBuilder: true
- )
- (SubCanvasSpec
- name: 'RuleDesc'
- hasHorizontalScrollBar: false
- hasVerticalScrollBar: false
- majorKey: #'Tools::LintRuleDetail'
- subAspectHolders:
- (Array
-
- (SubChannelInfoSpec
- subAspect: ruleHolder
- aspect: listSelection
- )
- )
- createNewApplication: true
- createNewBuilder: true
- )
+ #(FullSpec
+ name: windowSpec
+ window:
+ (WindowSpec
+ label: 'Select Lint Rules'
+ name: 'Select Lint Rules'
+ min: (Point 10 10)
+ bounds: (Rectangle 0 0 600 400)
+ )
+ component:
+ (SpecCollection
+ collection: (
+ (ComboListSpec
+ name: 'ComboBox1'
+ layout: (LayoutFrame 0 0 0 0 0 1 25 0)
+ model: rulesetNameHolder
+ comboList: rulesetNameList
+ )
+ (VariableVerticalPanelSpec
+ name: 'VariableVerticalPanel1'
+ layout: (LayoutFrame 0 0 60 0 0 1 -30 1)
+ component:
+ (SpecCollection
+ collection: (
+ (SubCanvasSpec
+ name: 'RuleList'
+ hasHorizontalScrollBar: false
+ hasVerticalScrollBar: false
+ majorKey: #'Tools::HierarchicalLintRuleList'
+ subAspectHolders:
+ (Array
+
+ (SubChannelInfoSpec
+ subAspect: inGeneratorHolder
+ aspect: allRulesHolder
+ )
+ (SubChannelInfoSpec
+ subAspect: listSelection
+ aspect: listSelection
+ )
+
+ (SubChannelInfoSpec
+ subAspect: modeHolder
+ aspect: modeHolder
+ )
+ (SubChannelInfoSpec
+ subAspect: outGeneratorHolder
+ aspect: selectedRulesHolder
+ )
+
+ (SubChannelInfoSpec
+ subAspect: selectionHolder
+ aspect: selectionHolder
+ )
+ )
+ createNewApplication: true
+ createNewBuilder: true
)
-
- )
- handles: (Any 0.808108108108108 1.0)
- )
- (HorizontalPanelViewSpec
- name: 'BottonPanel'
- layout: (LayoutFrame 0 0 -30 1 0 1 0 1)
- horizontalLayout: fitSpace
- verticalLayout: center
- horizontalSpace: 3
- verticalSpace: 3
- reverseOrderIfOKAtLeft: true
- component:
- (SpecCollection
- collection: (
- (ActionButtonSpec
- label: 'Cancel'
- name: 'CancelButton'
- translateLabel: true
- model: doCancel
- extent: (Point 295 22)
- )
- (ActionButtonSpec
- label: 'OK'
- name: 'OKButton'
- translateLabel: true
- model: doAccept
- isDefault: true
- defaultable: true
- extent: (Point 296 22)
- )
+ (SubCanvasSpec
+ name: 'RuleDesc'
+ hasHorizontalScrollBar: false
+ hasVerticalScrollBar: false
+ majorKey: #'Tools::LintRuleDetail'
+ subAspectHolders:
+ (Array
+
+ (SubChannelInfoSpec
+ subAspect: ruleHolder
+ aspect: listSelection
+ )
+ )
+ createNewApplication: true
+ createNewBuilder: true
)
-
- )
- )
+ )
+
+ )
+ handles: (Any 0.80810810810810796 1.0)
)
-
- )
- )
-
- "Modified: / 27-02-2013 / 23:23:58 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+ (HorizontalPanelViewSpec
+ name: 'BottonPanel'
+ layout: (LayoutFrame 0 0 -30 1 0 1 0 1)
+ horizontalLayout: fitSpace
+ verticalLayout: center
+ horizontalSpace: 3
+ verticalSpace: 3
+ reverseOrderIfOKAtLeft: true
+ component:
+ (SpecCollection
+ collection: (
+ (ActionButtonSpec
+ label: 'Cancel'
+ name: 'CancelButton'
+ translateLabel: true
+ model: doCancel
+ extent: (Point 295 22)
+ )
+ (ActionButtonSpec
+ label: 'OK'
+ name: 'OKButton'
+ translateLabel: true
+ model: doAccept
+ isDefault: true
+ defaultable: true
+ extent: (Point 296 22)
+ )
+ )
+
+ )
+ )
+ (LinkButtonSpec
+ label: 'Configure Rule Sets...'
+ name: 'Button1'
+ layout: (LayoutFrame 0 0 26 0 0 1 50 0)
+ translateLabel: true
+ labelChannel: configureRulesetsButtonLabel
+ adjust: right
+ model: doConfigureRulesets
+ )
+ )
+
+ )
+ )
! !
!LintRuleSelectionDialog methodsFor:'accessing'!
@@ -268,6 +274,14 @@
!LintRuleSelectionDialog methodsFor:'actions'!
+doConfigureRulesets
+ "raise an error: this method should be implemented (TODO)"
+
+ ^AbstractLauncherApplication openSettingsAndSelect: 'Tools/SmallLint'
+
+ "Created: / 08-10-2014 / 23:10:50 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+!
+
hideResultView
detailsShown == true ifFalse:[^self].
@@ -305,6 +319,15 @@
"Created: / 15-04-2010 / 20:09:09 / Jan Vrany <jan.vrany@fit.cvut.cz>"
!
+configureRulesetsButtonLabel
+ ^'Configure Rule Sets...' asText
+ colorizeAllWith: Color blue;
+ actionForAll:[ self doConfigureRulesets ];
+ yourself
+
+ "Created: / 08-10-2014 / 23:10:27 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+!
+
listSelection
"return/create the 'listSelection' value holder (automatically generated)"
@@ -322,9 +345,10 @@
modeHolder
- ^[#select]
+ ^[#displaySelection]
"Created: / 15-04-2010 / 20:13:51 / Jan Vrany <jan.vrany@fit.cvut.cz>"
+ "Modified: / 08-10-2014 / 22:56:41 / Jan Vrany <jan.vrany@fit.cvut.cz>"
!
rulesetHolder
@@ -520,14 +544,14 @@
!LintRuleSelectionDialog class methodsFor:'documentation'!
version
- ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSelectionDialog.st,v 1.6 2014-02-05 19:08:58 cg Exp $'
+ ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSelectionDialog.st,v 1.7 2014-10-08 22:58:27 vrany Exp $'
!
version_CVS
- ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSelectionDialog.st,v 1.6 2014-02-05 19:08:58 cg Exp $'
+ ^ '$Header: /cvs/stx/stx/libtool/Tools__LintRuleSelectionDialog.st,v 1.7 2014-10-08 22:58:27 vrany Exp $'
!
version_SVN
- ^ '$Id: Tools__LintRuleSelectionDialog.st,v 1.6 2014-02-05 19:08:58 cg Exp $'
+ ^ '$Id: Tools__LintRuleSelectionDialog.st,v 1.7 2014-10-08 22:58:27 vrany Exp $'
! !