- LintHighlighter: do no highlight broken rules (rules that report whole method) jv
authorJan Vrany <jan.vrany@fit.cvut.cz>
Fri, 07 Sep 2012 12:37:19 +0100
branchjv
changeset 12286 f5753909bad9
parent 12285 fde24c8622d4
child 12287 400a99059170
- LintHighlighter: do no highlight broken rules (rules that report whole method)
Tools__LintHighlighter.st
--- a/Tools__LintHighlighter.st	Thu Sep 06 17:38:47 2012 +0100
+++ b/Tools__LintHighlighter.st	Fri Sep 07 12:37:19 2012 +0100
@@ -197,8 +197,14 @@
     rule result isParseTreeEnvironment ifTrue:[
         formattingMethod ifTrue:[
             rule result selectionIntervalsForSource: string tree: tree do: [:interval|
-                interval notNil ifTrue:[
-                    self mark: text from: interval first to: interval last for: rule.
+                interval notEmptyOrNil ifTrue:[
+                    (interval first == 1 and:[interval last == text size]) ifTrue:[
+                        (OperatingSystem getLoginName = 'jv') ifTrue:[
+                            Transcript showCR:'>> no meaningful selection interval for ' , rule printString.
+                        ].
+                    ] ifFalse:[
+                        self mark: text from: interval first to: interval last for: rule.
+                    ]
                 ]
             ].
         ].
@@ -249,7 +255,7 @@
 !LintHighlighter class methodsFor:'documentation'!
 
 version
-    ^ '$Id: Tools__LintHighlighter.st 7985 2012-04-21 08:36:31Z vranyj1 $'
+    ^ '$Id: Tools__LintHighlighter.st 8047 2012-09-07 11:37:19Z vranyj1 $'
 !
 
 version_CVS
@@ -257,5 +263,5 @@
 !
 
 version_SVN
-    ^ '$Id: Tools__LintHighlighter.st 7985 2012-04-21 08:36:31Z vranyj1 $'
+    ^ '$Id: Tools__LintHighlighter.st 8047 2012-09-07 11:37:19Z vranyj1 $'
 ! !