`TestRunner2`: do not use `#keysAndValuesCollect:` jv tip
authorJan Vrany <jan.vrany@labware.com>
Sat, 30 Sep 2023 22:55:25 +0100
branchjv
changeset 19648 5df52d354504
parent 19647 0b91a1b7bfae
`TestRunner2`: do not use `#keysAndValuesCollect:` ...as semantics differ among smalltalk dialects. This is normally not a problem until we use code that adds this as a "compatibility" method. So to stay on a safe side, avoid using this method.
Tools__TestRunner2.st
--- a/Tools__TestRunner2.st	Wed Sep 27 10:19:21 2023 +0100
+++ b/Tools__TestRunner2.st	Sat Sep 30 22:55:25 2023 +0100
@@ -1,7 +1,7 @@
 "
  Copyright (c) 2007-2010 Jan Vrany, SWING Research Group, Czech Technical University in Prague
  Copyright (c) 2009-2010 eXept Software AG
- Copyright (c) 2021-2022 LabWare
+ Copyright (c) 2021-2023 LabWare
 
  Permission is hereby granted, free of charge, to any person
  obtaining a copy of this software and associated documentation
@@ -68,7 +68,7 @@
 "
  Copyright (c) 2007-2010 Jan Vrany, SWING Research Group, Czech Technical University in Prague
  Copyright (c) 2009-2010 eXept Software AG
- Copyright (c) 2021-2022 LabWare
+ Copyright (c) 2021-2023 LabWare
 
  Permission is hereby granted, free of charge, to any person
  obtaining a copy of this software and associated documentation
@@ -2258,15 +2258,16 @@
         (classes at: test class ifAbsentPut:[OrderedCollection new])
             add: test
     ].
-    children := 
-        classes keysAndValuesCollect: [:class :tests|
-            self makeClassEntryFor: class result: result tests: tests
-        ].
+    children := OrderedCollection new.
+    classes keysAndValuesDo: [:class :tests|
+        children add: (self makeClassEntryFor: class result: result tests: tests)
+    ].
     entry setChildren: children.
     ^entry.
 
     "Created: / 19-03-2010 / 08:36:38 / Jan Vrany <jan.vrany@fit.cvut.cz>"
     "Modified: / 30-07-2013 / 19:29:10 / cg"
+    "Modified: / 30-09-2023 / 22:52:53 / Jan Vrany <jan.vrany@labware.com>"
 !
 
 makeRootEntry