Depth8Image.st
changeset 7823 5a255f3fbbd6
parent 7754 2aac86a2c288
child 8120 f7f0d04eda06
child 8426 e2051b1553f0
--- a/Depth8Image.st	Tue Jan 31 13:48:08 2017 +0100
+++ b/Depth8Image.st	Tue Jan 31 13:48:23 2017 +0100
@@ -1,3 +1,5 @@
+"{ Encoding: utf8 }"
+
 "
  COPYRIGHT (c) 1993 by Claus Gittinger
 	      All Rights Reserved
@@ -196,8 +198,8 @@
      srcDepth map bytes|
 
     srcDepth := anImage depth.
-    (#(1 2 4) includes:srcDepth) ifFalse:[
-	^ super fromImage:anImage
+    (#[1 2 4] includes:srcDepth) ifFalse:[
+        ^ super fromImage:anImage
     ].
 
     width := w := anImage width.
@@ -208,14 +210,14 @@
     self colormapFromImage:anImage.
 
     colorMap isNil ifTrue:[
-	"/ if source has no colorMap, more work is needed ...
-	map := #(
-		#[0 16rFF]
-		#[0 16r55 16rAA 16rFF]
-		nil
-		#[16r00 16r11 16r22 16r33 16r44 16r55 16r66 16r77
-		  16r88 16r99 16rAA 16rBB 16rCC 16rDD 16rEE 16rFF]
-	       ) at:srcDepth.
+        "/ if source has no colorMap, more work is needed ...
+        map := #(
+                #[0 16rFF]
+                #[0 16r55 16rAA 16rFF]
+                nil
+                #[16r00 16r11 16r22 16r33 16r44 16r55 16r66 16r77
+                  16r88 16r99 16rAA 16rBB 16rCC 16rDD 16rEE 16rFF]
+               ) at:srcDepth.
     ].
 
     self mask:anImage mask.
@@ -231,14 +233,14 @@
     dstIdx := 1.
     bytes := self bits.
     bytes isNil ifTrue:[
-	self bits:(bytes := ByteArray new:(self bytesPerRow * self height)).
+        self bits:(bytes := ByteArray new:(self bytesPerRow * self height)).
     ].
     1 to:h do:[:hi |
-	srcBuffer replaceFrom:1 to:srcBytesPerRow with:srcBytes startingAt:srcIdx.
-	srcBuffer expandPixels:srcDepth width:w height:1 into:dstBuffer mapping:map.
-	bytes replaceFrom:dstIdx to:dstIdx+w-1 with:dstBuffer startingAt:1.
-	dstIdx := dstIdx + w.
-	srcIdx := srcIdx + srcBytesPerRow.
+        srcBuffer replaceFrom:1 to:srcBytesPerRow with:srcBytes startingAt:srcIdx.
+        srcBuffer expandPixels:srcDepth width:w height:1 into:dstBuffer mapping:map.
+        bytes replaceFrom:dstIdx to:dstIdx+w-1 with:dstBuffer startingAt:1.
+        dstIdx := dstIdx + w.
+        srcIdx := srcIdx + srcBytesPerRow.
     ]
 
     "
@@ -256,7 +258,8 @@
      i8 inspect.
     "
 
-    "Modified: 24.4.1997 / 14:01:14 / cg"
+    "Modified: / 24-04-1997 / 14:01:14 / cg"
+    "Modified: / 30-01-2017 / 19:33:25 / stefan"
 ! !
 
 !Depth8Image methodsFor:'converting images'!
@@ -334,9 +337,6 @@
 
     usedColors do:[:aColorIndex |
         |devColor color
-         r        "{Class: SmallInteger }"
-         g        "{Class: SmallInteger }"
-         b        "{Class: SmallInteger }"
          mapIndex "{Class: SmallInteger }"|
 
         fit ifTrue:[
@@ -601,8 +601,9 @@
 
     ^ f
 
-    "Modified: 15.10.1997 / 01:48:20 / cg"
-    "Created: 19.10.1997 / 04:57:05 / cg"
+    "Modified: / 15-10-1997 / 01:48:20 / cg"
+    "Created: / 19-10-1997 / 04:57:05 / cg"
+    "Modified (comment): / 30-01-2017 / 21:00:08 / stefan"
 !
 
 anyImageAsTrueColorFormOn:aDevice
@@ -1096,9 +1097,9 @@
      w       "{Class: SmallInteger }"
      h       "{Class: SmallInteger }"
      index   "{Class: SmallInteger }"
+     lookupPos "{Class: SmallInteger }"
      ditherIds failed lastColor qScramble
-     clrLookup lookupPos
-     error clr|
+     clrLookup error clr|
 
     "/
     "/ collect color components as integer values (for integer arithmetic)
@@ -1106,77 +1107,77 @@
     rgbBytes := ByteArray uninitializedNew:256 * 3.
 
     photometric == #palette ifTrue:[
-	lastColor := colorMap size - 1
+        lastColor := colorMap size - 1
     ] ifFalse:[
-	lastColor := 255.
+        lastColor := 255.
     ].
     index := 1.
     0 to:lastColor do:[:pix |
-	clr := self colorFromValue:pix.
-	rgbBytes at:index put:(clr redByte).
-	rgbBytes at:index+1 put:(clr greenByte).
-	rgbBytes at:index+2 put:(clr blueByte).
-
-	index := index + 3.
+        clr := self colorFromValue:pix.
+        rgbBytes at:index put:(clr redByte).
+        rgbBytes at:index+1 put:(clr greenByte).
+        rgbBytes at:index+2 put:(clr blueByte).
+
+        index := index + 3.
     ].
 
     "/ collect valid ditherColors ...
     aMapOrNil isNil ifTrue:[
-	ditherColors := colors select:[:clr | clr notNil].
+        ditherColors := colors select:[:clr | clr notNil].
     ] ifFalse:[
-	ditherColors := colors
+        ditherColors := colors
     ].
 
     "/ ... and sort by manhatten distance from black
 
     qScramble := #(
-		"/  2rX00X00X00X00
-
-		    2r000000000000    "/ 0
-		    2r000000000100    "/ 1
-		    2r000000100000    "/ 2
-		    2r000000100100    "/ 3
-		    2r000100000000    "/ 4
-		    2r000100000100    "/ 5
-		    2r000100100000    "/ 6
-		    2r000100100100    "/ 7
-		    2r100000000000    "/ 8
-		    2r100000000100    "/ 9
-		    2r100000100000    "/ a
-		    2r100000100100    "/ b
-		    2r100100000000    "/ c
-		    2r100100000100    "/ d
-		    2r100100100000    "/ e
-		    2r100100100100    "/ f
-		  ).
+                "/  2rX00X00X00X00
+
+                    2r000000000000    "/ 0
+                    2r000000000100    "/ 1
+                    2r000000100000    "/ 2
+                    2r000000100100    "/ 3
+                    2r000100000000    "/ 4
+                    2r000100000100    "/ 5
+                    2r000100100000    "/ 6
+                    2r000100100100    "/ 7
+                    2r100000000000    "/ 8
+                    2r100000000100    "/ 9
+                    2r100000100000    "/ a
+                    2r100000100100    "/ b
+                    2r100100000000    "/ c
+                    2r100100000100    "/ d
+                    2r100100100000    "/ e
+                    2r100100100100    "/ f
+                  ).
 
     ditherColors := ditherColors sort:[:a :b |
-				|cr "{Class: SmallInteger }"
-				 cg "{Class: SmallInteger }"
-				 cb "{Class: SmallInteger }"
-				 i1 "{Class: SmallInteger }"
-				 i2 "{Class: SmallInteger }"|
-
-				cr := a redByte.
-				cg := a greenByte.
-				cb := a blueByte.
-				i1 := qScramble at:((cr bitShift:-4) bitAnd:16r0F) + 1.
-				i1 := i1 + ((qScramble at:((cg bitShift:-4) bitAnd:16r0F) + 1) bitShift:-1).
-				i1 := i1 + ((qScramble at:((cb bitShift:-4) bitAnd:16r0F) + 1) bitShift:-2).
-
-				cr := b redByte.
-				cg := b greenByte.
-				cb := b blueByte.
-				i2 := qScramble at:((cr bitShift:-4) bitAnd:16r0F) + 1.
-				i2 := i2 + ((qScramble at:((cg bitShift:-4) bitAnd:16r0F) + 1) bitShift:-1).
-				i2 := i2 + ((qScramble at:((cb bitShift:-4) bitAnd:16r0F) + 1) bitShift:-2).
-
-				i1 < i2
-		    ].
+                                |cr "{Class: SmallInteger }"
+                                 cg "{Class: SmallInteger }"
+                                 cb "{Class: SmallInteger }"
+                                 i1 "{Class: SmallInteger }"
+                                 i2 "{Class: SmallInteger }"|
+
+                                cr := a redByte.
+                                cg := a greenByte.
+                                cb := a blueByte.
+                                i1 := qScramble at:((cr bitShift:-4) bitAnd:16r0F) + 1.
+                                i1 := i1 + ((qScramble at:((cg bitShift:-4) bitAnd:16r0F) + 1) bitShift:-1).
+                                i1 := i1 + ((qScramble at:((cb bitShift:-4) bitAnd:16r0F) + 1) bitShift:-2).
+
+                                cr := b redByte.
+                                cg := b greenByte.
+                                cb := b blueByte.
+                                i2 := qScramble at:((cr bitShift:-4) bitAnd:16r0F) + 1.
+                                i2 := i2 + ((qScramble at:((cg bitShift:-4) bitAnd:16r0F) + 1) bitShift:-1).
+                                i2 := i2 + ((qScramble at:((cb bitShift:-4) bitAnd:16r0F) + 1) bitShift:-2).
+
+                                i1 < i2
+                    ].
     aMapOrNil isNil ifTrue:[
-	ditherIds := (ditherColors asArray collect:[:clr | clr colorId]) asByteArray.
+        ditherIds := (ditherColors asArray collect:[:clr | clr colorId]) asByteArray.
     ] ifFalse:[
-	ditherIds := aMapOrNil asByteArray
+        ditherIds := aMapOrNil asByteArray
     ].
 
     "/ build an index table, for fast lookup from manhatten-r-g-b distance
@@ -1185,20 +1186,20 @@
     clrLookup := ByteArray new:(4096).
     index := 0.
     ditherColors keysAndValuesDo:[:clrPosition :clr |
-	|r g b i|
-
-	r := clr redByte.
-	g := clr greenByte.
-	b := clr blueByte.
-	i := qScramble at:((r bitShift:-4) bitAnd:16r0F) + 1.
-	i := i + ((qScramble at:((g bitShift:-4) bitAnd:16r0F) + 1) bitShift:-1).
-	i := i + ((qScramble at:((b bitShift:-4) bitAnd:16r0F) + 1) bitShift:-2).
-	lookupPos := i.
-
-	[index < lookupPos] whileTrue:[
-	    clrLookup at:(index+1) put:(clrPosition-1-1).
-	    index := index + 1
-	]
+        |r g b i|
+
+        r := clr redByte.
+        g := clr greenByte.
+        b := clr blueByte.
+        i := qScramble at:((r bitShift:-4) bitAnd:16r0F) + 1.
+        i := i + ((qScramble at:((g bitShift:-4) bitAnd:16r0F) + 1) bitShift:-1).
+        i := i + ((qScramble at:((b bitShift:-4) bitAnd:16r0F) + 1) bitShift:-2).
+        lookupPos := i.
+
+        index+1 to:lookupPos do:[:idx|
+            clrLookup at:idx put:(clrPosition-1-1).
+        ].
+        index := lookupPos.
     ].
     clrLookup from:index+1 to:4096 put:(ditherColors size - 1).
 
@@ -1214,16 +1215,16 @@
     ditherRGBBytes := ByteArray uninitializedNew:(lastColor * 3).
     index := 1.
     1 to:lastColor do:[:pix |
-	clr := ditherColors at:pix.
-	ditherRGBBytes at:index put:(clr redByte).
-	ditherRGBBytes at:index+1 put:(clr greenByte).
-	ditherRGBBytes at:index+2 put:(clr blueByte).
-	aMapOrNil isNil ifTrue:[
-	    ditherIds at:pix put:clr colorId.
-	] ifFalse:[
-	    ditherIds at:pix put:(aMapOrNil at:pix).
-	].
-	index := index + 3.
+        clr := ditherColors at:pix.
+        ditherRGBBytes at:index put:(clr redByte).
+        ditherRGBBytes at:index+1 put:(clr greenByte).
+        ditherRGBBytes at:index+2 put:(clr blueByte).
+        aMapOrNil isNil ifTrue:[
+            ditherIds at:pix put:clr colorId.
+        ] ifFalse:[
+            ditherIds at:pix put:(aMapOrNil at:pix).
+        ].
+        index := index + 3.
     ].
 
     pseudoBits := ByteArray uninitializedNew:(width * height).
@@ -1253,23 +1254,23 @@
     int __nColors = __intVal(lastColor);
     int __wR = -1, __wG, __wB;
     static int __qScramble[16] = {
-		    0x000 /* 2r000000000000    0 */,
-		    0x004 /* 2r000000000100    1 */,
-		    0x020 /* 2r000000100000    2 */,
-		    0x024 /* 2r000000100100    3 */,
-		    0x100 /* 2r000100000000    4 */,
-		    0x104 /* 2r000100000100    5 */,
-		    0x120 /* 2r000100100000    6 */,
-		    0x124 /* 2r000100100100    7 */,
-		    0x800 /* 2r100000000000    8 */,
-		    0x804 /* 2r100000000100    9 */,
-		    0x820 /* 2r100000100000    a */,
-		    0x824 /* 2r100000100100    b */,
-		    0x900 /* 2r100100000000    c */,
-		    0x904 /* 2r100100000100    d */,
-		    0x920 /* 2r100100100000    e */,
-		    0x924 /* 2r100100100100    f */,
-		  };
+                    0x000 /* 2r000000000000    0 */,
+                    0x004 /* 2r000000000100    1 */,
+                    0x020 /* 2r000000100000    2 */,
+                    0x024 /* 2r000000100100    3 */,
+                    0x100 /* 2r000100000000    4 */,
+                    0x104 /* 2r000100000100    5 */,
+                    0x120 /* 2r000100100000    6 */,
+                    0x124 /* 2r000100100100    7 */,
+                    0x800 /* 2r100000000000    8 */,
+                    0x804 /* 2r100000000100    9 */,
+                    0x820 /* 2r100000100000    a */,
+                    0x824 /* 2r100000100100    b */,
+                    0x900 /* 2r100100000000    c */,
+                    0x904 /* 2r100100000100    d */,
+                    0x920 /* 2r100100100000    e */,
+                    0x924 /* 2r100100100100    f */,
+                  };
 
     if (__isByteArrayLike(__INST(bytes))
      && __isByteArray(pseudoBits)
@@ -1278,50 +1279,50 @@
      && __isByteArray(ditherIds)
      && __isByteArray(clrLookup)
      && __isByteArray(error)) {
-	failed = false;
-
-	srcP = __ByteArrayInstPtr(__INST(bytes))->ba_element;
-	dstP = __ByteArrayInstPtr(pseudoBits)->ba_element;
-	rgbP = __ByteArrayInstPtr(rgbBytes)->ba_element;
-	idP = __ByteArrayInstPtr(ditherIds)->ba_element;
-	__clrLookup = __ByteArrayInstPtr(clrLookup)->ba_element;
-	errP = (short *) __ByteArrayInstPtr(error)->ba_element;
-
-	/*
-	 * clear error accumulator
-	 */
-	eP = errP;
-	bzero(eP, (__w+2) * 2 * 3);
-
-	for (__y=__h; __y>0; __y--) {
-	    __eR = __eG = __eB = 0;
-
-	    eP = &(errP[3]);
-	    __eR = eP[0];
-	    __eG = eP[1];
-	    __eB = eP[2];
-
-	    for (__x=__w; __x>0; __x--) {
-		int __want;
-		int pix;
-		int __wantR, __wantG, __wantB;
-		int idx;
-		int tR, tG, tB;
-		int nR, nG, nB;
-		int dR, dG, dB;
-		int minDelta, bestIdx;
-		int cnt;
-
-		pix = *srcP++;
-
-		/*
-		 * wR, wG and wB is the wanted r/g/b value;
-		 */
-		idx = pix+pix+pix;  /* pix * 3 */
-
-		__wantR = rgbP[idx] + __eR;
-		__wantG = rgbP[idx+1] + __eG;
-		__wantB = rgbP[idx+2] + __eB;
+        failed = false;
+
+        srcP = __ByteArrayInstPtr(__INST(bytes))->ba_element;
+        dstP = __ByteArrayInstPtr(pseudoBits)->ba_element;
+        rgbP = __ByteArrayInstPtr(rgbBytes)->ba_element;
+        idP = __ByteArrayInstPtr(ditherIds)->ba_element;
+        __clrLookup = __ByteArrayInstPtr(clrLookup)->ba_element;
+        errP = (short *) __ByteArrayInstPtr(error)->ba_element;
+
+        /*
+         * clear error accumulator
+         */
+        eP = errP;
+        bzero(eP, (__w+2) * 2 * 3);
+
+        for (__y=__h; __y>0; __y--) {
+            __eR = __eG = __eB = 0;
+
+            eP = &(errP[3]);
+            __eR = eP[0];
+            __eG = eP[1];
+            __eB = eP[2];
+
+            for (__x=__w; __x>0; __x--) {
+                int __want;
+                int pix;
+                int __wantR, __wantG, __wantB;
+                int idx;
+                int tR, tG, tB;
+                int nR, nG, nB;
+                int dR, dG, dB;
+                int minDelta, bestIdx;
+                int cnt;
+
+                pix = *srcP++;
+
+                /*
+                 * wR, wG and wB is the wanted r/g/b value;
+                 */
+                idx = pix+pix+pix;  /* pix * 3 */
+
+                __wantR = rgbP[idx] + __eR;
+                __wantG = rgbP[idx+1] + __eG;
+                __wantB = rgbP[idx+2] + __eB;
 
 #define RED_SCALE 30
 #define GREEN_SCALE 59
@@ -1338,236 +1339,236 @@
 #define NPROBE 8
 
 #ifndef FAST_LOOKUP
-		if ((__wantR == __wR)
-		 && (__wantG == __wG)
-		 && (__wantB == __wB)) {
-		    /*
-		     * same color again - reuse last bestMatch
-		     */
-		} else
+                if ((__wantR == __wR)
+                 && (__wantG == __wG)
+                 && (__wantB == __wB)) {
+                    /*
+                     * same color again - reuse last bestMatch
+                     */
+                } else
 #endif
-		{
-		    __wR = __wantR;
-		    __wG = __wantG;
-		    __wB = __wantB;
+                {
+                    __wR = __wantR;
+                    __wG = __wantG;
+                    __wB = __wantB;
 
 #ifdef FAST_LOOKUP
-		    if(__wR > 255) __wR = 255;
-		    else if (__wR < 0) __wR = 0;
-		    if(__wG > 255) __wG = 255;
-		    else if (__wG < 0) __wG = 0;
-		    if(__wB > 255) __wB = 255;
-		    else if (__wB < 0) __wB = 0;
-
-		    {
-			int lookupIndex;
-			int idx, idx0;
-			int d, delta;
-			unsigned char *dp0;
-
-			dp = __ByteArrayInstPtr(ditherRGBBytes)->ba_element;
-			lookupIndex =    __qScramble[((__wR & 0xF0)>>4)];
-			lookupIndex |=   __qScramble[((__wG & 0xF0)>>4)] >> 1;
-			lookupIndex |=   __qScramble[((__wB & 0xF0)>>4)] >> 2;
-			idx = bestIdx =__clrLookup[lookupIndex];
-			dp += (idx+idx+idx);
-
-			/* try color at lookupIndex */
-
-			d = dp[0];
-			delta = (__wR - d) * RED_SCALE;
-			if (delta < 0) delta = -delta;
-
-			d = dp[1];
-			if (__wG > d)
-			    delta += (__wG - d) * GREEN_SCALE;
-			else
-			    delta += (d - __wG) * GREEN_SCALE;
-			d = dp[2];
-			if (__wB > d)
-			    delta += (__wB - d) * BLUE_SCALE;
-			else
-			    delta += (d - __wB) * BLUE_SCALE;
-
-			if (delta <= GOOD_DELTA) {
-			    goto foundBest;
-			}
-			minDelta = delta;
+                    if(__wR > 255) __wR = 255;
+                    else if (__wR < 0) __wR = 0;
+                    if(__wG > 255) __wG = 255;
+                    else if (__wG < 0) __wG = 0;
+                    if(__wB > 255) __wB = 255;
+                    else if (__wB < 0) __wB = 0;
+
+                    {
+                        int lookupIndex;
+                        int idx, idx0;
+                        int d, delta;
+                        unsigned char *dp0;
+
+                        dp = __ByteArrayInstPtr(ditherRGBBytes)->ba_element;
+                        lookupIndex =    __qScramble[((__wR & 0xF0)>>4)];
+                        lookupIndex |=   __qScramble[((__wG & 0xF0)>>4)] >> 1;
+                        lookupIndex |=   __qScramble[((__wB & 0xF0)>>4)] >> 2;
+                        idx = bestIdx =__clrLookup[lookupIndex];
+                        dp += (idx+idx+idx);
+
+                        /* try color at lookupIndex */
+
+                        d = dp[0];
+                        delta = (__wR - d) * RED_SCALE;
+                        if (delta < 0) delta = -delta;
+
+                        d = dp[1];
+                        if (__wG > d)
+                            delta += (__wG - d) * GREEN_SCALE;
+                        else
+                            delta += (d - __wG) * GREEN_SCALE;
+                        d = dp[2];
+                        if (__wB > d)
+                            delta += (__wB - d) * BLUE_SCALE;
+                        else
+                            delta += (d - __wB) * BLUE_SCALE;
+
+                        if (delta <= GOOD_DELTA) {
+                            goto foundBest;
+                        }
+                        minDelta = delta;
 # ifndef ONE_SHOT
-			idx0 = idx; dp0 = dp;
-			cnt = 0;
-			while ((++cnt <= NPROBE) && (idx > 0)) {
-			    /* try previous color(s) */
-
-			    idx--; dp -= 3;
-			    d = dp[0];
-			    delta = (__wR - d) * RED_SCALE;
-			    if (delta < 0) delta = -delta;
-			    d = dp[1];
-			    if (__wG > d)
-				delta += (__wG - d) * GREEN_SCALE;
-			    else
-				delta += (d - __wG) * GREEN_SCALE;
-			    d = dp[2];
-			    if (__wB > d)
-				delta += (__wB - d) * BLUE_SCALE;
-			    else
-				delta += (d - __wB) * BLUE_SCALE;
-
-			    if (delta < minDelta) {
-				bestIdx = idx;
-				if (delta <= GOOD_DELTA) {
-				    goto foundBest;
-				}
-				minDelta = delta;
-			    }
-			}
-
-			idx = idx0; dp = dp0;
-			cnt = 0;
-			while ((++cnt <= NPROBE) && (++idx < __nColors)) {
-			    /* try next color */
-
-			    dp += 3;
-			    d = dp[0];
-			    delta = (__wR - d) * RED_SCALE;
-			    if (delta < 0) delta = -delta;
-			    d = dp[1];
-			    if (__wG > d)
-				delta += (__wG - d) * GREEN_SCALE;
-			    else
-				delta += (d - __wG) * GREEN_SCALE;
-			    d = dp[2];
-			    if (__wB > d)
-				delta += (__wB - d) * BLUE_SCALE;
-			    else
-				delta += (d - __wB) * BLUE_SCALE;
-
-			    if (delta < minDelta) {
-				bestIdx = idx;
-				if (delta <= GOOD_DELTA) {
-				    goto foundBest;
-				}
-				minDelta = delta;
-			    }
-			}
+                        idx0 = idx; dp0 = dp;
+                        cnt = 0;
+                        while ((++cnt <= NPROBE) && (idx > 0)) {
+                            /* try previous color(s) */
+
+                            idx--; dp -= 3;
+                            d = dp[0];
+                            delta = (__wR - d) * RED_SCALE;
+                            if (delta < 0) delta = -delta;
+                            d = dp[1];
+                            if (__wG > d)
+                                delta += (__wG - d) * GREEN_SCALE;
+                            else
+                                delta += (d - __wG) * GREEN_SCALE;
+                            d = dp[2];
+                            if (__wB > d)
+                                delta += (__wB - d) * BLUE_SCALE;
+                            else
+                                delta += (d - __wB) * BLUE_SCALE;
+
+                            if (delta < minDelta) {
+                                bestIdx = idx;
+                                if (delta <= GOOD_DELTA) {
+                                    goto foundBest;
+                                }
+                                minDelta = delta;
+                            }
+                        }
+
+                        idx = idx0; dp = dp0;
+                        cnt = 0;
+                        while ((++cnt <= NPROBE) && (++idx < __nColors)) {
+                            /* try next color */
+
+                            dp += 3;
+                            d = dp[0];
+                            delta = (__wR - d) * RED_SCALE;
+                            if (delta < 0) delta = -delta;
+                            d = dp[1];
+                            if (__wG > d)
+                                delta += (__wG - d) * GREEN_SCALE;
+                            else
+                                delta += (d - __wG) * GREEN_SCALE;
+                            d = dp[2];
+                            if (__wB > d)
+                                delta += (__wB - d) * BLUE_SCALE;
+                            else
+                                delta += (d - __wB) * BLUE_SCALE;
+
+                            if (delta < minDelta) {
+                                bestIdx = idx;
+                                if (delta <= GOOD_DELTA) {
+                                    goto foundBest;
+                                }
+                                minDelta = delta;
+                            }
+                        }
 # endif
-		    }
-	foundBest: ;
+                    }
+        foundBest: ;
 #else
 /*
-		    if(__wR > 255) __wR = 255;
-		    else if (__wR < 0) __wR = 0;
-		    if(__wG > 255) __wG = 255;
-		    else if (__wG < 0) __wG = 0;
-		    if(__wB > 255) __wB = 255;
-		    else if (__wB < 0) __wB = 0;
+                    if(__wR > 255) __wR = 255;
+                    else if (__wR < 0) __wR = 0;
+                    if(__wG > 255) __wG = 255;
+                    else if (__wG < 0) __wG = 0;
+                    if(__wB > 255) __wB = 255;
+                    else if (__wB < 0) __wB = 0;
 */
 
-		    /* find the best matching color */
-
-		    minDelta = 99999;
-		    bestIdx = -1;
-		    dp = __ByteArrayInstPtr(ditherRGBBytes)->ba_element;
-		    for (idx = 0; idx<__nColors; idx++) {
-			int d, delta;
-
-			d = dp[0];
-			delta = (__wR - d) * RED_SCALE;
-			if (delta < 0) delta = -delta;
-			if (delta < minDelta) {
-			    d = dp[1];
-			    if (__wG > d)
-				delta += (__wG - d) * GREEN_SCALE;
-			    else
-				delta += (d - __wG) * GREEN_SCALE;
-			    if (delta < minDelta) {
-				d = dp[2];
-				if (__wB > d)
-				    delta += (__wB - d) * BLUE_SCALE;
-				else
-				    delta += (d - __wB) * BLUE_SCALE;
-
-				if (delta < minDelta) {
-				    bestIdx = idx;
-				    if (delta <= GOOD_DELTA) {
-					break;
-				    }
-				    minDelta = delta;
-				}
-			    }
-			}
-			dp += 3;
-		    }
+                    /* find the best matching color */
+
+                    minDelta = 99999;
+                    bestIdx = -1;
+                    dp = __ByteArrayInstPtr(ditherRGBBytes)->ba_element;
+                    for (idx = 0; idx<__nColors; idx++) {
+                        int d, delta;
+
+                        d = dp[0];
+                        delta = (__wR - d) * RED_SCALE;
+                        if (delta < 0) delta = -delta;
+                        if (delta < minDelta) {
+                            d = dp[1];
+                            if (__wG > d)
+                                delta += (__wG - d) * GREEN_SCALE;
+                            else
+                                delta += (d - __wG) * GREEN_SCALE;
+                            if (delta < minDelta) {
+                                d = dp[2];
+                                if (__wB > d)
+                                    delta += (__wB - d) * BLUE_SCALE;
+                                else
+                                    delta += (d - __wB) * BLUE_SCALE;
+
+                                if (delta < minDelta) {
+                                    bestIdx = idx;
+                                    if (delta <= GOOD_DELTA) {
+                                        break;
+                                    }
+                                    minDelta = delta;
+                                }
+                            }
+                        }
+                        dp += 3;
+                    }
 #endif
-		}
-		dp = __ByteArrayInstPtr(ditherRGBBytes)->ba_element;
-		dp += bestIdx * 3;
-		dR = dp[0];
-		dG = dp[1];
-		dB = dp[2];
+                }
+                dp = __ByteArrayInstPtr(ditherRGBBytes)->ba_element;
+                dp += bestIdx * 3;
+                dR = dp[0];
+                dG = dp[1];
+                dB = dp[2];
 
 /*
 console_fprintf(stderr, "want: %d/%d/%d (%d/%d/%d) got: %d/%d/%d\n",
-		__wantR, __wantG, __wantB,
-		__wR, __wG, __wB,
-		dR, dG, dB);
+                __wantR, __wantG, __wantB,
+                __wR, __wG, __wB,
+                dR, dG, dB);
 */
-		/*
-		 * store the corresponding dither colors colorId
-		 */
-		*dstP++ = idP[bestIdx];
-
-		/*
-		 * the new error & distribute the error
-		 */
-		__eR = __wantR - dR;
-		if (__eR) {
-		    tR = __eR >> 4;  /* 16th of error */
-		    nR = eP[3] + (tR * 7);/* from accu: error for (x+1 / y) */
-		    eP[0] = tR*5;         /* 5/16th for (x / y+1) */
-		    eP[-3] = tR*3;        /* 3/16th for (x-1 / y+1) */
-		    eP[3] = __eR - (tR*15);  /* 1/16th for (x+1 / y+1) */
-		    __eR = nR;
-		} else {
-		    __eR = eP[3];
-		    eP[0] = eP[-3] = eP[3] = 0;
-		}
-
-		__eG = __wantG - dG;
-		if (__eG) {
-		    tG = __eG >> 4;
-		    nG = eP[4] + (tG * 7);/* plus 7/16'th of this error */
-		    eP[1] = tG*5;
-		    eP[-2] = tG*3;
-		    eP[4] = __eG - (tG*15);
-		    __eG = nG;
-		} else {
-		    __eG = eP[4];
-		    eP[1] = eP[-2] = eP[4] = 0;
-		}
-
-		__eB = __wantB - dB;
-		if (__eB) {
-		    tB = __eB >> 4;
-		    nB = eP[5] + (tB * 7);
-		    eP[2] = tB*5;
-		    eP[-1] = tB*3;
-		    eP[5] = __eB - (tB*15);
-		    __eB = nB;
-		} else {
-		    __eB = eP[5];
-		    eP[2] = eP[-1] = eP[5] = 0;
-		}
-
-		eP += 3;
-	    }
-	}
+                /*
+                 * store the corresponding dither colors colorId
+                 */
+                *dstP++ = idP[bestIdx];
+
+                /*
+                 * the new error & distribute the error
+                 */
+                __eR = __wantR - dR;
+                if (__eR) {
+                    tR = __eR >> 4;  /* 16th of error */
+                    nR = eP[3] + (tR * 7);/* from accu: error for (x+1 / y) */
+                    eP[0] = tR*5;         /* 5/16th for (x / y+1) */
+                    eP[-3] = tR*3;        /* 3/16th for (x-1 / y+1) */
+                    eP[3] = __eR - (tR*15);  /* 1/16th for (x+1 / y+1) */
+                    __eR = nR;
+                } else {
+                    __eR = eP[3];
+                    eP[0] = eP[-3] = eP[3] = 0;
+                }
+
+                __eG = __wantG - dG;
+                if (__eG) {
+                    tG = __eG >> 4;
+                    nG = eP[4] + (tG * 7);/* plus 7/16'th of this error */
+                    eP[1] = tG*5;
+                    eP[-2] = tG*3;
+                    eP[4] = __eG - (tG*15);
+                    __eG = nG;
+                } else {
+                    __eG = eP[4];
+                    eP[1] = eP[-2] = eP[4] = 0;
+                }
+
+                __eB = __wantB - dB;
+                if (__eB) {
+                    tB = __eB >> 4;
+                    nB = eP[5] + (tB * 7);
+                    eP[2] = tB*5;
+                    eP[-1] = tB*3;
+                    eP[5] = __eB - (tB*15);
+                    __eB = nB;
+                } else {
+                    __eB = eP[5];
+                    eP[2] = eP[-1] = eP[5] = 0;
+                }
+
+                eP += 3;
+            }
+        }
     }
 %}.
     failed ifTrue:[
-	self primitiveFailed.
-	^ nil
+        self primitiveFailed.
+        ^ nil
     ].
 
     ^ pseudoBits
@@ -1952,16 +1953,16 @@
 
     x1 := xLow.
     x2 := xHigh.
-    srcIndex := (width * y) + 1 + x1.
+    srcIndex := (width * y) + 1.
     bytes := self bits.
 
     x1 to:x2 do:[:x |
-	pixelValue := bytes at:srcIndex.
-	srcIndex := srcIndex + 1.
-	aBlock value:x value:pixelValue
+        pixelValue := bytes at:srcIndex+x.
+        aBlock value:x value:pixelValue
     ]
 
-    "Created: 7.6.1996 / 19:09:47 / cg"
+    "Created: / 07-06-1996 / 19:09:47 / cg"
+    "Modified: / 30-01-2017 / 18:54:15 / stefan"
 !
 
 valuesFromX:xStart y:yStart toX:xEnd y:yEnd do:aBlock
@@ -1974,8 +1975,7 @@
      However, for real high performance image processing, specialized methods
      should be written which know how to deal with specific photometric interpretations."
 
-    |srcIndex    "{ Class: SmallInteger }"
-     srcNext     "{ Class: SmallInteger }"
+    |srcIndex    "{ Class: SmallInteger }" 
      bytesPerRow "{ Class: SmallInteger }"
      value    "{ Class: SmallInteger }"
      x1       "{ Class: SmallInteger }"
@@ -1989,24 +1989,21 @@
     y1 := yStart.
     y2 := yEnd.
 
-    srcIndex := (width * y1) + x1 + 1 .
+    srcIndex := (width * y1) + 1 .
     bytesPerRow := self bytesPerRow.
     bytes := self bits.
 
     y1 to:y2 do:[:y |
-	srcNext := srcIndex + bytesPerRow.
-	x1 to:x2 do:[:x |
-	    value := bytes at:srcIndex.
-	    srcIndex := srcIndex + 1.
-
-	    aBlock value:x value:y value:value
-	].
-	srcIndex := srcNext.
+        x1 to:x2 do:[:x |
+            value := bytes at:srcIndex+x.
+            aBlock value:x value:y value:value
+        ].
+        srcIndex := srcIndex + bytesPerRow.
     ].
-    ^ self
-
-    "Modified: 11.7.1996 / 20:06:47 / cg"
-    "Created: 11.7.1996 / 20:08:11 / cg"
+
+    "Created: / 11-07-1996 / 20:08:11 / cg"
+    "Modified: / 30-01-2017 / 19:04:05 / stefan"
+    "Modified (format): / 31-01-2017 / 12:44:04 / stefan"
 ! !
 
 !Depth8Image methodsFor:'image manipulations'!
@@ -2169,19 +2166,19 @@
     newBytes := ByteArray uninitializedNew:(newWidth * newHeight).
 
     mask notNil ifTrue:[
-	newMask := (mask magnifiedBy:scalePoint)
+        newMask := (mask magnifiedBy:scalePoint)
     ].
 
     newImage := self species new.
     newImage
-	width:newWidth
-	height:newHeight
-	photometric:photometric
-	samplesPerPixel:samplesPerPixel
-	bitsPerSample:#(8)
-	colorMap:colorMap copy
-	bits:newBytes
-	mask:newMask.
+        width:newWidth
+        height:newHeight
+        photometric:photometric
+        samplesPerPixel:samplesPerPixel
+        bitsPerSample:#[8]
+        colorMap:colorMap copy
+        bits:newBytes
+        mask:newMask.
 
     "walk over destination image fetching pixels from source image"
 
@@ -2199,10 +2196,10 @@
     double __mY = __floatVal(mY);
 
     for (__row = 0; __row <= __h; __row++) {
-	__srcRowP = __srcP + (__width * (int)((double)__row / __mY));
-	for (__col = 0; __col <= __w; __col++) {
-	    *__dstP++ = __srcRowP[(int)((double)__col / __mX)];
-	}
+        __srcRowP = __srcP + (__width * (int)((double)__row / __mY));
+        for (__col = 0; __col <= __w; __col++) {
+            *__dstP++ = __srcRowP[(int)((double)__col / __mX)];
+        }
     }
 %}
 .