#REFACTORING by cg
authorClaus Gittinger <cg@exept.de>
Sat, 10 Nov 2018 00:26:58 +0100
changeset 6490 3d1a00dd648f
parent 6489 6afea8177a52
child 6491 b493c7621a50
#REFACTORING by cg class: Scroller added: #computePreferredExtent removed: #preferredExtent changed: #orientation:
Scroller.st
--- a/Scroller.st	Sat Nov 10 00:26:36 2018 +0100
+++ b/Scroller.st	Sat Nov 10 00:26:58 2018 +0100
@@ -964,19 +964,19 @@
     |oldFrame|
 
     orientation := aSymbol.
-    preferredExtent := nil.
+    self flushCachedPreferredExtent.
 
     shown ifTrue:[
-	oldFrame := thumbFrame.
-	self computeThumbFrame.
-
-	oldFrame ~= thumbFrame ifTrue:[
-	    self invalidate.
-	]
+        oldFrame := thumbFrame.
+        self computeThumbFrame.
+
+        oldFrame ~= thumbFrame ifTrue:[
+            self invalidate.
+        ]
     ]
 
-    "Created: 1.4.1997 / 12:18:32 / cg"
-    "Modified: 1.4.1997 / 12:20:46 / cg"
+    "Created: / 01-04-1997 / 12:18:32 / cg"
+    "Modified: / 09-11-2018 / 20:17:52 / Claus Gittinger"
 !
 
 thumb
@@ -2752,31 +2752,11 @@
 
 !Scroller methodsFor:'queries'!
 
-isMiniScroller
-    ^ false
-!
-
-isScrolling
-    "true, if thumb is being moved (by user)"
-
-    ^ scrolling
-!
-
-preferredExtent
+computePreferredExtent
     "return my preferredExtent"
 
     |defExt w h|
 
-    "/ If I have an explicit preferredExtent..
-    explicitExtent notNil ifTrue:[
-        ^ explicitExtent
-    ].
-
-    "/ If I have a cached preferredExtent value..
-    preferredExtent notNil ifTrue:[
-        ^ preferredExtent
-    ].
-
     defExt := self class defaultExtent.
 
     orientation == #vertical ifTrue:[
@@ -2794,7 +2774,17 @@
     preferredExtent := w @ h.
     ^ preferredExtent.
 
-    "Modified: / 28.4.1999 / 18:28:19 / cg"
+    "Created: / 09-11-2018 / 20:00:28 / Claus Gittinger"
+!
+
+isMiniScroller
+    ^ false
+!
+
+isScrolling
+    "true, if thumb is being moved (by user)"
+
+    ^ scrolling
 !
 
 thumbVisible