Cherry-picked Ruler.st from a3177d4a9ae5: * b2a3ee58d40c: #UI_ENHANCEMENT by exept, Claus Gittinger <cg@exept.de>

Separating DefaultForegroundColor and DefaultBackgroundColor from pullDownMenu colors

Replacing obsolete PluggableParseNodeVisitor with ParseNodeVisitor (it is now pluggable too)

File conversion from ISO-8859-1 to UTF8 without BOM

Fix loong standing bug with some menus not being translated / resolved This has happened with browser "View" menu when sometimes it had the slice resolved and sometimes not. It turned out that it was because the code disabled resources (and therefore slices) resolution when processing shortcuts, so the menu was created and cached unresolved. This fixes the issue. eXept apparently run into the same problem.

Add utility method `PluggableHierarchicalList >> roots:` This allows one to set multiple objects as root without a need to manually create synthetic root object. Useful to show a collection of hierachical object.

`FontMenu`: use `#hasVerticalLayout:` ...instead of (now obsolete) `#verticalLayout:`

`MenuPanel`: renamed `#verticalLayout:` to `#hasVerticalLayout:` to catch up with change made in 6effdd4ff48a.

`NoteBookView`: take `DefaultActiveTabMarkerFgColor` from stylesheet ...rather than hard-coding it! The hardcoded value is used as a default for backward compatibility, although it'd be more sensible to use `DefaultActiveTabMarkerColor` as default.

`MenuPanel`: draw submenu indicator in menu panel's foreground color ...rather than using black unconditionally. This does not work well with dark themes.

`ListModelView`: allow to configure border ...using `text.borderWidth` and `text.borderColor` styles. Note, that the style prefix is `text` (while it'd make more sense to use `list`) - this is to make it consistent. Somebody in the past thought `text` is better and code was never cleaned up.

`MenuPanel`: allow to configure border width and background color ...using `pullDownMenu.borderWidth` and `menu.backgroundColor` styles.

`HierarchicalListView`: draw icon *after* the label itself This commit changes the drawing logic so item (label) is rendered first and icon after. This allows custom subclasses of `AbstractHierarchicalItem` to override `displayOn:x:y:h:isHighlightedAsSelected:` and provide custom background for given item. This is used in VDB UI, for instance.

`TerminalView`: handle CR not followed by LF ...as this is produced by GDB in some cases, causing first character to be eaten (not displayed). Sigh.

`TerminalView`: various fixes to make it work with St/X jv-branch

Backed out changeset a1272bf7ae91

Cherry-picked `TerminalView` and `VT100TerminalView.st` from 52ddfab52152: * cherry-picked TerminalView.st from 52ddfab52152: * 29c409638778: #FEATURE by cg, Claus Gittinger <cg@exept.de> * f4a375bbf778: #UI_ENHANCEMENT by cg, Claus Gittinger <cg@exept.de> * 9ff89d98ba80: Keyboard mapping: code updated to catch up with `KeyboardMap`, Jan Vrany <jan.vrany@fit.cvut.cz> * db72eb21203c: `TerminalView`: do not tinker with cursor position when selecting via mouse, Jan Vrany <jan.vrany@fit.cvut.cz> * a9a15e045620: `TerminalView`: fixed slip after `KeyboardMap` refactoring, Jan Vrany <jan.vrany@fit.cvut.cz> * df7b96c04c11: #DOCUMENTATION by cg, Claus Gittinger <cg@exept.de> * 7a69d3fdca24: #QUALITY by cg, Claus Gittinger <cg@exept.de> * 5829d2def42c: #BUGFIX by cg, Claus Gittinger <cg@exept.de> * f6122d30bce9: #UI_ENHANCEMENT by cg, Claus Gittinger <cg@exept.de> * a74a4de7393a: #UI_ENHANCEMENT by cg, Claus Gittinger <cg@exept.de> * aa0c8adb8c29: #UI_ENHANCEMENT by cg, Claus Gittinger <cg@exept.de> * 56884612657a: #UI_ENHANCEMENT by cg, Claus Gittinger <cg@exept.de> * 68a1a475ad31: #FEATURE by cg, Claus Gittinger <cg@exept.de> * 70d07365a2d4: Copyright updates, Jan Vrany <jan.vrany@fit.cvut.cz> * 528fcc031415: `TerminalView`: make sure the last line is always fully visible, Jan Vrany <jan.vrany@fit.cvut.cz> * 00c0cc2441a9: #OTHER by cg, Claus Gittinger <cg@exept.de> * b0a0be3361d1: #FEATURE by cg, Claus Gittinger <cg@exept.de> * 7b379fe88950: #TUNING by stefan, Stefan Vogel <sv@exept.de> * 0ca982cfa457: #FEATURE by cg, Claus Gittinger <cg@exept.de> * 171b5e2e8820: #BUGFIX by cg, Claus Gittinger <cg@exept.de> * 756275df9939: #REFACTORING by cg, Claus Gittinger <cg@exept.de> * d712d7f4fc2b: `TerminalView`: do not clear line if terminal is in 'local echo' mode, Jan Vrany <jan.vrany@fit.cvut.cz> * e880a0b1320b: Fix copy & paste in `TerminalView`, Jan Vrany <jan.vrany@fit.cvut.cz> * a85c5316417b: #REFACTORING by cg, Claus Gittinger <cg@exept.de> * 4d87665db62d: #REFACTORING by cg, Claus Gittinger <cg@exept.de> * 8689f323e116: #UI_ENHANCEMENT by cg, Claus Gittinger <cg@exept.de> * e7fd53f408b8: #BUGFIX by cg, Claus Gittinger <cg@exept.de> * fc59a1fcfdcd: Cherry-picked changes to `TerminalView` from CVS, Jan Vrany <jan.vrany@fit.cvut.cz> * f0e51145a4ec: ``TerminalView`: add new APIs: #widthInChars` and `#heightInChars`, Jan Vrany <jan.vrany@fit.cvut.cz> * 5e8b7ee23889: `TerminalView`: fix unicode output on UNIX platforms, Jan Vrany <jan.vrany@fit.cvut.cz> * 5182891c9a14: Fix slip `TerminalView >> innerHeight`, Jan Vrany <jan.vrany@fit.cvut.cz> * 08c9e2a47dc5: #OTHER by cg, Claus Gittinger <cg@exept.de> * 4de6a6b2f700: #REFACTORING by cg, Claus Gittinger <cg@exept.de> * aa05a0ea29ca: #REFACTORING by exept, Claus Gittinger <cg@exept.de> * 90913a584a2b: #OTHER by exept, Claus Gittinger <cg@exept.de> * 57e3e348928f: #OTHER by exept, Claus Gittinger <cg@exept.de> * 712bc32afde8: #OTHER by exept, Claus Gittinger <cg@exept.de> * a15871e06ccd: #FEATURE by exept, Claus Gittinger <cg@exept.de> * dd919a19b802: #BUGFIX by cg, Claus Gittinger <cg@exept.de> * 274d04c1421e: #BUGFIX by cg, Claus Gittinger <cg@exept.de> * 601426541811: #REFACTORING by cg, Claus Gittinger <cg@exept.de> * 9d1c44582a2f: #BUGFIX by cg, Claus Gittinger <cg@exept.de> * c922d4b60f5c: #UI_ENHANCEMENT by cg, Claus Gittinger <cg@exept.de> * 78205369e872: #REFACTORING by cg, Claus Gittinger <cg@exept.de> * 347f4ba07ade: #UI_ENHANCEMENT by exept, Claus Gittinger <cg@exept.de> * 949681aaf3e4: #BUGFIX by cg, Claus Gittinger <cg@exept.de> * 3885bb95a2b6: #BUGFIX by exept, Claus Gittinger <cg@exept.de> * 13f8aa8b3f4f: #REFACTORING by exept, Claus Gittinger <cg@exept.de> * be399ecb0f17: #OTHER by exept, Claus Gittinger <cg@exept.de> * 4d6dd403d27a: #REFACTORING by exept, Claus Gittinger <cg@exept.de> * 94a983e0d920: #QUALITY by exept, Claus Gittinger <cg@exept.de> * 031018e3a880: #FEATURE by exept, Claus Gittinger <cg@exept.de> * f183fd1a3c78: #FEATURE by exept, Claus Gittinger <cg@exept.de> * 52ddfab52152: #TUNING by exept, Claus Gittinger <cg@exept.de> * cherry-picked VT100TerminalView.st from 52ddfab52152: * 709732bf7fad: #FEATURE by cg, Claus Gittinger <cg@exept.de> * a44d0289bfbf: `TerminalView`: added (XTerm) keycodes for 'Del' and 'End' keys, Jan Vrany <jan.vrany@fit.cvut.cz> * 70d07365a2d4: Copyright updates, Jan Vrany <jan.vrany@fit.cvut.cz> * fc59a1fcfdcd: Cherry-picked changes to `TerminalView` from CVS, Jan Vrany <jan.vrany@fit.cvut.cz> * de050a54008a: #REFACTORING by exept, Claus Gittinger <cg@exept.de> * 129313185a4b: #OTHER by exept, Claus Gittinger <cg@exept.de> * 864d5890f58e: #OTHER by exept, Claus Gittinger <cg@exept.de> * 7bcfc51a71b7: #OTHER by exept, Claus Gittinger <cg@exept.de> * 9370e384470b: #FEATURE by exept, Claus Gittinger <cg@exept.de> * dc5757149f3e: #REFACTORING by exept, Claus Gittinger <cg@exept.de>

`VT100TerminalView`: fix "delete characters" control sequence ...that moved cursor to the left if more than one character was deleted, causing various bugs and malformed text (namely in GDB console). This commit is not a proper fix, merely a workaround that saves and restores cursor position after the (inherited) `basicDeleteCharsAtLine:...`.

`LinkButton`: Use `emphasisAtX:on:` instead of `emphasisAtPoint:on:`

#REFACTORING by cg class: DataSetColumn class definition changed: #drawLabelsAtX:y:h:from:to: #drawRendererInRow:x:y:width:value: #heightOfHighestRow #on:description:columnNumber:label: #shownValueForRow:rowNr: #width class: DataSetColumn class added: #editorType_CheckToggle #editorType_ComboBox #editorType_ComboList #editorType_InputField #editorType_None #editorType_PopUpList #editorType_RadioButton #editorType_Text #editorType_rowSelector #initialize (grafted from f2c20e0392a55097849538d7bcf9149edde59b3b)

#REFACTORING by cg class: HierarchicalListView class added: #example2 removed: #test

#REFACTORING by cg class: HierarchicalItem::Example changed: #children (send #label:icon: instead of #labeled:icon:, send #label: instead of #labeled:) class: HierarchicalItem::Example class added: #label: #label:icon: changed: #labeled: #labeled:icon:

#BUGFIX by cg class: TerminalView changed: #processInput:n:

#REFACTORING by stefan class: ProgressIndicator changed: #showBusyIndicatorDuring: class: ProgressIndicator class comment/format in: #inBoxWithLabel:icon:text:abortable:view:closeWhenDone: changed: #displayBusyIndicator:message:abortable:at:during:

#FEATURE by cg class: GnuplotGraphView class definition added: #gnuplotCommand #gnuplotCommand: changed: #generateImage #redrawX:y:width:height:

#BUGFIX by stefan class: FilenameWidgetWithHistory changed: #initialize

#BUGFIX by alkurz replacing deprecated function layout for adjust class: FilenameWidgetWithHistory changed: #initialize

#UI_ENHANCEMENT by cg class: CheckBox changed: #initialize

#BUGFIX by cg class: ExtendedComboBox changed: #openMenu (send #bePopUpView instead of #beUndecorated)

#REFACTORING by stefan class: DSVColumnView changed: #initStyle (send #passiveLevel instead of #offLevel) obsolete method usage

#UI_ENHANCEMENT by exept class: ImageEditView changed: #imageInfoString

#BUGFIX by stefan class: MenuPanel::Item changed: #openSubmenu Fix submenu position on multi-monitor configurations with different screen sizes.

#UI_ENHANCEMENT by exept class: TerminalView changed: #processInput:n:

#DOCUMENTATION by exept class: NoteBookView class comment/format in: #examples

#FEATURE by exept class: NoteBookView::Tab class definition added: #nameKey #nameKey:

#FEATURE by exept class: NoteBookView::Tab added: #labelString comment/format in: #label

#FEATURE by exept class: NoteBookView added: #tabList

#DOCUMENTATION by cg class: AbstractHierarchicalItem comment/format in: #hasIndicator

#BUGFIX by cg class: ImageView changed: #redrawX:y:width:height: #saveImageAs: #scrollToMakeVisible: care for redefined #image method

#DOCUMENTATION by cg class: ImageView comment/format in: #forceSmoothing #forceSmoothing: #forceSmoothingHolder

#REFACTORING by cg class: TerminalView changed: #initialize

#OTHER by cg bad english class: TableDrivenOutputAction class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachGreater class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachLess class comment/format in: #isCompatibleWithOutputType:

#OTHER by cg bad english class: TableDrivenOutputAction class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachGreater class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachLess class comment/format in: #isCompatibleWithOutputType:

#OTHER by cg bad english class: TableDrivenOutputAction class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachGreater class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachLess class comment/format in: #isCompatibleWithOutputType:

#OTHER by cg bad english class: TableDrivenOutputAction class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachGreater class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachLess class comment/format in: #isCompatibleWithOutputType:

#OTHER by cg bad english class: TableDrivenOutputAction class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachGreater class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachLess class comment/format in: #isCompatibleWithOutputType:

#OTHER by cg bad english class: TableDrivenOutputAction class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachGreater class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachLess class comment/format in: #isCompatibleWithOutputType:

#OTHER by cg bad english class: TableDrivenOutputAction class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachGreater class comment/format in: #isCompatibleWithOutputType: class: TableDrivenOutputAction::EachLess class comment/format in: #isCompatibleWithOutputType:

#FEATURE by cg class: DoWhatIMeanSupport changed: #withoutSelectorsUnlikelyFor:from:forPartial: FIX completion for class-side methods

#REFACTORING by exept class: LinkButton changed: #actionAt: #actionEmphasisIn:atPoint:

#DOCUMENTATION by exept class: LinkButton comment/format in: #actionAt:

#BUGFIX by exept class: NoteBookView tooltip bug fix changed: #helpText #helpTextForItemAt: class: NoteBookView::Tab category of: #activeHelpKey #activeHelpKey: #activeHelpText #activeHelpText:

update tags

#UI_ENHANCEMENT by exept class: NoteBookView::Tab limit the max size of a label (can be disabled to get the old behavior) class definition added: #shownLabel changed: #activeHelpText #displayOn:inset:direction:textRightInset: #getPrintableLabelFor: class: NoteBookView::Tab class added: #maxLabelSize #maxLabelSize:

#UI_ENHANCEMENT by cg class: TerminalView added: #outputEncoding: class: TerminalView class added: #openWithAction:setupTerminalViewWith:onExit: changed: #openWithAction:onExit:

#OTHER by exept do not refer to XPToolbarIconLibrary - ask ToolbarIconLibrary

#FEATURE by exept class: MenuPanel added: #grabMenuItemAtPoint: comment/format in: #itemAtPoint: changed: #processShortcut:

#UI_ENHANCEMENT by cg class: ImageEditView changed: #updateImageInfoFor:

#DOCUMENTATION by cg class: CheckBox comment/format in: #font: #initStyle class: CheckBox class changed: #updateStyleCache

#REFACTORING by exept class: MenuPanel comment/format in: #helpTextForItem: category of: #withMenuAndItemAt:do:

#FEATURE by exept class: FileSelectionItem changed: #imageType

update tags

#FEATURE by exept class: ImageView changed: #saveImageAs

update tags

#UI_ENHANCEMENT by cg class: SelectionInListModelView class definition changed: #drawSelectionFrameAt:x:w: #initStyle class: SelectionInListModelView class changed: #updateStyleCache

regenerated

#BUGFIX by cg class: TerminalView FIX: did not handle codePage correctly (output of CMD with diareses) class definition comment/format in: #readAnyAvailableData changed: #initialize #keyPress:x:y: #processInput:n: #sendInterruptSignal

#OTHER by cg added: #copyright

#OTHER by cg added: #copyright

#OTHER by cg added: #copyright

#BUGFIX by Stefan Reise do not cache #preferredExtent class: MenuPanel class definition comment/format in: #computePreferredExtent #menu: #openDelayed:afterSeconds: changed: #preferredExtent #preferredExtent: class: MenuPanel::Item comment/format in: #openDelayedSubmenu #openSubmenu

#DOCUMENTATION by cg class: CheckBox comment/format in: #sendChangeMessageWith:

#BUGFIX by Maren class: AbstractHierarchicalItem added: #from:to:doOnCachedChildren: #nonCriticalFrom:to:doOnCachedChildren: #nonCriticalRecursiveDoOnCachedChildren: #recursiveDoOnCachedChildren: changed: #recursiveExpand (send #canRecursiveExpand instead of #canExpand) * fix for recursiveExpand * add methods for doing stuff recursive without fetching lazy children

#REFACTORING by cg class: TerminalView changed: #initialize class: TerminalView class changed: #openWithAction:onExit:

#BUGFIX by cg class: TerminalView class changed: #openWithAction:onExit: for windows: xlate NL to CRNL on output

#FEATURE by Stefan Reise support multi monitor class: MenuPanel::Item changed: #openSubmenu

update tags

#FEATURE by stefan class: ProgressIndicator class comment/format in: #displayProgressNotifications:abortable:at:during: #displayProgressNotifications:message:abortable:at:during: changed: #inBoxWithLabel:icon:text:abortable:view:closeWhenDone: Can change message label via a ProgressNotification

#FEATURE by stefan class: ProgressNotification class definition comment/format in: #progressValue class: ProgressNotification class added: #progressPercentage:messageText: comment/format in: #progressPercentage:statusInfo: changed: #notify:progress: #progressPercentage:

#BUGFIX by cg class: TerminalView changed: #keyPress:x:y: Ctrl vs. Control - sigh

#BUGFIX by exept class: ImageEditView changed: #cropSubImageAt:

Merge

#FEATURE by exept class: VT100TerminalView changed: #reportTerminalType

#FEATURE by exept class: TabItem added: #printableLabel comment/format in: #label

#DOCUMENTATION by exept class: NoteBookView comment/format in: #listIndexOf:

#FEATURE by exept class: DSVColumnView comment/format in: #selectRow:

#FEATURE by exept class: NoteBookView added: #indexOfTabNamed:

#DOCUMENTATION by exept class: ExtendedComboBox added: #setupMenuWidgetForMenu: changed: #menuWidget: class: ExtendedComboBox class comment/format in: #examples

#DOCUMENTATION by exept class: SubCanvas changed: #rebuild

#BUGFIX by ca class: MenuPanel changed: #rearrangeItems class: MenuPanel::Item added: #setLayout:

#FEATURE by exept class: MenuPanel added: #itemForWhich:

#FEATURE by exept class: NoteBookView added: #tabForWhich:

#DOCUMENTATION by exept class: NoteBookView::Tab category of: #containsPointX:y: #intersects: #isEnabled

#FEATURE by exept class: MenuPanel::Item changed: #openDelayedSubmenu

#BUGFIX by exept class: NoteBookView changed: #keyPress:x:y:

#DOCUMENTATION by exept class: ColorMenu category of: #helpSpec

#OTHER by exept class: ResourceSpecEditor class category of: #helpSpec

#OTHER by exept class: ResourceSpecEditor class category of: #helpSpec

#REFACTORING by exept class: SelectionInListModelView added: #indexOfElementForWhich: changed: #selectElementForWhich:ifAbsent:

#DOCUMENTATION by exept class: ListModelView comment/format in: #yAbsoluteOfLine: #yVisibleOfLine:

#DOCUMENTATION by exept class: SelectionInListModelView comment/format in: #setSelection:

#DOCUMENTATION by exept class: MenuPanel::Item comment/format in: #preferredExtent

#BUGFIX by exept class: DoWhatIMeanSupport changed: #codeCompletionForLiteralSymbol:element:considerAll:into: #codeCompletionForSmalltalkMethod:orClass:context:codeView:into:

#REFACTORING by exept class: NoteBookView added: #tabsPosition #tabsPosition: changed: #direction #direction:

#BUGFIX by exept class: ImageEditView changed: #drawingColorOrNil #fillAt:

#BUGFIX by exept class: ImageEditView changed: #fillAt:

#BUGFIX by Maren class: AbstractHierarchicalItem changed: #recursiveDo:skipIf:skipChildrenIf: consider skip element and skip children during the whole recursion, not only for the first element

#BUGFIX by exept class: DoWhatIMeanSupport changed: #codeCompletionForSmalltalkMethod:orClass:context:codeView:into: colon-selector completion

#UI_ENHANCEMENT by exept class: SelectionInTreeView changed: #openEditor close on return.

#DOCUMENTATION by exept class: SelectionInTree comment/format in: #selectedNode

#UI_ENHANCEMENT by exept class: SelectionInTreeView changed: #keyPress:x:y: #openEditor

#DOCUMENTATION by exept class: ExtendedComboBox comment/format in: #processEvent:

#UI_ENHANCEMENT by exept class: SelectionInTreeView changed: #openEditor cursor - edit behavior

#REFACTORING by exept class: SelectionInTreeView changed: #openEditor leftover halt.

#UI_ENHANCEMENT by exept class: SelectionInTreeView changed: #keyPress:x:y: #openEditor much better keyboard control (eh in cdatum freeze value editor)

#FEATURE by exept class: ImageEditView new: blend colors class definition added: #pointBlendAt: comment/format in: #editMode #editMode: changed: #buttonMotion:x:y: #pointAt:width: class: ImageEditView class changed: #initialize

#UI_ENHANCEMENT by exept class: DoWhatIMeanSupport comment/format in: #codeCompletionForVariable:into: changed: #tryCodeCompletionWithSource:nodeInterval:at:mustBeExpression:into: class: DoWhatIMeanSupport class category of:16 methods

#FEATURE by exept class: MenuPanel changed: #dispatchEvent:withFocusOn:delegate: info about who delegated the event

#FEATURE by exept class: ExtendedComboBox::MenuWrapper changed: #forwardEvent:withFocusOn: info about who delegated the event

#REFACTORING by exept class: ListModelView changed: #startAutoScroll:distance: