#BUGFIX by stefan
class: SubCanvas
comment/format in: #updateFromChannels
changed: #rebuild
https://expeccoalm.exept.de/D299696
Scrollbars were not shown whn changing the subapplication.
(did not send #sizeChanged: if there was no layout).
remove code whose effects are overwritten by following actions
(setting extent:)
--- a/SubCanvas.st Sat Sep 15 12:25:22 2018 +0200
+++ b/SubCanvas.st Tue Sep 18 11:46:07 2018 +0200
@@ -404,19 +404,6 @@
]
].
- clientViewIsScrolled ifTrue:[
- (subWindowSpec notNil and:[subWindowSpec layout notNil]) ifTrue:[
- "/ mhmh - what should we base the size computation on ?
- "/ (I don't see any reason to look at the windows spec at all;
- "/ isn't the user of the spec the only one to control the size).
- clientView extent:(subWindowSpec bounds extent)
- ] ifFalse:[
- "/ clientView extent:(subWindowSpec bounds extent)
- ].
- self sizeChanged:nil. "/ to force recomputation of the scrollbar
- ] ifFalse:[
- "/ clientView extent:(clientView preferredExtent)
- ].
hasVScroller := hasHScroller := false.
subWindowSpec notNil ifTrue:[
hasVScroller := hasHorizontalScrollBar and:[subWindowSpec hasVerticalScrollBar].
@@ -442,6 +429,7 @@
clientViewIsScrolled ifTrue:[
scrolledView resizeScrolledViewVertical:hasVScroller not.
scrolledView resizeScrolledViewHorizontal:hasHScroller not.
+ self sizeChanged:nil. "/ to force recomputation of the scrollbar
] ifFalse:[
"/ self halt.
].
@@ -471,6 +459,7 @@
"Modified: / 30-01-2000 / 21:36:40 / cg"
"Modified: / 22-05-2018 / 18:50:47 / Claus Gittinger"
+ "Modified (comment): / 18-09-2018 / 11:43:24 / Stefan Vogel"
!
releaseAllComponents
@@ -502,12 +491,12 @@
clientHolder isNil ifTrue:[
newClient := self application.
"/ new code added Jun,7 2014 (used to always create new builder)
-useOwnBuilder ifFalse:[
- uiBuilder := newClient builder.
-] ifTrue:[
- uiBuilder := UIBuilder new.
- uiBuilder isSubBuilder:true.
-].
+ useOwnBuilder ifFalse:[
+ uiBuilder := newClient builder.
+ ] ifTrue:[
+ uiBuilder := UIBuilder new.
+ uiBuilder isSubBuilder:true.
+ ].
] ifFalse:[
newClient := clientHolder value
].
@@ -528,7 +517,8 @@
].
self client:newClient spec:newSpec builder:uiBuilder
- "Modified: / 5.8.1999 / 13:35:26 / cg"
+ "Modified: / 05-08-1999 / 13:35:26 / cg"
+ "Modified (format): / 18-09-2018 / 10:29:05 / Stefan Vogel"
! !
!SubCanvas methodsFor:'delegation'!