author | Jan Vrany <jan.vrany@fit.cvut.cz> |
Fri, 01 Mar 2013 10:42:50 +0100 | |
changeset 117 | d7f87303b984 |
parent 84 | 77e12dbe97d3 |
child 118 | 7e93ef8c5417 |
permissions | -rw-r--r-- |
71 | 1 |
"{ Package: 'stx:goodies/builder/reports' }" |
2 |
||
3 |
"{ NameSpace: Builder }" |
|
4 |
||
5 |
Report subclass:#LintReport |
|
6 |
instanceVariableNames:'environment rules' |
|
7 |
classVariableNames:'' |
|
8 |
poolDictionaries:'' |
|
9 |
category:'Builder-Reports' |
|
10 |
! |
|
11 |
||
12 |
||
13 |
!LintReport class methodsFor:'class initialization'! |
|
14 |
||
15 |
initialize |
|
16 |
||
17 |
Smalltalk loadPackage: 'stx:goodies/refactoryBrowser/lint'. |
|
18 |
||
19 |
"Modified: / 01-04-2011 / 12:58:47 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
20 |
! ! |
|
21 |
||
22 |
!LintReport methodsFor:'accessing - defaults'! |
|
23 |
||
24 |
defaultFileSuffix |
|
25 |
||
26 |
^ 'Lint' |
|
27 |
||
28 |
"Modified: / 08-10-2011 / 10:49:30 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
29 |
! |
|
30 |
||
31 |
defaultFormat |
|
32 |
"raise an error: must be redefined in concrete subclass(es)" |
|
33 |
||
34 |
^ LintReportFormat::PMD new |
|
35 |
||
36 |
"Modified: / 25-11-2011 / 22:06:33 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
79
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
37 |
! |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
38 |
|
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
39 |
defaultName |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
40 |
|
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
41 |
environment isNil ifTrue:[^super defaultName]. |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
42 |
^environment label |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
43 |
|
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
44 |
"Modified: / 25-11-2011 / 22:06:33 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
45 |
"Created: / 13-01-2012 / 12:43:07 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
71 | 46 |
! ! |
47 |
||
117
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
48 |
!LintReport methodsFor:'command line options'! |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
49 |
|
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
50 |
cmdlineOptionRuleset |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
51 |
|
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
52 |
^CmdLineOption new |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
53 |
short: $s; |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
54 |
long: 'ruleset'; |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
55 |
description: 'Rule set '; |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
56 |
action:[:option | |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
57 |
self setupRulesFrom: option. |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
58 |
]; |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
59 |
yourself |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
60 |
|
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
61 |
"Created: / 28-02-2013 / 23:13:57 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
62 |
! ! |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
63 |
|
71 | 64 |
!LintReport methodsFor:'generating'! |
65 |
||
66 |
generateClass: aClass |
|
67 |
| sourceStream sourceName | |
|
68 |
sourceStream := WriteStream on: String new. |
|
69 |
sourceName := self encodeFilename: (self sourceFilenameFor: aClass). |
|
70 |
||
71 |
format writeFile: sourceName with: [ |
|
72 |
self generateClass: aClass source: sourceStream. |
|
73 |
self generateClass: aClass class source: sourceStream. |
|
74 |
]. |
|
75 |
||
76 |
format writeSource: sourceStream contents to: sourceName |
|
77 |
||
78 |
"Created: / 06-10-2011 / 23:54:37 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
79 |
! |
|
80 |
||
81 |
generateClass: aClass selector: aSelector source: sourceStream |
|
82 |
| offset source matching | |
|
83 |
offset := self |
|
84 |
lineAndColumn: sourceStream contents |
|
85 |
at: sourceStream position. |
|
86 |
sourceStream |
|
87 |
nextPutAll: (source := self convert: (aClass sourceCodeAt: aSelector)); |
|
88 |
nextPut: Character lf; nextPut: Character lf. |
|
89 |
matching := rules select: [ :each | |
|
90 |
(self isSelectorEnvironment: each result) |
|
91 |
and: [ each result includesSelector: aSelector in: aClass ] ]. |
|
92 |
self generateViolations: matching class: aClass selector: aSelector source: source offset: offset |
|
93 |
||
94 |
"Created: / 07-10-2011 / 11:04:12 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
95 |
! |
|
96 |
||
97 |
generateClass: aClass source: sourceStream |
|
98 |
||
99 |
| offset source matching | |
|
100 |
offset := self |
|
101 |
lineAndColumn: sourceStream contents |
|
102 |
at: sourceStream position. |
|
103 |
sourceStream |
|
104 |
nextPutAll: (source := self convert: aClass definition); |
|
105 |
nextPut: Character lf; nextPut: Character lf. |
|
106 |
(environment definesClass: aClass) ifTrue: [ |
|
107 |
matching := rules select: [ :rule | |
|
108 |
(self isClassEnvironment: rule result) |
|
109 |
and: [ rule result includesClass: aClass ] ]. |
|
110 |
self generateViolations: matching class: aClass selector: nil source: source offset: offset ]. |
|
111 |
(environment selectorsForClass: aClass) asSortedCollection |
|
112 |
do: [ :selector | self generateClass: aClass selector: selector source: sourceStream] |
|
113 |
||
114 |
"Created: / 07-10-2011 / 10:29:42 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
115 |
! |
|
116 |
||
117 |
generateViolations: aCollection class: aClass selector: aSelector source: aString offset: aPoint |
|
118 |
||
119 |
aCollection do: [ :rule | |
|
120 |
| interval start stop | |
|
121 |
||
122 |
interval := (rule result selectionIntervalFor: aString) ifNil: [ 1 to: aString size ]. |
|
123 |
start := self lineAndColumn: aString at: interval first. |
|
124 |
stop := self lineAndColumn: aString at: interval last. |
|
125 |
||
126 |
format writeViolation: rule |
|
127 |
class: aClass selector: aSelector |
|
128 |
startLine: aPoint x + start x column: aPoint y + start y - 1 |
|
129 |
stopLine: aPoint x + stop x column: aPoint y + stop y - 1. |
|
130 |
] |
|
131 |
||
132 |
"Created: / 25-11-2011 / 22:23:09 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
133 |
! ! |
|
134 |
||
135 |
!LintReport methodsFor:'initialization'! |
|
136 |
||
137 |
setupForClasses: classes |
|
138 |
||
139 |
environment := BrowserEnvironment new forClasses: classes. |
|
140 |
environment label: name |
|
141 |
||
142 |
"Created: / 04-08-2011 / 14:40:31 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
143 |
! |
|
144 |
||
145 |
setupForPackages: packages |
|
146 |
||
79
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
147 |
packages isEmpty ifTrue:[^self]. |
71 | 148 |
environment := PackageEnvironment |
149 |
onEnvironment: BrowserEnvironment new |
|
150 |
packageNames: packages. |
|
79
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
151 |
name isNil ifTrue:[ |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
152 |
packages size > 1 ifTrue:[ |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
153 |
name := packages size printString , ' packages'. |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
154 |
] ifFalse:[ |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
155 |
name := packages anElement |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
156 |
] |
889d3747a0a8
Fix in default report file name for LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
71
diff
changeset
|
157 |
]. |
71 | 158 |
|
159 |
environment label: name. |
|
160 |
||
161 |
" |
|
162 |
LintReport runPackage:'stx:goodies/monticello'. |
|
163 |
LintReport runPackage:'stx:libjava' |
|
164 |
" |
|
165 |
||
166 |
"Created: / 04-08-2011 / 14:40:06 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
167 |
! ! |
|
168 |
||
169 |
!LintReport methodsFor:'private'! |
|
170 |
||
171 |
lineAndColumn: aString at: anInteger |
|
172 |
| line last stream | |
|
173 |
line := 1. |
|
174 |
last := 0. |
|
175 |
stream := aString readStream. |
|
176 |
[ (stream nextLine isNil or: [ anInteger <= stream position ]) |
|
177 |
ifTrue: [ ^ line @ (anInteger - last) ]. |
|
178 |
last := stream position. |
|
179 |
line := line + 1 ] |
|
180 |
repeat |
|
181 |
! |
|
182 |
||
183 |
sourceFilenameFor: aClass |
|
184 |
||
185 |
| fn | |
|
186 |
||
187 |
fn := aClass package asString replaceAll:$: with:$_;replaceAll:$/ with:$_. |
|
188 |
fn := fn , '_' , (aClass asString copyReplaceAll:$: with: $_), '.' , aClass programmingLanguage sourceFileSuffix. |
|
189 |
||
190 |
^self encodeFilename: fn. |
|
191 |
||
192 |
" |
|
193 |
Builder::LintReportFormat::CheckStyle basicNew |
|
194 |
sourceFilenameFor: Class |
|
195 |
||
196 |
Builder::LintReportFormat::CheckStyle basicNew |
|
197 |
sourceFilenameFor: Builder::LintReportFormat |
|
198 |
" |
|
199 |
||
200 |
"Created: / 07-10-2011 / 09:06:00 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
201 |
! ! |
|
202 |
||
203 |
!LintReport methodsFor:'running'! |
|
204 |
||
205 |
runReport |
|
82 | 206 |
| wasTryLocalSources | |
71 | 207 |
|
82 | 208 |
[ |
209 |
wasTryLocalSources := Class tryLocalSourceFirst. |
|
84 | 210 |
Class tryLocalSourceFirst: true. |
82 | 211 |
SmalllintChecker |
212 |
runRule: (RBCompositeLintRule rules: rules) |
|
213 |
onEnvironment: environment. |
|
71 | 214 |
|
82 | 215 |
(environment classes asSortedCollection: [ :a :b | a name <= b name ]) |
216 |
do: [ :class | self generateClass: class]. |
|
217 |
] ensure:[ |
|
218 |
Class tryLocalSourceFirst: wasTryLocalSources |
|
219 |
] |
|
71 | 220 |
|
84 | 221 |
"Modified: / 23-01-2012 / 09:04:55 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
71 | 222 |
! |
223 |
||
224 |
setUp |
|
225 |
||
226 |
super setUp. |
|
117
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
227 |
rules isNil ifTrue:[ |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
228 |
rules := (RBCompositeLintRule rulesFor: RBBasicLintRule) |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
229 |
reject: [ :each | each class name endsWith: 'SpellingRule' ] |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
230 |
]. |
71 | 231 |
|
232 |
"Created: / 04-08-2011 / 14:35:27 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
117
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
233 |
"Modified: / 28-02-2013 / 23:18:57 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
234 |
! |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
235 |
|
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
236 |
setupRulesFrom: filename |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
237 |
| file | |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
238 |
file := filename asFilename. |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
239 |
file readingFileDo:[:s| |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
240 |
| spec | |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
241 |
spec := Parser parseLiteralArray: s. |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
242 |
rules := spec decodeAsLiteralArray rules. |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
243 |
] |
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
244 |
|
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
245 |
"Created: / 28-02-2013 / 23:17:41 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
71 | 246 |
! ! |
247 |
||
248 |
!LintReport methodsFor:'testing'! |
|
249 |
||
250 |
isClassEnvironment: anEnvironment |
|
251 |
^ #(CategoryEnvironment ClassEnvironment VariableEnvironment) includes: anEnvironment class name |
|
252 |
! |
|
253 |
||
254 |
isSelectorEnvironment: anEnvironment |
|
255 |
^ #(SelectorEnvironment ParseTreeEnvironment VariableEnvironment) includes: anEnvironment class name |
|
256 |
! ! |
|
257 |
||
258 |
!LintReport class methodsFor:'documentation'! |
|
259 |
||
260 |
version |
|
261 |
^ '$Header$' |
|
262 |
! |
|
263 |
||
264 |
version_CVS |
|
265 |
^ '$Header$' |
|
266 |
! |
|
267 |
||
268 |
version_SVN |
|
269 |
^ '§Id: Builder__LintReport.st 293 2011-11-25 21:42:31Z vranyj1 §' |
|
270 |
! ! |
|
271 |
||
117
d7f87303b984
class: Builder::LintReport
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
84
diff
changeset
|
272 |
|
71 | 273 |
LintReport initialize! |