Fix random test fails of when creating process
The fix allows limits the random string to contain
only 0-9, a-z and A-Z characters. This is to prevent
different type of errors like ERROR_OTHER:, which
are irrelevant to the testing, to appear.
--- a/RegressionTests__Win32OperatingSystemTest.st Wed Nov 24 11:34:33 2021 +0000
+++ b/RegressionTests__Win32OperatingSystemTest.st Fri May 20 14:06:23 2022 +0200
@@ -4,7 +4,7 @@
COPYRIGHT (c) Claus Gittinger / eXept Software AG
COPYRIGHT (c) 2016 Jan Vrany
COPYRIGHT (c) 2021 svestkap
- COPYRIGHT (c) 2021 Patrik Svestka
+ COPYRIGHT (c) 2021-2022 Patrik Svestka
All Rights Reserved
This software is furnished under a license and may be used
@@ -32,7 +32,7 @@
COPYRIGHT (c) Claus Gittinger / eXept Software AG
COPYRIGHT (c) 2016 Jan Vrany
COPYRIGHT (c) 2021 svestkap
- COPYRIGHT (c) 2021 Patrik Svestka
+ COPYRIGHT (c) 2021-2022 Patrik Svestka
All Rights Reserved
This software is furnished under a license and may be used
@@ -577,7 +577,7 @@
| beyondCreateProcessArgumentsLimit commandLine savedException |
beyondCreateProcessArgumentsLimit := 4096.
- commandLine := RandomGenerator new nextCharacters: beyondCreateProcessArgumentsLimit.
+ commandLine := RandomGenerator new nextLettersOrDigits: beyondCreateProcessArgumentsLimit.
self assert: commandLine size = beyondCreateProcessArgumentsLimit.
self should: [
@@ -596,7 +596,7 @@
self deny: savedException willProceed
"Created: / 21-10-2021 / 12:16:53 / svestkap"
- "Modified (comment): / 26-11-2021 / 09:49:21 / Patrik Svestka <patrik.svestka@gmail.com>"
+ "Modified: / 20-05-2022 / 13:58:24 / Patrik Svestka <patrik.svestka@gmail.com>"
!
testExecWithTooLongCommandLine2
@@ -605,7 +605,7 @@
beyondCreateProcessArgumentsLimit := 4097.
"/ created random String size 4097
- commandLine := RandomGenerator new nextCharacters: beyondCreateProcessArgumentsLimit.
+ commandLine := RandomGenerator new nextLettersOrDigits: beyondCreateProcessArgumentsLimit.
self assert: commandLine size = beyondCreateProcessArgumentsLimit.
handle := Win32OperatingSystem::Win32ProcessHandle new.
@@ -627,6 +627,7 @@
self assert: handle isNil.
"Created: / 21-10-2021 / 12:17:02 / svestkap"
+ "Modified: / 20-05-2022 / 13:58:16 / Patrik Svestka <patrik.svestka@gmail.com>"
!
testExecWithTooLongCommandPath
@@ -634,7 +635,7 @@
| beyondCreateProcessArgumentsLimit commandPath savedException |
beyondCreateProcessArgumentsLimit := 4096.
- commandPath := RandomGenerator new nextCharacters: beyondCreateProcessArgumentsLimit.
+ commandPath := RandomGenerator new nextLettersOrDigits: beyondCreateProcessArgumentsLimit.
self assert: commandPath size = beyondCreateProcessArgumentsLimit.
self should: [
@@ -653,7 +654,7 @@
self deny: savedException willProceed
"Created: / 21-10-2021 / 12:18:26 / svestkap"
- "Modified (comment): / 26-11-2021 / 09:49:30 / Patrik Svestka <patrik.svestka@gmail.com>"
+ "Modified: / 20-05-2022 / 13:58:09 / Patrik Svestka <patrik.svestka@gmail.com>"
!
testExecWithTooLongCommandPath2
@@ -662,7 +663,7 @@
beyondCreateProcessArgumentsLimit := 4097.
"/ created random String size 4097
- commandPath := RandomGenerator new nextCharacters: beyondCreateProcessArgumentsLimit.
+ commandPath := RandomGenerator new nextLettersOrDigits: beyondCreateProcessArgumentsLimit.
self assert: commandPath size = beyondCreateProcessArgumentsLimit.
handle := Win32OperatingSystem::Win32ProcessHandle new.
@@ -684,6 +685,7 @@
self assert: handle isNil.
"Created: / 21-10-2021 / 12:19:37 / svestkap"
+ "Modified: / 20-05-2022 / 13:58:03 / Patrik Svestka <patrik.svestka@gmail.com>"
!
testExecWithTooLongDirName
@@ -691,7 +693,7 @@
| beyondCreateProcessArgumentsLimit dirName savedException |
beyondCreateProcessArgumentsLimit := 4096.
- dirName := RandomGenerator new nextCharacters: beyondCreateProcessArgumentsLimit.
+ dirName := RandomGenerator new nextLettersOrDigits: beyondCreateProcessArgumentsLimit.
self assert: dirName size = beyondCreateProcessArgumentsLimit.
self should: [
@@ -710,7 +712,7 @@
self deny: savedException willProceed
"Created: / 21-10-2021 / 12:22:38 / svestkap"
- "Modified (comment): / 26-11-2021 / 09:49:38 / Patrik Svestka <patrik.svestka@gmail.com>"
+ "Modified: / 20-05-2022 / 13:32:50 / Patrik Svestka <patrik.svestka@gmail.com>"
!
testExecWithTooLongDirName2
@@ -718,7 +720,7 @@
| beyondCreateProcessArgumentsLimit dirName handle |
beyondCreateProcessArgumentsLimit := 4097.
- dirName := RandomGenerator new nextCharacters: beyondCreateProcessArgumentsLimit.
+ dirName := RandomGenerator new nextLettersOrDigits: beyondCreateProcessArgumentsLimit.
self assert: dirName size = beyondCreateProcessArgumentsLimit.
handle := Win32OperatingSystem::Win32ProcessHandle new.
@@ -740,6 +742,7 @@
self assert: handle isNil.
"Created: / 21-10-2021 / 12:21:54 / svestkap"
+ "Modified: / 20-05-2022 / 13:35:31 / Patrik Svestka <patrik.svestka@gmail.com>"
! !
!Win32OperatingSystemTest methodsFor:'tests'!