Fixed default filter with missing argument in CustomMenuBuilder
authorJakub Nesveda <jakubnesveda@seznam.cz>
Mon, 29 Dec 2014 09:37:10 +0100
changeset 791 85851bd35faa
parent 790 88f2832e656a
child 792 191ce991bfdf
Fixed default filter with missing argument in CustomMenuBuilder
CustomMenuBuilder.st
CustomMenuBuilderTests.st
--- a/CustomMenuBuilder.st	Sun Dec 28 23:45:41 2014 +0100
+++ b/CustomMenuBuilder.st	Mon Dec 29 09:37:10 2014 +0100
@@ -290,11 +290,11 @@
 
     menu := Menu new.
     submenuLabel := 'Unknown menu label'.
-    generatorOrRefactoringFilter := [ true ].
+    generatorOrRefactoringFilter := [ :generatorOrRefactoring | true ].
     resources := self class classResources.
     manager := CustomManager current.
 
-    "Modified: / 28-12-2014 / 11:05:27 / Jakub Nesveda <nesvejak@fit.cvut.cz>"
+    "Modified (format): / 29-12-2014 / 09:34:39 / Jakub Nesveda <nesvejak@fit.cvut.cz>"
 ! !
 
 !CustomMenuBuilder class methodsFor:'documentation'!
--- a/CustomMenuBuilderTests.st	Sun Dec 28 23:45:41 2014 +0100
+++ b/CustomMenuBuilderTests.st	Mon Dec 29 09:37:10 2014 +0100
@@ -198,6 +198,46 @@
     "Created: / 28-12-2014 / 22:48:24 / Jakub Nesveda <nesvejak@fit.cvut.cz>"
 !
 
+test_build_menu_two_generators_without_filter
+    | expectedMenu actualMenu navigationState |
+
+    expectedMenu := {
+        'Label_01'.
+        'Label_02'. 
+        'Translated BunchOfGenerators'. 
+        {'Translated Generator_01'. 'Translated Generator_02'. 'Translated Generator_03'}.
+        'Label_03'.
+    }.
+
+    self
+        addGenerator: 'Generator_01' group: #();
+        addGenerator: 'Generator_02' group: #();
+        addGenerator: 'Generator_03' group: #().
+
+    "Create some methods which actually uses context and perspective to be sure that they are correctly created"
+    provider last
+        compileMockMethod: 'availableInPerspective: perspective ^ perspective isClassPerspective';
+        compileMockMethod: 'availableInContext: context ^ contect selectedClasses first == CustomMenuBuilderTests'.
+
+    navigationState := Tools::NavigationState new.
+    navigationState selectedClasses value: {CustomMenuBuilderTests}.
+
+    builder
+        perspective: CustomPerspective classPerspective;
+        menu: menu;
+        submenuLabel: 'BunchOfGenerators';
+        afterMenuItemLabeled: 'Label_02';
+        navigationState: navigationState;
+        resources: resources;
+        buildMenu.    
+
+    actualMenu := self menuItemLabels.
+
+    self assert: expectedMenu = actualMenu
+
+    "Created: / 29-12-2014 / 09:33:20 / Jakub Nesveda <nesvejak@fit.cvut.cz>"
+!
+
 test_groups_sort_block
     | expectedGroups actualGroups |