#REFACTORING by stefan
authorStefan Vogel <sv@exept.de>
Thu, 05 Dec 2019 17:58:42 +0100
changeset 25070 26915eb67235
parent 25069 f82e303cd35d
child 25071 26168f32e114
#REFACTORING by stefan class: OSProcess changed: #startProcess
OSProcess.st
--- a/OSProcess.st	Thu Dec 05 15:11:46 2019 +0100
+++ b/OSProcess.st	Thu Dec 05 17:58:42 2019 +0100
@@ -1064,9 +1064,9 @@
 
     callingProcess := Processor activeProcess.
     
-    Processor 
+    pid := Processor 
         monitor:[
-            pid := OperatingSystem
+            OperatingSystem
                         startProcess:(self startCommand)
                         inputFrom:externalInStream
                         outputTo:externalOutStream
@@ -1122,12 +1122,7 @@
     externalInStream := externalAuxInStream := externalAuxOutStream := externalOutStream := externalErrorStream := nil.
     
     pid isNil ifTrue:[
-        UserPreferences current logExecutedOSCommands ifTrue:[
-            Transcript 
-                showCR:(('OS command failed: %1'bindWith: self startCommand) allRed).  
-        ].
-
-        "process could not be started - terminate shufflers"
+        "process could not be started!!"
         self terminateShufflerProcesses.
 
         exitStatus := OperatingSystem osProcessStatusClass processCreationFailure.
@@ -1135,6 +1130,11 @@
         terminateActionBlock notNil ifTrue:[
             terminateActionBlock valueWithOptionalArgument:exitStatus and:self.
         ].
+        UserPreferences current logExecutedOSCommands ifTrue:[
+            Transcript 
+                showCR:(('OS command failed: %1'bindWith: self startCommand) allRed).  
+        ].
+
         ^ false.
     ].