subProjects are no prerequisites
authorStefan Vogel <sv@exept.de>
Mon, 08 Jun 2009 18:37:44 +0200
changeset 11752 484d542ad43f
parent 11751 1e75c54748ef
child 11753 498aaf09d52b
subProjects are no prerequisites
ProjectDefinition.st
--- a/ProjectDefinition.st	Mon Jun 08 18:36:09 2009 +0200
+++ b/ProjectDefinition.st	Mon Jun 08 18:37:44 2009 +0200
@@ -103,10 +103,11 @@
     toAdd := Set new.
     toAdd addAll:self effectivePreRequisites.
 
-    "are subprojects really a prerequisite??
-     I think, they are not, so this line should be deleted.
-     Unfortunately the meaning of 'subproject' has never been defined. SV."
-    toAdd addAll:self effectiveSubProjects.
+    "is a subproject really a prerequisite??
+     No, it works the other way: parent projects are prerequisites of sub projects,
+     so the following line has been deleted.
+     Unfortunately the meaning of 'subproject' has never been well defined. SV."
+"/    toAdd addAll:self effectiveSubProjects.
 
     [toAdd notEmpty] whileTrue:[
         |aPreRequisiteProjectID def|
@@ -124,6 +125,8 @@
                     thenDo:[:eachSubPreRequisite | 
                                 Transcript showCR:(aPreRequisiteProjectID, ' requires ', eachSubPreRequisite).
                                 toAdd add:eachSubPreRequisite ].
+
+                "but subprojects of our prerequisites are also prerequisites"
                 def effectiveSubProjects 
                     select:[:eachSubSubRequisite | (setOfAllPreRequisites includes:eachSubSubRequisite) not]
                     thenDo:[:eachSubSubRequisite | 
@@ -4183,7 +4186,7 @@
 !ProjectDefinition class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libbasic/ProjectDefinition.st,v 1.219 2009-05-25 13:46:30 stefan Exp $'
+    ^ '$Header: /cvs/stx/stx/libbasic/ProjectDefinition.st,v 1.220 2009-06-08 16:37:44 stefan Exp $'
 ! !
 
 ProjectDefinition initialize!