author | Jan Vrany <jan.vrany@fit.cvut.cz> |
Fri, 07 Sep 2012 11:45:07 +0100 | |
branch | jv |
changeset 3081 | 712525843aef |
parent 3065 | c60f15e53fce |
child 3084 | 0288b25613a9 |
permissions | -rw-r--r-- |
3012 | 1 |
" |
2 |
COPYRIGHT (c) 2006 by eXept Software AG |
|
3 |
All Rights Reserved |
|
4 |
||
5 |
This software is furnished under a license and may be used |
|
6 |
only in accordance with the terms of that license and with the |
|
7 |
inclusion of the above copyright notice. This software may not |
|
8 |
be provided or otherwise made available to, or used by, any |
|
9 |
other person. No title to or ownership of the software is |
|
10 |
hereby transferred. |
|
11 |
" |
|
2707 | 12 |
"{ Package: 'stx:libbasic3' }" |
13 |
||
14 |
Object subclass:#ProjectChecker |
|
3064 | 15 |
instanceVariableNames:'package packageDef classes methods problems phase' |
2707 | 16 |
classVariableNames:'' |
17 |
poolDictionaries:'' |
|
18 |
category:'System-Support-Projects' |
|
19 |
! |
|
20 |
||
21 |
!ProjectChecker class methodsFor:'documentation'! |
|
22 |
||
3012 | 23 |
copyright |
24 |
" |
|
25 |
COPYRIGHT (c) 2006 by eXept Software AG |
|
26 |
All Rights Reserved |
|
27 |
||
28 |
This software is furnished under a license and may be used |
|
29 |
only in accordance with the terms of that license and with the |
|
30 |
inclusion of the above copyright notice. This software may not |
|
31 |
be provided or otherwise made available to, or used by, any |
|
32 |
other person. No title to or ownership of the software is |
|
33 |
hereby transferred. |
|
34 |
" |
|
35 |
! |
|
36 |
||
2707 | 37 |
documentation |
38 |
" |
|
39 |
A simple project checker that can search whole projects or individual |
|
3064 | 40 |
classes or methods for various problems that may cause build problems such |
41 |
as: |
|
42 |
- inconsistent/messed up project definition class |
|
43 |
- method code problems |
|
2707 | 44 |
|
45 |
NOTE: Not yet finished. This code is meant as a single central entry for all the |
|
46 |
source code management tools like SCM Utilities, NewSystemBrowser ets. That code |
|
3019 | 47 |
will be refactored later once this tool prooves itself useful and mature enough. |
2707 | 48 |
|
49 |
[author:] |
|
50 |
Jan Vrany <jan.vrany@fit.cvut.cz> |
|
51 |
||
52 |
[instance variables:] |
|
53 |
||
54 |
[class variables:] |
|
55 |
||
56 |
[see also:] |
|
3064 | 57 |
Tools::ProjectCheckerBrowser |
2707 | 58 |
|
59 |
" |
|
60 |
! |
|
61 |
||
62 |
examples |
|
63 |
||
64 |
" |
|
65 |
ProjectChecker check: 'stx:libbasic' |
|
3019 | 66 |
ProjectChecker check: 'stx:libtool' |
67 |
ProjectChecker check: 'stx:libbasic3' |
|
2707 | 68 |
" |
69 |
! ! |
|
70 |
||
3064 | 71 |
!ProjectChecker class methodsFor:'instance creation'! |
72 |
||
73 |
forPackage: packageId |
|
74 |
^self new |
|
75 |
package: packageId; |
|
76 |
yourself. |
|
77 |
||
78 |
"Created: / 25-07-2012 / 18:00:06 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
79 |
! ! |
|
80 |
||
2707 | 81 |
!ProjectChecker class methodsFor:'checking'! |
82 |
||
83 |
check: package |
|
84 |
||
85 |
^self new check: package |
|
86 |
||
87 |
"Created: / 11-01-2012 / 16:46:38 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
88 |
! ! |
|
89 |
||
90 |
!ProjectChecker methodsFor:'accessing'! |
|
91 |
||
3019 | 92 |
classes: aCollection |
93 |
classes := aCollection. |
|
94 |
||
95 |
"Created: / 13-02-2012 / 17:06:31 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
96 |
! |
|
97 |
||
98 |
methods |
|
99 |
^ methods |
|
100 |
! |
|
101 |
||
102 |
methods:something |
|
103 |
methods := something. |
|
104 |
! |
|
105 |
||
2707 | 106 |
package |
107 |
^ package |
|
108 |
! |
|
109 |
||
110 |
package:packageId |
|
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
111 |
package := packageId asSymbol. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
112 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
113 |
"Modified: / 11-04-2012 / 16:00:23 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
3018
9eb47024eba1
added #problems to ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3012
diff
changeset
|
114 |
! |
9eb47024eba1
added #problems to ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3012
diff
changeset
|
115 |
|
9eb47024eba1
added #problems to ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3012
diff
changeset
|
116 |
problems |
3064 | 117 |
^ problems |
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
118 |
|
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
119 |
"Modified: / 23-02-2012 / 15:14:24 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
2707 | 120 |
! ! |
121 |
||
122 |
!ProjectChecker methodsFor:'checking'! |
|
123 |
||
124 |
check |
|
125 |
||
3064 | 126 |
problems := OrderedCollection new. |
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
127 |
packageDef := ProjectDefinition definitionClassForPackage: package. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
128 |
packageDef isNil ifTrue:[ |
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
129 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
130 |
(ProjectProblem newProjectDefinitionDoesNotExist package: package). |
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
131 |
^self |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
132 |
]. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
133 |
|
2707 | 134 |
self |
135 |
checkPackage; |
|
136 |
checkClasses; |
|
137 |
checkMethods |
|
138 |
||
139 |
"Created: / 11-01-2012 / 16:47:21 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
140 |
! |
|
141 |
||
142 |
check: package |
|
143 |
||
144 |
self package: package. |
|
145 |
self check. |
|
146 |
||
147 |
"Created: / 11-01-2012 / 16:47:21 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
148 |
! ! |
|
149 |
||
150 |
!ProjectChecker methodsFor:'checks-individual'! |
|
151 |
||
152 |
checkClassListConsistency |
|
153 |
"Checks whether all classes listed in #classNamesAndAttributes are present |
|
154 |
and if all present classes are listed" |
|
155 |
||
3065 | 156 |
|classesInImage classesInDescription onlyInDescription| |
2707 | 157 |
"WARNING: Copy/paste of ProjectDefinition>>validateDescription" |
158 |
||
159 |
classesInImage := Smalltalk allClasses select:[:cls | (cls package = self package) and:[cls isPrivate not]]. |
|
160 |
"/ classesInDescription := self classes asIdentitySet. |
|
161 |
classesInDescription := IdentitySet new. |
|
162 |
((packageDef compiled_classNamesForPlatform:(OperatingSystem platformName)) |
|
163 |
, (packageDef compiled_classNames_common) |
|
164 |
, (packageDef autoloaded_classNames)) do:[:nm | |
|
165 |
|cls| |
|
166 |
||
167 |
cls := Smalltalk at:nm asSymbol. |
|
168 |
cls isNil ifTrue:[ |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
169 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
170 |
(ProjectProblem newClassListedButDoesNotExist className: nm) |
2707 | 171 |
] ifFalse:[ |
172 |
classesInDescription add:cls. |
|
173 |
]. |
|
174 |
]. |
|
175 |
||
176 |
classesInDescription do:[:eachClass | |
|
177 |
eachClass sharedPoolNames do:[:eachPoolName | |
|
178 |
|pool| |
|
179 |
||
180 |
pool := eachClass nameSpace classNamed:eachPoolName. |
|
181 |
pool isNil ifTrue:[ |
|
182 |
eachClass nameSpace ~~ Smalltalk ifTrue:[ |
|
183 |
pool := Smalltalk classNamed:eachPoolName. |
|
184 |
] |
|
185 |
]. |
|
186 |
pool isNil ifTrue:[ |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
187 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
188 |
(ProjectProblem newClassUsesPoolButItDoesNotExist |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
189 |
className: eachClass name; |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
190 |
poolName: eachPoolName). |
2707 | 191 |
] ifFalse:[ |
192 |
pool isSharedPool ifFalse:[ |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
193 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
194 |
(ProjectProblem newClassUsesPoolButItIsNotASharedPool |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
195 |
className: eachClass name; |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
196 |
poolName: eachPoolName). |
2707 | 197 |
]. |
198 |
]. |
|
199 |
]. |
|
200 |
]. |
|
201 |
||
202 |
classesInImage ~= classesInDescription ifTrue:[ |
|
3065 | 203 |
"This is done later in checkClassesListedInProjectDefinition:" |
204 |
"/ onlyInImage := (classesInImage reject:[:cls | classesInDescription includes:cls]). |
|
205 |
"/ onlyInImage do:[:cls| |
|
206 |
"/ self addProblem: |
|
207 |
"/ (ProjectProblem newClassNotListed className: cls name). |
|
208 |
"/ ]. |
|
2707 | 209 |
onlyInDescription := (classesInDescription reject:[:cls | classesInImage includes:cls]). |
210 |
onlyInDescription do:[:cls| |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
211 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
212 |
(ProjectProblem newClassListedButDoesNotExist className: cls name) |
2707 | 213 |
]. |
214 |
]. |
|
215 |
||
216 |
"Created: / 11-01-2012 / 17:14:33 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
2718 | 217 |
! |
218 |
||
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
219 |
checkClassesListedInProjectDefinition: classesToCheck |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
220 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
221 |
| classNamesListed | |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
222 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
223 |
classNamesListed := packageDef classNames. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
224 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
225 |
classesToCheck do:[:class| |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
226 |
(class isPrivate not and:[(classNamesListed includes: class name) not]) ifTrue:[ |
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
227 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
228 |
(ProjectProblem newClassNotListed className: class name). |
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
229 |
] |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
230 |
]. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
231 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
232 |
"Created: / 13-02-2012 / 18:18:17 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
233 |
! |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
234 |
|
2718 | 235 |
checkExtensionsListConsistency |
236 |
"Checks whether all extensions listed in #extensionMethodNames are present |
|
237 |
and if all extension methods are listed" |
|
238 |
||
239 |
| extensionsListed extensionsPresent | |
|
240 |
||
241 |
extensionsListed := OrderedCollection new. |
|
242 |
packageDef extensionMethodNames pairWiseDo:[:cls :sel| |
|
243 |
extensionsListed add: (Array with: cls with: sel) |
|
244 |
]. |
|
245 |
extensionsPresent := OrderedCollection new. |
|
246 |
packageDef searchForExtensions do:[:each| |
|
3081 | 247 |
"JV@2012-09-07: Do not take Java methods into an account, they |
248 |
should not be listed in extensionMethodNames. |
|
249 |
They are loaded lazily by JavaClassReader and if listed here, |
|
250 |
they would cause an error if the package is loaded from source. |
|
251 |
Sort of a HACK, indeed" |
|
252 |
each mclass isJavaClass ifFalse:[ |
|
253 |
extensionsPresent add: (Array with: each mclass name with: each selector) |
|
254 |
]. |
|
2718 | 255 |
]. |
256 |
||
257 |
(extensionsListed \ extensionsPresent) do:[:clsAndSel| |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
258 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
259 |
(ProjectProblem newExtensionMethodListedButDoesNotExist |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
260 |
className: clsAndSel first selector: clsAndSel second). |
2718 | 261 |
]. |
262 |
||
263 |
(extensionsPresent \ extensionsListed) do:[:clsAndSel| |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
264 |
self addProblem: |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
265 |
(ProjectProblem newExtensionMethodNotListed |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
266 |
className: clsAndSel first selector: clsAndSel second). |
2718 | 267 |
]. |
268 |
||
269 |
"Created: / 12-01-2012 / 12:31:55 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
270 |
! |
|
271 |
||
272 |
checkExtensionsPrerequisites |
|
273 |
"Checks whether packages of all extensions method classes are listed |
|
274 |
in package prerequisites" |
|
275 |
||
276 |
packageDef searchForExtensions do:[:mthd| |
|
277 |
(packageDef preRequisites includes: mthd mclass package) ifFalse:[ |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
278 |
"/ self problem: ('%3 required by extension method but not in prerequisites' bindWith: mthd mclass package) |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
279 |
"/ description: ('An extension method %1>>%2 extends class in package %3 but the package is not listed in package''s prerequisited. This leads into missing methods and strange bugs when application is compiled and run!!' bindWith: mthd class with: mthd selector with: mthd class package) |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
280 |
"/ severity: #error data: mthd |
2718 | 281 |
]. |
282 |
] |
|
283 |
||
284 |
"Created: / 12-01-2012 / 12:41:40 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
285 |
! |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
286 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
287 |
checkForMethodsInNoProject: classesToCheck |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
288 |
| checker | |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
289 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
290 |
checker := [:cls| |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
291 |
cls selectorsAndMethodsDo:[:sel :mth| |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
292 |
(mth package isNil or:[mth package == PackageId noProjectID]) ifTrue:[ |
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
293 |
"Sigh, special hack for Expecco" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
294 |
(cls name = 'Expecco::AbstractApplication class' and:[sel = 'flags']) ifFalse:[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
295 |
self addProblem: |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
296 |
(ProjectProblem newMethodInNoPackage |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
297 |
className: cls name selector: sel). |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
298 |
] |
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
299 |
] |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
300 |
] |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
301 |
]. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
302 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
303 |
classesToCheck do:[:class| |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
304 |
checker value: class theMetaclass. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
305 |
checker value: class theNonMetaclass. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
306 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
307 |
] |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
308 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
309 |
"Created: / 13-02-2012 / 18:18:18 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
310 |
! |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
311 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
312 |
checkMethodCodingStyle: method |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
313 |
"Checks for various coding style violations such as 'self halt' or |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
314 |
improper indentation :-)" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
315 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
316 |
"To be implemented" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
317 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
318 |
"Created: / 11-04-2012 / 12:38:59 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
319 |
! |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
320 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
321 |
checkMethodSTCCompilability1: method into: problem |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
322 |
"Checks is the method can be compiled by STC based on Parser error/warnings" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
323 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
324 |
| lang | |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
325 |
lang := method programmingLanguage. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
326 |
lang isSmalltalk ifFalse:[ ^ self ]. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
327 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
328 |
lang compilerClass new |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
329 |
compile:method source |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
330 |
forClass:method mclass |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
331 |
inCategory:'others' |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
332 |
notifying:problem |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
333 |
install:false |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
334 |
skipIfSame:false |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
335 |
silent:false |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
336 |
foldConstants:true |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
337 |
ifFail:[ ] |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
338 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
339 |
"Created: / 11-04-2012 / 15:31:00 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
340 |
! |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
341 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
342 |
checkMethodSTCCompilability2: method into: problem |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
343 |
"Checks is the method can be compiled by STC based on selected lint rules" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
344 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
345 |
"Not yet implemented" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
346 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
347 |
"Created: / 11-04-2012 / 15:54:06 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
348 |
! |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
349 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
350 |
checkMethodSTCCompilability: method |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
351 |
"Checks is the method can be compiled by STC (since STC won't compile |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
352 |
everything bytecode compiler/jit compiler does, sigh" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
353 |
|
3064 | 354 |
| issue | |
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
355 |
|
3064 | 356 |
"No need to check the method if the class is autoloaded" |
357 |
(packageDef autoloaded_classNames includes: method mclass theNonMetaclass name) ifTrue:[ |
|
358 |
^ self |
|
359 |
]. |
|
360 |
||
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
361 |
issue := ProjectProblem newMethodCompilabilityIssue. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
362 |
issue method: method. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
363 |
self checkMethodSTCCompilability1: method into: issue. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
364 |
self checkMethodSTCCompilability2: method into: issue. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
365 |
issue hasIssue ifTrue:[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
366 |
self addProblem: issue |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
367 |
] |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
368 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
369 |
"Created: / 11-04-2012 / 12:37:17 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
370 |
! |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
371 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
372 |
checkMethodSourceCode: method |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
373 |
"Checks, whether method's source code is both |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
374 |
available and parseable. Return true if the code |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
375 |
is syntactically corret, false otherwise" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
376 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
377 |
| source | |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
378 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
379 |
[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
380 |
source := method source. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
381 |
] on: Error do:[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
382 |
self addProblem: |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
383 |
(ProjectProblem newMethodSourceNotAvailable method: method). |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
384 |
^false |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
385 |
]. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
386 |
[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
387 |
(Parser parseMethod: method source) == #Error ifTrue:[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
388 |
self addProblem: |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
389 |
(ProjectProblem newMethodSourceCorrupted method: method). |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
390 |
^false. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
391 |
] |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
392 |
] on: Error do:[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
393 |
self addProblem: |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
394 |
(ProjectProblem newMethodSourceCorrupted method: method). |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
395 |
^false. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
396 |
]. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
397 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
398 |
^true |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
399 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
400 |
"Created: / 11-04-2012 / 12:29:06 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
2707 | 401 |
! ! |
402 |
||
403 |
!ProjectChecker methodsFor:'checks-private'! |
|
404 |
||
405 |
checkClasses |
|
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
406 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
407 |
classes notNil ifTrue:[ |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
408 |
self checkClasses: classes |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
409 |
] ifFalse:[ |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
410 |
self checkClasses: (Smalltalk allClasses select:[:cls | (cls package = self package)]). |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
411 |
]. |
2707 | 412 |
|
413 |
"Created: / 11-01-2012 / 16:55:48 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
414 |
! |
|
415 |
||
3020
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
416 |
checkClasses: classesToCheck |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
417 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
418 |
self checkClassesListedInProjectDefinition: classesToCheck. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
419 |
self checkForMethodsInNoProject: classesToCheck. |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
420 |
|
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
421 |
"Created: / 13-02-2012 / 18:18:18 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
422 |
! |
240c299584af
Improvements in project checker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3019
diff
changeset
|
423 |
|
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
424 |
checkMethod: method |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
425 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
426 |
(self checkMethodSourceCode: method) ifTrue:[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
427 |
"/OK, method's source is OK, perform further checks |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
428 |
self checkMethodSTCCompilability: method. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
429 |
self checkMethodCodingStyle: method. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
430 |
] |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
431 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
432 |
"Created: / 11-04-2012 / 12:27:33 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
433 |
! |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
434 |
|
2707 | 435 |
checkMethods |
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
436 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
437 |
methods notEmptyOrNil ifTrue:[ |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
438 |
self checkMethods: methods. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
439 |
^self. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
440 |
]. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
441 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
442 |
self checkMethods: |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
443 |
(Iterator on:[:whatToDo| |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
444 |
(classes notNil ifTrue:[classes] ifFalse:[Smalltalk allClasses]) do:[:cls| |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
445 |
cls theNonMetaclass withAllPrivateClassesDo:[:each | |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
446 |
each instAndClassSelectorsAndMethodsDo:[:s :m | m package = package ifTrue:[whatToDo value:m]] |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
447 |
]. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
448 |
] |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
449 |
]) |
2707 | 450 |
|
451 |
"Created: / 11-01-2012 / 16:55:49 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
452 |
! |
|
453 |
||
3046
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
454 |
checkMethods: methodsToCheck |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
455 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
456 |
methodsToCheck do:[:m|self checkMethod: m]. |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
457 |
|
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
458 |
"Created: / 11-04-2012 / 12:16:58 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
459 |
! |
c99775eaf08a
Improvements in ProjectChecker - now it checks for corrupted source and uncompilable methods
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3037
diff
changeset
|
460 |
|
2707 | 461 |
checkPackage |
462 |
||
2716
9a74597bcd4b
Do not use annotations as stc crashes when compiling them
vrany
parents:
2707
diff
changeset
|
463 |
self checkClassListConsistency. |
2718 | 464 |
self checkExtensionsListConsistency. |
465 |
self checkExtensionsPrerequisites. |
|
466 |
||
2716
9a74597bcd4b
Do not use annotations as stc crashes when compiling them
vrany
parents:
2707
diff
changeset
|
467 |
"add more here..." |
2707 | 468 |
|
469 |
"Created: / 11-01-2012 / 16:55:32 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
|
470 |
! ! |
|
471 |
||
472 |
!ProjectChecker methodsFor:'reporting'! |
|
473 |
||
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
474 |
addProblem: aProjectProblem |
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
475 |
aProjectProblem package: self package. |
2707 | 476 |
problems isNil ifTrue:[problems := OrderedCollection new]. |
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
477 |
problems add: aProjectProblem |
2707 | 478 |
|
3023
ed74806df5bc
Improvements in ProjectChecker
Jan Vrany <jan.vrany@fit.cvut.cz>
parents:
3022
diff
changeset
|
479 |
"Created: / 23-02-2012 / 13:10:46 / Jan Vrany <jan.vrany@fit.cvut.cz>" |
2718 | 480 |
! ! |
481 |
||
2707 | 482 |
!ProjectChecker class methodsFor:'documentation'! |
483 |
||
484 |
version |
|
3081 | 485 |
^ '$Id: ProjectChecker.st 1960 2012-09-07 10:45:07Z vranyj1 $' |
3065 | 486 |
! |
487 |
||
488 |
version_CVS |
|
489 |
^ '§Header: /cvs/stx/stx/libbasic3/ProjectChecker.st,v 1.6 2012/07/26 11:59:15 vrany Exp §' |
|
3012 | 490 |
! |
491 |
||
492 |
version_SVN |
|
3081 | 493 |
^ '$Id: ProjectChecker.st 1960 2012-09-07 10:45:07Z vranyj1 $' |
3012 | 494 |
! ! |