#REFACTORING by cg
authorClaus Gittinger <cg@exept.de>
Wed, 17 Jan 2018 13:59:32 +0100
changeset 4297 4922c41a64d7
parent 4296 b9632c3b76c2
child 4298 736e531022ff
#REFACTORING by cg class: CVSSourceCodeManager class comment/format in: #diffListFor:fileName:directory:module:revision1:revision2:cache: changed: #executeCVSCommand:module:inDirectory:log:pipe:orElseOutputTo:errorTo:
CVSSourceCodeManager.st
--- a/CVSSourceCodeManager.st	Tue Jan 16 17:16:32 2018 +0100
+++ b/CVSSourceCodeManager.st	Wed Jan 17 13:59:32 2018 +0100
@@ -1,3 +1,5 @@
+"{ Encoding: utf8 }"
+
 "
  COPYRIGHT (c) 1995 by Claus Gittinger
               All Rights Reserved
@@ -1104,10 +1106,9 @@
         ok := rslt notNil.
     ] ifFalse:[
         osProcess := OSProcess new
-                        command:command;
+                        command:command directory:pathOfDir;
                         outStream:outStreamOrNil;
-                        errorStream:errorStreamOrNil;
-                        directory:pathOfDir.
+                        errorStream:errorStreamOrNil.
 
         Processor isDispatching ifFalse:[
             "/ special hack to allow source code access during the initialization
@@ -4586,17 +4587,17 @@
             "/ The repair code will be removed at some time in the future...
 
             "/ temporary fix Felix' bad string translation:
-            (aString startsWith:'§Header:') ifTrue:[
-                (aString endsWith:'Exp §') ifTrue:[
+            (aString startsWith:'§Header:') ifTrue:[
+                (aString endsWith:'Exp §') ifTrue:[
                     fixedString := '$' , (aString copyFrom:3 to:(aString size - 2)) , '$'.
 
                     aClass isNil ifTrue:[
                         autoFixHolder value ifFalse:[
-                            Dialog information:'Attention: the CVS version string is corrupted (§-bug). Please fix it manually'.
+                            Dialog information:'Attention: the CVS version string is corrupted (§-bug). Please fix it manually'.
                         ]
                     ] ifFalse:[
                         (autoFixHolder value 
-                            or:[ Dialog confirm:('Attention: the CVS version string is corrupted in "%1" (§-bug). Fix it?' withCRs bindWith:aClass name) ]
+                            or:[ Dialog confirm:('Attention: the CVS version string is corrupted in "%1" (§-bug). Fix it?' withCRs bindWith:aClass name) ]
                         ) ifTrue:[
                             self updateVersionMethodOf:aClass for:fixedString.
                         ].
@@ -4604,7 +4605,7 @@
                 ].
             ].
 
-            "/ temporary fix Jan's bad Umlaut-removal (which results in Felix's bad § being removed):
+            "/ temporary fix Jan's bad Umlaut-removal (which results in Felix's bad § being removed):
             (aString startsWith:'Header: ') ifTrue:[
                 (aString endsWith:'Exp ') ifTrue:[
                     fixedString := '$' , aString , '$'.
@@ -5715,7 +5716,7 @@
         fullName :=  modulePath , '/' , (classFileName := classFileNameArg).
     ].
 
-   (cacheIt) ifTrue:[
+    (cacheIt) ifTrue:[
         (cacheDir := self sourceCacheDirectory) isNil ifTrue:[
             ('CVSSourceCodeManager [warning]: no source cache directory') infoPrintCR.
         ] ifFalse:[
@@ -5916,7 +5917,7 @@
     "/ $-Revision: rev $
     "/ $-Id:       fileName rev date time user state $
     "/
-    (firstWord = '$Header:' or:[firstWord = '§Header:']) ifTrue:[
+    (firstWord = '$Header:' or:[firstWord = '§Header:']) ifTrue:[
         d := firstWord first.
         s skipSeparators.
         nm := s throughAll:',v '.
@@ -5946,12 +5947,12 @@
         ^ info
     ].
 
-    (firstWord = '$Revision:' or:[firstWord = '§Revision:']) ifTrue:[
+    (firstWord = '$Revision:' or:[firstWord = '§Revision:']) ifTrue:[
         info revision:(s upToEnd asCollectionOfWords first).
         ^ info
     ].
 
-    (firstWord = '$Id:' or:[firstWord = '§Id:']) ifTrue:[
+    (firstWord = '$Id:' or:[firstWord = '§Id:']) ifTrue:[
         "/commented out by Jan Vrany, 2009/10/20
         "/according to http://svnbook.red-bean.com/en/1.5/svn.advanced.props.special.keywords.html
         "/svn has no support for $ Header $ expansion. Therefore