class: Parser
authorClaus Gittinger <cg@exept.de>
Tue, 27 Aug 2013 19:52:09 +0200
changeset 3297 10b0140f855c
parent 3296 36bcb09481fc
child 3298 7974ee6d7b9c
class: Parser added: #checkBracketParenthesisMistakeInIfOrWhile:from:to: changed: #checkPlausibilityOf:from:to:
Parser.st
--- a/Parser.st	Tue Aug 27 18:53:00 2013 +0200
+++ b/Parser.st	Tue Aug 27 19:52:09 2013 +0200
@@ -2367,6 +2367,46 @@
     "Modified: / 16-03-2012 / 18:40:48 / cg"
 !
 
+checkBracketParenthesisMistakeInIfOrWhile:aNode from:startPosition to:endPosition
+    |sel receiver|
+
+    aNode isMessage ifTrue:[
+        sel := aNode selector.
+        receiver := aNode receiver.
+
+        (sel = #and: or:[sel = #or:]) ifTrue:[
+            aNode arg1 isBlock ifFalse:[
+                (aNode arg1 isVariable
+                and:[ (aNode arg1 name asLowercase includesString:'block')]) ifFalse:[
+                    self warnCommonMistake:'(possible common mistake) missing block brackets ?'
+                              position:endPosition+1 to:tokenPosition-1
+                ]
+            ].
+        ].
+
+        (sel = #whileTrue: or:[sel = #whileFalse:]) ifTrue:[
+            receiver isBlock ifFalse:[
+                (receiver isVariable
+                and:[ (receiver name asLowercase includesString:'block')]) ifFalse:[
+                    self warnCommonMistake:'(possible common mistake) missing block brackets ?'
+                              position:startPosition to:endPosition
+                ]
+            ].
+        ].
+
+        (sel = #ifTrue: or:[sel = #ifFalse:]) ifTrue:[
+            receiver isMessage ifTrue:[
+                (receiver selector = #whileTrue or:[receiver selector = #whileFalse]) ifTrue:[
+                    self warnCommonMistake:'strange receiver expression'
+                              position:startPosition to:endPosition
+                ].
+            ].
+        ].
+    ].
+
+    "Created: / 19-01-2012 / 10:44:05 / cg"
+!
+
 checkForLowercaseVariableName:aVariableName
     |msg|
 
@@ -2562,7 +2602,7 @@
 !
 
 checkPlausibilityOf:aNode from:startPosition to:endPosition
-    |note fixes sel receiver|
+    |note fixes|
 
     (ignoreErrors or:[ignoreWarnings]) ifTrue:[^ self].
     parserFlags warnPlausibilityChecks ifFalse:[^ self].
@@ -2592,37 +2632,7 @@
     ].
 
     aNode isMessage ifTrue:[
-        sel := aNode selector.
-        receiver := aNode receiver.
-
-        (sel = #and: or:[sel = #or:]) ifTrue:[
-            aNode arg1 isBlock ifFalse:[
-                (aNode arg1 isVariable
-                and:[ (aNode arg1 name asLowercase includesString:'block')]) ifFalse:[
-                    self warnCommonMistake:'(possible common mistake) missing block brackets ?'
-                              position:endPosition+1 to:tokenPosition-1
-                ]
-            ].
-        ].
-
-        (sel = #whileTrue: or:[sel = #whileFalse:]) ifTrue:[
-            receiver isBlock ifFalse:[
-                (receiver isVariable
-                and:[ (receiver name asLowercase includesString:'block')]) ifFalse:[
-                    self warnCommonMistake:'(possible common mistake) missing block brackets ?'
-                              position:startPosition to:endPosition
-                ]
-            ].
-        ].
-
-        (sel = #ifTrue: or:[sel = #ifFalse:]) ifTrue:[
-            receiver isMessage ifTrue:[
-                (receiver selector = #whileTrue or:[receiver selector = #whileFalse]) ifTrue:[
-                    self warnCommonMistake:'strange receiver expression'
-                              position:startPosition to:endPosition
-                ].
-            ].
-        ].
+        self checkBracketParenthesisMistakeInIfOrWhile:aNode from:startPosition to:endPosition
     ].
 
     "Created: / 19-01-2012 / 10:44:05 / cg"
@@ -11610,11 +11620,11 @@
 !Parser class methodsFor:'documentation'!
 
 version
-    ^ '$Header: /cvs/stx/stx/libcomp/Parser.st,v 1.782 2013-08-27 09:46:07 vrany Exp $'
+    ^ '$Header: /cvs/stx/stx/libcomp/Parser.st,v 1.783 2013-08-27 17:52:09 cg Exp $'
 !
 
 version_CVS
-    ^ '$Header: /cvs/stx/stx/libcomp/Parser.st,v 1.782 2013-08-27 09:46:07 vrany Exp $'
+    ^ '$Header: /cvs/stx/stx/libcomp/Parser.st,v 1.783 2013-08-27 17:52:09 cg Exp $'
 !
 
 version_SVN